drivers: nvme: target: core: Pass lockdep expression to RCU lists
Subsystems (2)
PATCH v3 1/1 drivers: nvme: target: core: Pass lockdep expression to RCU lists
ctrl->subsys->namespaces and subsys->namespaces are traversed with list_for_each_entry_rcu outside an RCU read-side critical section but under the protection of ctrl->subsys->lock and subsys->lock respectively.
Hence, add the corresponding lockdep expression to the list traversal primitive to silence false-positive lockdep warnings, and harden RCU lists.
---
v3:
- Fix error reported by kbuild test robot
v2:
- Fix sparse error
CHECK: Alignment should match open parenthesis
- Remove global macro and use local lockdep expressions
drivers/nvme/target/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/nvme/target/core.c +4 -2
@@ -555,7 +555,8 @@ int nvmet_ns_enable(struct nvmet_ns *ns) }else {struct nvmet_ns *old; -list_for_each_entry_rcu (old, &subsys->namespaces, dev_link) { +list_for_each_entry_rcu (old, &subsys->namespaces, dev_link, +lockdep_is_held (&subsys->lock)) {BUG_ON (ns->nsid == old->nsid);if (ns->nsid < old->nsid)break ;
@@ -1172,7 +1173,8 @@ static void nvmet_setup_p2p_ns_map(struct nvmet_ctrl *ctrl, ctrl->p2p_client =get_device (req->p2p_client); -list_for_each_entry_rcu (ns, &ctrl->subsys->namespaces, dev_link) +list_for_each_entry_rcu (ns, &ctrl->subsys->namespaces, dev_link, +lockdep_is_held (&ctrl->subsys->lock))nvmet_p2pmem_ns_add_p2p (ctrl, ns); }
Signature · 6 lines
2.24.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Keith Busch
maintainerQuoted 5 lines · Amol Grover
ctrl->subsys->namespacesandsubsys->namespacesare traversed withlist_for_each_entry_rcuoutside an RCU read-side critical section but under the protection ofctrl->subsys->lockandsubsys->lockrespectively.
Quoted 7 lines
Hence, add the corresponding lockdep expression to the list traversal primitive to silence false-positive lockdep warnings, and harden RCU lists.
Reported-by kbuild test robot <[email protected]>Reviewed-by Joel Fernandes (Google) <[email protected]>Signed-off-by Amol Grover <[email protected]>
Thanks, added for-5.6.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees