Skip to contentSkip to conversation

staging: exfat: make staging/exfat and fs/exfat mutually exclusive

PATCH In review Namjae Jeon 2 participants 3 messages Jan 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: exfat: make staging/exfat and fs/exfat mutually exclusive

From: Namjae Jeon <[email protected]>

Make staging/exfat and fs/exfat mutually exclusive to select the one between two same filesystem.

---
 drivers/staging/exfat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/exfat/Kconfig +1 -1
index 292a19dfcaf5..9a0fccec65d9 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config STAGING_EXFAT_FS
 	tristate "exFAT fs support"
-	depends on BLOCK
+	depends on BLOCK && !EXFAT_FS
 	select NLS
 	help
 	  This adds support for the exFAT file system.
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 16 lines · Namjae Jeon

From: Namjae Jeon <[email protected]>

Make staging/exfat and fs/exfat mutually exclusive to select the one between two same filesystem.

---
 drivers/staging/exfat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/exfat/Kconfig +0 -0
index 292a19dfcaf5..9a0fccec65d9 100644

drivers/staging/exfat/Kconfig line 4

Quoted 5 lines
drivers/staging/exfat/Kconfig +1 -1
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config STAGING_EXFAT_FS
 	tristate "exFAT fs support"
-	depends on BLOCK
+	depends on BLOCK && !EXFAT_FS

There is no such symbol in the kernel tree, so this isn't going to do anything :(

When/if EXFAT_FS does show up, I will be glad to add this. Or better yet, just have this as part of the "real" exfat patchset, that would make the most sense, right?

thanks,

greg k-h

#2 lore raw

2020-01-12 2:56 GMT+09:00, Greg KH <[email protected]>:

Quoted 27 lines · Namjae Jeon
Quoted 17 lines

From: Namjae Jeon <[email protected]>

Make staging/exfat and fs/exfat mutually exclusive to select the one between two same filesystem.

---
 drivers/staging/exfat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/exfat/Kconfig +0 -0
index 292a19dfcaf5..9a0fccec65d9 100644

drivers/staging/exfat/Kconfig line 4

Quoted 5 lines
drivers/staging/exfat/Kconfig +1 -1
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config STAGING_EXFAT_FS
 	tristate "exFAT fs support"
-	depends on BLOCK
+	depends on BLOCK && !EXFAT_FS

There is no such symbol in the kernel tree, so this isn't going to do anything :(

Quoted 3 lines

When/if EXFAT_FS does show up, I will be glad to add this. Or better yet, just have this as part of the "real" exfat patchset, that would make the most sense, right?

Right,
Thanks!

Quoted 5 lines

thanks,

greg k-h