fbdev: c2p: Use BUILD_BUG() instead of custom solution
PATCH 1/1 fbdev: c2p: Use BUILD_BUG() instead of custom solution
Replace the call to the custom non-existing function by a standard BUILD_BUG() invocation.
--- drivers/video/fbdev/c2p_core.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/video/fbdev/c2p_core.h +6 -6
@@ -12,6 +12,8 @@* for more details. */ +#include <linux/build_bug.h> +/* * Basic transpose step
@@ -27,8 +29,6 @@ static inline void _transp(u32 d[], unsigned int i1, unsigned int i2, } -extern void c2p_unsupported (void ); - static __always_inline u32 get_mask(unsigned int n) {switch (n) {
@@ -48,7 +48,7 @@ static __always_inline u32 get_mask(unsigned int n)return 0x0000ffff ; } -c2p_unsupported (); +BUILD_BUG ();return 0 ; }
@@ -91,7 +91,7 @@ static __always_inline void transp8(u32 d[], unsigned int n, unsigned int m)return ; } -c2p_unsupported (); +BUILD_BUG (); }
@@ -118,7 +118,7 @@ static __always_inline void transp4(u32 d[], unsigned int n, unsigned int m)return ; } -c2p_unsupported (); +BUILD_BUG (); }
@@ -138,7 +138,7 @@ static __always_inline void transp4x(u32 d[], unsigned int n, unsigned int m)return ; } -c2p_unsupported (); +BUILD_BUG (); }
Signature · 1 line
2.17.1
Geert Uytterhoeven
AppliedQuoted 5 lines · Geert Uytterhoeven
Replace the call to the custom non-existing function by a standard
BUILD_BUG()invocation.Suggested-by Masahiro Yamada <[email protected]>Signed-off-by Geert Uytterhoeven <[email protected]>
Thanks, applied and queued for v5.7.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 8 lines · Geert Uytterhoeven
Quoted 5 lines · Geert Uytterhoeven
Replace the call to the custom non-existing function by a standard
BUILD_BUG()invocation.Suggested-by Masahiro Yamada <[email protected]>Signed-off-by Geert Uytterhoeven <[email protected]>Thanks, applied and queued for v5.7.
Sorry, this is fbdev-material, not m68k-material.
If you mind, I can drop it from the m68k for-v5.7 branch again.
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 6 lines · Geert Uytterhoeven
Quoted 4 lines · Geert Uytterhoeven
Quoted 3 lines · Geert Uytterhoeven
Replace the call to the custom non-existing function by a standard
BUILD_BUG()invocation.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Suggested-by Masahiro Yamada <[email protected]>Signed-off-by Geert Uytterhoeven <[email protected]>Thanks, applied and queued for v5.7.
Sorry, this is fbdev-material, not m68k-material.
If you mind, I can drop it from the m68k for-v5.7 branch again.
I don't mind, lets keep it m68k tree (it should not cause any conflicts with other fbdev changes).
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics