i2c: iop3xx: Fix memory leak in probe error path
PATCH 1/1 i2c: iop3xx: Fix memory leak in probe error path
When handling devm_gpiod_get_optional() errors, free the memory already allocated. This fixes Smatch warnings:
drivers/i2c/busses/i2c-iop3xx.c:437 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter' drivers/i2c/busses/i2c-iop3xx.c:442 iop3xx_i2c_probe() warn: possible memory leak of 'new_adapter'
--- drivers/i2c/busses/i2c-iop3xx.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/i2c/busses/i2c-iop3xx.c +8 -4
@@ -433,13 +433,17 @@ iop3xx_i2c_probe(struct platform_device *pdev) adapter_data->gpio_scl =devm_gpiod_get_optional (&pdev->dev,"scl" ,GPIOD_ASIS ); -if (IS_ERR (adapter_data->gpio_scl)) -return PTR_ERR (adapter_data->gpio_scl); +if (IS_ERR (adapter_data->gpio_scl)) { + ret =PTR_ERR (adapter_data->gpio_scl); + goto free_both; + } adapter_data->gpio_sda =devm_gpiod_get_optional (&pdev->dev,"sda" ,GPIOD_ASIS ); -if (IS_ERR (adapter_data->gpio_sda)) -return PTR_ERR (adapter_data->gpio_sda); +if (IS_ERR (adapter_data->gpio_sda)) { + ret =PTR_ERR (adapter_data->gpio_sda); + goto free_both; + } res =platform_get_resource (pdev,IORESOURCE_MEM ,0 );if (!res) {
Signature · 1 line
2.17.1
Wolfram Sang
AppliedQuoted 9 lines · Krzysztof Kozlowski
When handling
devm_gpiod_get_optional()errors, free the memory already allocated. This fixes Smatch warnings:
drivers/i2c/busses/i2c-iop3xx.c:437iop3xx_i2c_probe()warn: possible memory leak of 'new_adapter'drivers/i2c/busses/i2c-iop3xx.c:442iop3xx_i2c_probe()warn: possible memory leak of 'new_adapter'Reported-by kbuild test robot <[email protected]>Reported-by Dan Carpenter <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied to for-current, thanks! Please add a 'Fixes' tag next time, added it for you now.