HID: logitech-dj: add debug msg when exporting a HID++ report descriptors
Subsystems (2)
PATCH 1/1 HID: logitech-dj: add debug msg when exporting a HID++ report descriptors
When exporting all other types of report descriptors we print a debug message. Not doing so for HID++ descriptors makes unaware users think that no HID++ descriptor was exported.
--- drivers/hid/hid-logitech-dj.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/hid/hid-logitech-dj.c +2 -0
@@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid) }if (djdev->reports_supported &HIDPP ) { +dbg_hid ("%s: sending a HID++ descriptor, reports_supported: %llx\n" , + __func__, djdev->reports_supported);rdcat (rdesc, &rsize, hidpp_descriptor,sizeof (hidpp_descriptor)); }
Signature · 1 line
2.24.1
Hi Filipe,
Quoted 4 lines · Filipe Laíns
When exporting all other types of report descriptors we print a debug message. Not doing so for HID++ descriptors makes unaware users think that no HID++ descriptor was exported.
Unless I am mistaken, those dbg_hid() calls are not displayed by default on any distribution. So I am not sure what is the benefit to add this one here when we are already not showing the rest to the users by default. There is a tiny improvement to have some code symmetry, but here, honestly, it doesn't feel that required.
Cheers,
Benjamin
Quoted 22 lines
Signed-off-by Filipe Laíns <[email protected]>--- drivers/hid/hid-logitech-dj.c | 2 ++ 1 file changed, 2 insertions(+)drivers/hid/hid-logitech-dj.c +2
-1@@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid) }if (djdev->reports_supported &HIDPP ) { +dbg_hid ("%s: sending a HID++ descriptor, reports_supported: %llx\n" , + __func__, djdev->reports_supported);rdcat (rdesc, &rsize, hidpp_descriptor,sizeof (hidpp_descriptor)); } --2.24.1
Quoted 7 lines · Benjamin Tissoires
Hi Filipe,
Quoted 3 lines · Filipe Laíns
When exporting all other types of report descriptors we print a debug message. Not doing so for HID++ descriptors makes unaware users think that no HID++ descriptor was exported.
Quoted 8 lines
Unless I am mistaken, those
dbg_hid()calls are not displayed by default on any distribution. So I am not sure what is the benefit to add this one here when we are already not showing the rest to the users by default. There is a tiny improvement to have some code symmetry, but here, honestly, it doesn't feel that required.Cheers,
Benjamin
Hi Benjamin,
As far as I know, they aren't. This was just a nitpick. As I already had the code locally I decided to just go ahead and submit the patch. But noted, I won't submit any more of this nitpick patches.
Quoted 12 lines
Quoted 12 lines
Signed-off-by Filipe Laíns <[email protected]>--- drivers/hid/hid-logitech-dj.c | 2 ++ 1 file changed, 2 insertions(+)drivers/hid/hid-logitech-dj.c +0
-0@@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid) }
Quoted 9 lines
Quoted 9 lines
drivers/hid/hid-logitech-dj.c +2
-1if (djdev->reports_supported &HIDPP ) { +dbg_hid ("%s: sending a HID++ descriptor, reports_supported: %llx\n" , + __func__, djdev->reports_supported);rdcat (rdesc, &rsize, hidpp_descriptor,sizeof (hidpp_descriptor)); } --2.24.1
Thank you,
Filipe Laíns
Quoted 14 lines · Filipe Laíns
When exporting all other types of report descriptors we print a debug message. Not doing so for HID++ descriptors makes unaware users think that no HID++ descriptor was exported.
Signed-off-by Filipe Laíns <[email protected]>--- drivers/hid/hid-logitech-dj.c | 2 ++ 1 file changed, 2 insertions(+)drivers/hid/hid-logitech-dj.c +0
-0
drivers/hid/hid-logitech-dj.c static int logi_dj_ll_parse(struct hid_device *hid) · line 1374
Quoted 7 lines
drivers/hid/hid-logitech-dj.c +2
-0@@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid) }if (djdev->reports_supported &HIDPP ) { +dbg_hid ("%s: sending a HID++ descriptor, reports_supported: %llx\n" , + __func__, djdev->reports_supported);rdcat (rdesc, &rsize, hidpp_descriptor,sizeof (hidpp_descriptor));
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs