dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema
Subsystems (2)
Rob Herring
maintainerPATCH 1/1 dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema
The intel,rcu-gw binding example has an error:
Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml:
reset-controller@e0000000: intel,global-reset: [[16, 30]] is too short
The error isn't really correct as the problem is in how the data is encoded and the schema is not fixed up by the tooling correctly. However, array properties should describe the elements in the array, so lets do that which fixes the error in the process.
--- Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml +5 -1
@@ -23,7 +23,11 @@ properties: description: Global reset register offset and bit offset. allOf: - $ref: /schemas/types.yaml#/definitions/uint32-array - - maxItems: 2 + items: + - description: Register offset + - description: Register bit offset + minimum: 0 + maximum: 31 "#reset-cells": minimum: 2
Signature · 1 line
2.20.1
Quoted 9 lines · Rob Herring
The intel,rcu-gw binding example has an error:
Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml:reset-controller@e0000000: intel,global-reset: [[16, 30]] is too shortThe error isn't really correct as the problem is in how the data is encoded and the schema is not fixed up by the tooling correctly. However, array properties should describe the elements in the array, so lets do that which fixes the error in the process.
Sure, i will add the change describing the array properties and push as a fix patch.
Regards,
Dilip
Quoted 26 lines
Fixes b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller")Cc Philipp Zabel <[email protected]>Cc Dilip Kota <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml +5
-1@@ -23,7 +23,11 @@ properties: description: Global reset register offset and bit offset. allOf: - $ref: /schemas/types.yaml#/definitions/uint32-array - - maxItems: 2 + items: + - description: Register offset + - description: Register bit offset + minimum: 0 + maximum: 31 "#reset-cells": minimum: 2
Hi Rob,
My bad, please ignore my response.
I just directly jumped into the error and felt you are suggesting me to send a separate patch to fix the error. After sending the mail i realized by reading the subject that you already submitted the fix patch. Please ignore it,
Thanks for doing it.
Regards,
Dilip
Quoted 44 lines · Dilip Kota
Quoted 9 lines · Rob Herring
The intel,rcu-gw binding example has an error:
Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml:
reset-controller@e0000000: intel,global-reset: [[16, 30]] is too shortThe error isn't really correct as the problem is in how the data is encoded and the schema is not fixed up by the tooling correctly. However, array properties should describe the elements in the array, so lets do that which fixes the error in the process.
Sure, i will add the change describing the array properties and push as a fix patch.
Regards,
Dilip
Quoted 25 lines
Fixes b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller")Cc Philipp Zabel <[email protected]>Cc Dilip Kota <[email protected]>Signed-off-by Rob Herring <[email protected]>---
Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml| 6 +++++-1 file changed, 5 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml +0
-0@@ -23,7 +23,11 @@ properties:description: Global reset register offset and bit offset. allOf:
- $ref: /schemas/types.yaml#/definitions/uint32-array - - maxItems: 2
+ items:
+ - description: Register offset
+ - description: Register bit offset
+ minimum: 0
+ maximum: 31
"#reset-cells":
minimum: 2
Hi Rob,
Quoted 25 lines · Rob Herring
The intel,rcu-gw binding example has an error:
Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml:
reset-controller@e0000000: intel,global-reset: [[16, 30]] is too shortThe error isn't really correct as the problem is in how the data is encoded and the schema is not fixed up by the tooling correctly. However, array properties should describe the elements in the array, so lets do that which fixes the error in the process.
Fixes b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller")Cc Philipp Zabel <[email protected]>Cc Dilip Kota <[email protected]>Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml +0
-0@@ -23,7 +23,11 @@ properties: description: Global reset register offset and bit offset. allOf:
Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml properties: · line 33
Quoted 10 lines
Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml +5
-1- $ref: /schemas/types.yaml#/definitions/uint32-array - - maxItems: 2 + items: + - description: Register offset + - description: Register bit offset + minimum: 0 + maximum: 31 "#reset-cells": minimum: 2
Thank you, applied to reset/next.
regards
Philipp