dt-bindings: memory-controller: Update example for Tegra124 EMC
PATCH 1/1 dt-bindings: memory-controller: Update example for Tegra124 EMC
From: Thierry Reding <[email protected]>
The example in the Tegra124 EMC device tree binding looks like an old version that doesn't contain all the required fields. Update it with a version from the current DTS files to fix the make dt_binding_check target.
--- .../nvidia,tegra124-emc.yaml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
Documentation/devicetree/bindings/memory-controllers/nvidia,tegra124-emc.yaml +11 -8
@@ -363,20 +363,23 @@ examples: timing-0 { clock-frequency = <12750000>; - nvidia,emc-zcal-cnt-long = <0x00000042>; - nvidia,emc-auto-cal-interval = <0x001fffff>; - nvidia,emc-ctt-term-ctrl = <0x00000802>; - nvidia,emc-cfg = <0x73240000>; - nvidia,emc-cfg-2 = <0x000008c5>; - nvidia,emc-sel-dpd-ctrl = <0x00040128>; - nvidia,emc-bgbias-ctl0 = <0x00000008>; nvidia,emc-auto-cal-config = <0xa1430000>; nvidia,emc-auto-cal-config2 = <0x00000000>; nvidia,emc-auto-cal-config3 = <0x00000000>; - nvidia,emc-mode-reset = <0x80001221>; + nvidia,emc-auto-cal-interval = <0x001fffff>; + nvidia,emc-bgbias-ctl0 = <0x00000008>; + nvidia,emc-cfg = <0x73240000>; + nvidia,emc-cfg-2 = <0x000008c5>; + nvidia,emc-ctt-term-ctrl = <0x00000802>; nvidia,emc-mode-1 = <0x80100003>; nvidia,emc-mode-2 = <0x80200008>; nvidia,emc-mode-4 = <0x00000000>; + nvidia,emc-mode-reset = <0x80001221>; + nvidia,emc-mrs-wait-cnt = <0x000e000e>; + nvidia,emc-sel-dpd-ctrl = <0x00040128>; + nvidia,emc-xm2dqspadctrl2 = <0x0130b118>; + nvidia,emc-zcal-cnt-long = <0x00000042>; + nvidia,emc-zcal-interval = <0x00000000>; nvidia,emc-configuration = < 0x00000000 /* EMC_RC */
Signature · 1 line
2.24.1
Quoted 8 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The example in the Tegra124 EMC device tree binding looks like an old version that doesn't contain all the required fields. Update it with a version from the current DTS files to fix the make
dt_binding_checktarget.
Quoted 5 lines
Reported-by Rob Herring <[email protected]>Signed-off-by Thierry Reding <[email protected]>--- .../nvidia,tegra124-emc.yaml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
Thanks for fixing quickly.
Quoted 16 lines · Rob Herring
Quoted 8 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The example in the Tegra124 EMC device tree binding looks like an old version that doesn't contain all the required fields. Update it with a version from the current DTS files to fix the make
dt_binding_checktarget.Quoted 5 lines
Reported-by Rob Herring <[email protected]>Signed-off-by Thierry Reding <[email protected]>--- .../nvidia,tegra124-emc.yaml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
Quoted 3 lines
Acked-by Rob Herring <[email protected]>Thanks for fixing quickly.
Or not. I assumed you were going to send this via arm-soc given that's where the problem was, but given it still hasn't appeared anywhere and it's in master now I'll apply it.
Rob