Skip to contentSkip to conversation

gstreamer1.0: decouple check and tests options

PATCH In review Alexander Kanavin 2 participants 3 messages Jan 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gstreamer1.0: decouple check and tests options

Some plugins such as gstreamer1.0-plugins-base refuse to build if check is not enabled (which was the case when ptests were disabled).

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.1.bb +3 -1
index dc3e8ffafde..c6fbd398d91 100644
@@ -26,11 +26,13 @@ SRC_URI[md5sum] = "c505fb818b36988daaa846e9e63eabe8"
 SRC_URI[sha256sum] = "02211c3447c4daa55919c5c0f43a82a6fbb51740d57fc3af0639d46f1cf4377d"
 
 PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)} \
+                   check \
                    tools"
 
 PACKAGECONFIG[debug] = "-Dgst_debug=true,-Dgst_debug=false"
 PACKAGECONFIG[tracer-hooks] = "-Dtracer_hooks=true,-Dtracer_hooks=false"
-PACKAGECONFIG[tests] = "-Dcheck=enabled -Dtests=enabled -Dinstalled-tests=true,-Dcheck=disabled -Dtests=disabled -Dinstalled-tests=false"
+PACKAGECONFIG[check] = "-Dcheck=enabled,-Dcheck=disabled"
+PACKAGECONFIG[tests] = "-Dtests=enabled -Dinstalled-tests=true,-Dtests=disabled -Dinstalled-tests=false"
 PACKAGECONFIG[valgrind] = "-Dvalgrind=enabled,-Dvalgrind=disabled,valgrind,"
 PACKAGECONFIG[unwind] = "-Dlibunwind=enabled,-Dlibunwind=disabled,libunwind"
 PACKAGECONFIG[dw] = "-Dlibdw=enabled,-Dlibdw=disabled,elfutils"
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 gstreamer1.0: set the name of the test suite for ptests

Otherwise gnome-desktop-testing-runner starts testing everything unrelated as well (e.g. glib).

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-ptest.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-ptest.inc +2 -0
index 74368c4cd87..b6980670410 100644
@@ -5,6 +5,8 @@ RUN_PTEST_FILE = "${D}${PTEST_PATH}/run-ptest"
 
 EXTRA_OEMESON += "-Dtest-files-path=${TEST_FILES_PATH}"
 
+GST_TEST_SUITE_NAME ?= "gstreamer-1.0"
+
 # Using do_install_ptest_base instead of do_install_ptest, since
 # the default do_install_ptest_base is hardcoded to expect Makefiles.
 do_install_ptest_base() {
Signature · 1 line
2.17.1
#2 lore raw

✗ patchtest: failure for "gstreamer1.0: decouple check a..." and 1 more

In reply to Alexander Kanavin

== Series Details ==

Series: "gstreamer1.0: decouple check a..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/22007/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at b6d4150f9c)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe