Skip to contentSkip to conversation

ARM: dts: Configure omap5 AESS

PATCH In review Tony Lindgren 3 participants 12 messages Jan 14, 2020 – Jan 16, 2020 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Configure omap5 AESS

We are missing AESS for omap5. Looks like it's similar to what we have for omap4, and this gets ti-sysc interconnect target module driver to detect it properly.

Note that we currently have no child device driver available for it.

Cc H. Nikolaus Schaller <[email protected]>
Cc Matthijs van Duin <[email protected]>
Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>

---

Note that this depends on "[PATCH] clk: ti: omap5: Add missing AESS clock".

 arch/arm/boot/dts/omap5-l4-abe.dtsi | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5-l4-abe.dtsi +14 -2
@@ -426,8 +426,20 @@ target-module@c0000 {			/* 0x401c0000, ap 30 1e.0 */
 		};
 
 		target-module@f1000 {			/* 0x401f1000, ap 32 20.0 */
-			compatible = "ti,sysc";
-			status = "disabled";
+			compatible = "ti,sysc-omap4", "ti,sysc";
+			reg = <0xf1000 0x4>,
+			      <0xf1010 0x4>;
+			reg-names = "rev", "sysc";
+			ti,sysc-midle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>,
+					<SYSC_IDLE_SMART_WKUP>;
+			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>;
+			/* Domains (V, P, C): iva, abe_pwrdm, abe_clkdm */
+			clocks = <&abe_clkctrl OMAP5_AESS_CLKCTRL 0>;
+			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges = <0x0 0xf1000 0x1000>,
Signature · 1 line
2.24.1
#1 lore raw

Hi Tony,

Quoted 7 lines

Am 14.01.2020 um 16:09 schrieb Tony Lindgren <[email protected]>:

We are missing AESS for omap5. Looks like it's similar to what we have for omap4, and this gets ti-sysc interconnect target module driver to detect it properly.

Note that we currently have no child device driver available for it.

What I have is a non-working and no more compiling driver originally written by Peter Ujfalusi and reworked by Andrej Utkin. We did have it almost running on v4.14 or so except problems with firmware versions and headers...

There we used classical hwmods and I could revert them now to try your new patches. Unfortunately, I could only compile-test your two patches but nothing with AESS.

We had tried to follow kernel API changes in the sound subsystem but today it is not even compiling any more :(

So getting a working device driver is an even bigger task than SGX was.

Quoted 17 lines
Cc H. Nikolaus Schaller <[email protected]>
Cc Matthijs van Duin <[email protected]>
Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>

---

Note that this depends on "[PATCH] clk: ti: omap5: Add missing AESS clock".

arch/arm/boot/dts/omap5-l4-abe.dtsi | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)

arch/arm/boot/dts/omap5-l4-abe.dtsi target-module@c0000 { /* 0x401c0000, ap 30 1e.0 */ · line 428

Quoted 3 lines
arch/arm/boot/dts/omap5-l4-abe.dtsi +0 -0
@@ -426,8 +426,20 @@ target-module@c0000 {			/* 0x401c0000, ap 30 1e.0 */
 		};
 
 		target-module@f1000 {			/* 0x401f1000, ap 32 20.0 */

Here its may be good to have an "aess" label.

Quoted 21 lines
arch/arm/boot/dts/omap5-l4-abe.dtsi +14 -2
-			compatible = "ti,sysc";
-			status = "disabled";
+			compatible = "ti,sysc-omap4", "ti,sysc";
+			reg = <0xf1000 0x4>,
+			      <0xf1010 0x4>;
+			reg-names = "rev", "sysc";
+			ti,sysc-midle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>,
+					<SYSC_IDLE_SMART_WKUP>;
+			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+					<SYSC_IDLE_NO>,
+					<SYSC_IDLE_SMART>;
+			/* Domains (V, P, C): iva, abe_pwrdm, abe_clkdm */
+			clocks = <&abe_clkctrl OMAP5_AESS_CLKCTRL 0>;
+			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges = <0x0 0xf1000 0x1000>,
Signature · 1 line
2.24.1

BR and thanks,
Nikolaus

#2 lore raw
Quoted 14 lines · H. Nikolaus Schaller

Hi Tony,

Quoted 7 lines

Am 14.01.2020 um 16:09 schrieb Tony Lindgren <[email protected]>:

We are missing AESS for omap5. Looks like it's similar to what we have for omap4, and this gets ti-sysc interconnect target module driver to detect it properly.

Note that we currently have no child device driver available for it.

What I have is a non-working and no more compiling driver originally written by Peter Ujfalusi and reworked by Andrej Utkin. We did have it almost running on v4.14 or so except problems with firmware versions and headers...

Quoted 7 lines

There we used classical hwmods and I could revert them now to try your new patches. Unfortunately, I could only compile-test your two patches but nothing with AESS.

We had tried to follow kernel API changes in the sound subsystem but today it is not even compiling any more :(

So getting a working device driver is an even bigger task than SGX was.

OK. Well hopefully that's at least a little bit easier now though.

Quoted 18 lines
Quoted 18 lines
Cc H. Nikolaus Schaller <[email protected]>
Cc Matthijs van Duin <[email protected]>
Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>

---

Note that this depends on "[PATCH] clk: ti: omap5: Add missing AESS clock".

arch/arm/boot/dts/omap5-l4-abe.dtsi | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5-l4-abe.dtsi +0 -0
@@ -426,8 +426,20 @@ target-module@c0000 {			/* 0x401c0000, ap 30 1e.0 */
 		};
 
Quoted 3 lines

arch/arm/boot/dts/omap5-l4-abe.dtsi target-module@c0000 { /* 0x401c0000, ap 30 1e.0 */ · line 428

Quoted 1 line
arch/arm/boot/dts/omap5-l4-abe.dtsi +0 -0
 		target-module@f1000 {			/* 0x401f1000, ap 32 20.0 */

Here its may be good to have an "aess" label.

Care to clarify what you have in mind? The module is generic, aess device will be the child node.

How about just a comment for aess?

Regards,

Tony

#3 lore raw

Hi Tony,

Quoted 45 lines

Am 14.01.2020 um 17:46 schrieb Tony Lindgren <[email protected]>:

Quoted 14 lines · H. Nikolaus Schaller

Hi Tony,

Quoted 7 lines

Am 14.01.2020 um 16:09 schrieb Tony Lindgren <[email protected]>:

We are missing AESS for omap5. Looks like it's similar to what we have for omap4, and this gets ti-sysc interconnect target module driver to detect it properly.

Note that we currently have no child device driver available for it.

What I have is a non-working and no more compiling driver originally written by Peter Ujfalusi and reworked by Andrej Utkin. We did have it almost running on v4.14 or so except problems with firmware versions and headers...

Quoted 7 lines

There we used classical hwmods and I could revert them now to try your new patches. Unfortunately, I could only compile-test your two patches but nothing with AESS.

We had tried to follow kernel API changes in the sound subsystem but today it is not even compiling any more :(

So getting a working device driver is an even bigger task than SGX was.

OK. Well hopefully that's at least a little bit easier now though.

Quoted 18 lines
Quoted 18 lines
Cc H. Nikolaus Schaller <[email protected]>
Cc Matthijs van Duin <[email protected]>
Cc Peter Ujfalusi <[email protected]>
Cc Tero Kristo <[email protected]>

---

Note that this depends on "[PATCH] clk: ti: omap5: Add missing AESS clock".

arch/arm/boot/dts/omap5-l4-abe.dtsi | 16 ++++++++++++++--

1 file changed, 14 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5-l4-abe.dtsi +0 -0
@@ -426,8 +426,20 @@ target-module@c0000 {			/* 0x401c0000, ap 30 1e.0 */
 		};
 
Quoted 6 lines
Quoted 3 lines

arch/arm/boot/dts/omap5-l4-abe.dtsi target-module@c0000 { /* 0x401c0000, ap 30 1e.0 */ · line 428

Quoted 1 line
arch/arm/boot/dts/omap5-l4-abe.dtsi +0 -0
 		target-module@f1000 {			/* 0x401f1000, ap 32 20.0 */

Here its may be good to have an "aess" label.

Care to clarify what you have in mind? The module is generic, aess device will be the child node.

The existing driver is hooked into the sound root-node and looks for a ti,aess = <&aess>; link:

/ {
	sound: sound {
		compatible = "ti,abe-twl6040";
		ti,model = "omap5-uevm";

		ti,jack-detection;
		ti,mclk-freq = <19200000>;

		ti,mcpdm = <&mcpdm>;
		ti,mcbsp1 = <&mcbsp1>;
		ti,mcbsp2 = <&mcbsp2>;
		ti,mcbsp3 = <&mcbsp3>;

		ti,twl6040 = <&twl6040>;
		ti,aess = <&aess>;

		...
	};
};

Well, this could be simply wrong... I.e. the aess node should request all the phandles to mcpdm and mcbsps because it is connected to.

Or it is right to use the sound node to "connect" all subsystems.

Then the "aess" core could also become the child node of the target-module:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,aess";
		status = "disabled";
	};
};

Although it looks better this way, it may make it even one step more difficult to resurrect the old code...

And DT maintainers are not happy with otherwise undefined compatible definitions.

So maybe:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...

	aess: aess {
		/* revisit
		compatible = "ti,aess";
		status = "disabled";
		*/
	};
};

BR,
Nikolaus

#4 lore raw
Quoted 27 lines · H. Nikolaus Schaller
Quoted 3 lines

Am 14.01.2020 um 17:46 schrieb Tony Lindgren <[email protected]>:
Care to clarify what you have in mind? The module is generic, aess
device will be the child node.

The existing driver is hooked into the sound root-node and looks for a ti,aess = <&aess>; link:

/ {
	sound: sound {
		compatible = "ti,abe-twl6040";
		ti,model = "omap5-uevm";

		ti,jack-detection;
		ti,mclk-freq = <19200000>;

		ti,mcpdm = <&mcpdm>;
		ti,mcbsp1 = <&mcbsp1>;
		ti,mcbsp2 = <&mcbsp2>;
		ti,mcbsp3 = <&mcbsp3>;

		ti,twl6040 = <&twl6040>;
		ti,aess = <&aess>;

		...
	};
};
Quoted 2 lines

Well, this could be simply wrong... I.e. the aess node should request all the phandles to mcpdm and mcbsps because it is connected to.

The aess label above should be in the child aess node, not in the target-module.

Quoted 1 line

Or it is right to use the sound node to "connect" all subsystems.

Sounds like that's all taken care of nowadays with the generic graph binding:

Documentation/devicetree/bindings/graph.txt

See also snd-soc-audio-graph-card and various users for it:

Documentation/devicetree/bindings/sound/audio-graph-card.txt

Quoted 9 lines

Then the "aess" core could also become the child node of the target-module:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,aess";
		status = "disabled";
	};
};

Yeah this is how it should be :)

Quoted 2 lines

Although it looks better this way, it may make it even one step more difficult to resurrect the old code...

Well the old phandles and properties should work the same, just put them into the child aess node. No need to stuff anything else there at the target-module level AFAIK.

Quoted 6 lines

And DT maintainers are not happy with otherwise undefined compatible definitions.

So maybe:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

Quoted 9 lines
	...

	aess: aess {
		/* revisit
		compatible = "ti,aess";
		status = "disabled";
		*/
	};
};

But we have no binding and no driver for the aess at this point.. If and when the aess driver work the child node can be just added :)

Regards,

Tony

#5 lore raw
Quoted 39 lines

Am 14.01.2020 um 18:16 schrieb Tony Lindgren <[email protected]>:

Quoted 27 lines · H. Nikolaus Schaller
Quoted 3 lines

Am 14.01.2020 um 17:46 schrieb Tony Lindgren <[email protected]>:
Care to clarify what you have in mind? The module is generic, aess
device will be the child node.

The existing driver is hooked into the sound root-node and looks for a ti,aess = <&aess>; link:

/ {
	sound: sound {
		compatible = "ti,abe-twl6040";
		ti,model = "omap5-uevm";

		ti,jack-detection;
		ti,mclk-freq = <19200000>;

		ti,mcpdm = <&mcpdm>;
		ti,mcbsp1 = <&mcbsp1>;
		ti,mcbsp2 = <&mcbsp2>;
		ti,mcbsp3 = <&mcbsp3>;

		ti,twl6040 = <&twl6040>;
		ti,aess = <&aess>;

		...
	};
};
Quoted 2 lines

Well, this could be simply wrong... I.e. the aess node should request all the phandles to mcpdm and mcbsps because it is connected to.

The aess label above should be in the child aess node, not in the target-module.

Quoted 1 line

Or it is right to use the sound node to "connect" all subsystems.

Quoted 8 lines

Sounds like that's all taken care of nowadays with the generic graph binding:

Documentation/devicetree/bindings/graph.txt

See also snd-soc-audio-graph-card and various users for it:

Documentation/devicetree/bindings/sound/audio-graph-card.txt

Ok. Will become a major rework of the driver...
On the other hand the audio graph library could simplify a lot of things.

Quoted 11 lines
Quoted 10 lines

Then the "aess" core could also become the child node of the target-module:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,aess";
		status = "disabled";
	};
};
Quoted 8 lines

Yeah this is how it should be :)

Quoted 2 lines

Although it looks better this way, it may make it even one step more difficult to resurrect the old code...

Well the old phandles and properties should work the same, just put them into the child aess node. No need to stuff anything else there at the target-module level AFAIK.

What it might need is to make the aess driver a completely separate module loaded identified through the compatible record.

Quoted 17 lines
Quoted 7 lines

And DT maintainers are not happy with otherwise undefined compatible definitions.

So maybe:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

Quoted 9 lines
	...

	aess: aess {
		/* revisit
		compatible = "ti,aess";
		status = "disabled";
		*/
	};
};
Quoted 1 line

But we have no binding and no driver for the aess at this point..

That is why I propose a comment around it... But I am not sure if empty nodes are even allowed.

Quoted 1 line

If and when the aess driver work the child node can be just added :)

Yes, surely. So it is up to you to decide.

Best regards,
Nikolaus

#6 lore raw
Quoted 70 lines

Am 14.01.2020 um 19:29 schrieb H. Nikolaus Schaller <[email protected]>:

Quoted 38 lines

Am 14.01.2020 um 18:16 schrieb Tony Lindgren <[email protected]>:

Quoted 27 lines · H. Nikolaus Schaller
Quoted 3 lines

Am 14.01.2020 um 17:46 schrieb Tony Lindgren <[email protected]>:
Care to clarify what you have in mind? The module is generic, aess
device will be the child node.

The existing driver is hooked into the sound root-node and looks for a ti,aess = <&aess>; link:

/ {
	sound: sound {
		compatible = "ti,abe-twl6040";
		ti,model = "omap5-uevm";

		ti,jack-detection;
		ti,mclk-freq = <19200000>;

		ti,mcpdm = <&mcpdm>;
		ti,mcbsp1 = <&mcbsp1>;
		ti,mcbsp2 = <&mcbsp2>;
		ti,mcbsp3 = <&mcbsp3>;

		ti,twl6040 = <&twl6040>;
		ti,aess = <&aess>;

		...
	};
};
Quoted 2 lines

Well, this could be simply wrong... I.e. the aess node should request all the phandles to mcpdm and mcbsps because it is connected to.

The aess label above should be in the child aess node, not in the target-module.

Quoted 1 line

Or it is right to use the sound node to "connect" all subsystems.

Quoted 8 lines

Sounds like that's all taken care of nowadays with the generic graph binding:

Documentation/devicetree/bindings/graph.txt

See also snd-soc-audio-graph-card and various users for it:

Documentation/devicetree/bindings/sound/audio-graph-card.txt

Ok. Will become a major rework of the driver...
On the other hand the audio graph library could simplify a lot of things.

Quoted 16 lines
Quoted 10 lines

Then the "aess" core could also become the child node of the target-module:

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,aess";
		status = "disabled";
	};
};

Yeah this is how it should be :)

Quoted 2 lines

Although it looks better this way, it may make it even one step more difficult to resurrect the old code...

Quoted 6 lines
Quoted 3 lines

Well the old phandles and properties should work the same, just put them into the child aess node. No need to stuff anything else there at the target-module level AFAIK.

What it might need is to make the aess driver a completely separate module loaded identified through the compatible record.

I have checked our tree and it is already built into a separate module with

sound/soc/ti/aess/omap-aess-core.c: { .compatible = "ti,omap4-aess", },

So

Quoted 7 lines

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,omap4-aess";
		status = "disabled";
	};
};

would be what we will need.

BR,
Nikolaus

#7 lore raw
Quoted 14 lines · H. Nikolaus Schaller

I have checked our tree and it is already built into a separate module with

sound/soc/ti/aess/omap-aess-core.c: { .compatible = "ti,omap4-aess", },

So

Quoted 7 lines

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,omap4-aess";
		status = "disabled";
	};
};
Quoted 1 line

would be what we will need.

OK good to hear.

Regards,

Tony

#8 lore raw
Quoted 18 lines

Am 14.01.2020 um 22:00 schrieb Tony Lindgren <[email protected]>:

Quoted 14 lines · H. Nikolaus Schaller

I have checked our tree and it is already built into a separate module with

sound/soc/ti/aess/omap-aess-core.c: { .compatible = "ti,omap4-aess", },

So

Quoted 7 lines

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,omap4-aess";
		status = "disabled";
	};
};
Quoted 3 lines
Quoted 1 line

would be what we will need.

OK good to hear.

I have cleaned up my working tree and added your patches and the one above (without status = "disabled" and could
a) boot well
b) see that the (non-working) aess driver module is loaded through child node

So you can add my Tested-by: Nikolaus Schaller <[email protected]>

BR and thanks,
Nikolaus

#9 lore raw
Quoted 20 lines · H. Nikolaus Schaller
Quoted 20 lines

Am 14.01.2020 um 22:00 schrieb Tony Lindgren <[email protected]>:

Quoted 15 lines · H. Nikolaus Schaller

I have checked our tree and it is already built into a separate module with

sound/soc/ti/aess/omap-aess-core.c: { .compatible = "ti,omap4-aess", },

So

Quoted 7 lines

target-module@f1000 { /* 0x401f1000, ap 32 20.0 */

	...
	aess: aess {
		compatible = "ti,omap4-aess";
		status = "disabled";
	};
};

would be what we will need.

Quoted 8 lines
Quoted 1 line

OK good to hear.

I have cleaned up my working tree and added your patches and the one above (without status = "disabled" and could
a) boot well
b) see that the (non-working) aess driver module is loaded through child node

So you can add my Tested-by: Nikolaus Schaller <[email protected]>

OK good to hear, thanks for testing!

Tony

#10 lore raw
In reply to Tony Lindgren
I love your patch! Yet something to improve:

Hi Tony,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on omap/for-next balbi-usb/next v5.5-rc6 next-20200115] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/ARM-dts-Configure-omap5-AESS/20200115-114737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/omap5-l4-abe.dtsi:447.27-28 syntax error

FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/[email protected] Intel Corporation

#11 lore raw
Quoted 20 lines · kbuild test robot

Hi Tony,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on omap/for-next balbi-usb/next v5.5-rc6 next-20200115] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tony-Lindgren/ARM-dts-Configure-omap5-AESS/20200115-114737
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0

reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm

Quoted 7 lines

If you fix the issue, kindly add following tag

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

Error: arch/arm/boot/dts/omap5-l4-abe.dtsi:447.27-28 syntax error

FATAL ERROR: Unable to parse input tree

This patch has a dependency to a clock related patch as described in the original patch email so this error can be ignored.

Regards,

Tony