Skip to contentSkip to conversation

package/olsr: use make foreach loops

PATCH New Fabrice Fontaine 2 participants 2 messages Jan 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/olsr: use make foreach loops

Replace shell for loops by make foreach loops

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Add a trailing backslash

 package/olsr/olsr.mk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
package/olsr/olsr.mk +7 -7
index e643a0cfb3..53bf874af0 100644
@@ -18,19 +18,19 @@ OLSR_DEPENDENCIES = host-flex host-bison
 
 define OLSR_BUILD_CMDS
 	$(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D) olsrd
-	for p in $(OLSR_PLUGINS) ; do \
-		$(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$$p ; \
-	done
+	$(foreach p,$(OLSR_PLUGINS), \
+		$(TARGET_CONFIGURE_OPTS) $(MAKE) ARCH=$(KERNEL_ARCH) -C $(@D)/lib/$(p)
+	)
 endef
 
 define OLSR_INSTALL_TARGET_CMDS
 	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
 		prefix="/usr" install_bin
-	for p in $(OLSR_PLUGINS) ; do \
-		$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$$p \
+	$(foreach p,$(OLSR_PLUGINS), \
+		$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/lib/$(p) \
 			LDCONFIG=/bin/true DESTDIR=$(TARGET_DIR) \
-			prefix="/usr" install ; \
-	done
+			prefix="/usr" install
+	)
 	$(INSTALL) -D -m 0644 $(@D)/files/olsrd.conf.default.lq \
 		$(TARGET_DIR)/etc/olsrd/olsrd.conf
 endef
Signature · 1 line
2.24.1
#1 lore raw

PATCH v2 1/1 package/olsr: use make foreach loops

Quoted 6 lines · On Tue, 14 Jan 2020 19:14:51 +0100 Fabrice Fontaine…

Replace shell for loops by make foreach loops

---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Add a trailing backslash

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com