mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge
Subsystems (2)
PATCH 1/1 mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge
No functional change, just leverage the helper function to improve readability as others.
Signed-off-by Wei Yang <[email protected]>
--- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/gup.c +2 -2
@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma, pmdval =READ_ONCE (*pmd);if (pmd_none (pmdval))return no_page_table (vma, flags); -if (pmd_huge (pmdval) && vma->vm_flags &VM_HUGETLB ) { +if (pmd_huge (pmdval) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pmd (mm, address, pmd, flags);if (page)return page;
@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, pud =pud_offset (p4dp, address);if (pud_none (*pud))return no_page_table (vma, flags); -if (pud_huge (*pud) && vma->vm_flags &VM_HUGETLB ) { +if (pud_huge (*pud) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pud (mm, address, pud, flags);if (page)return page;
Signature · 1 line
2.17.1
Quoted 4 lines · Wei Yang
No functional change, just leverage the helper function to improve readability as others.
Signed-off-by Wei Yang <[email protected]>
Acked-by Vlastimil Babka <[email protected]>
Quoted 27 lines
--- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/gup.c +2
-2@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma, pmdval =READ_ONCE (*pmd);if (pmd_none (pmdval))return no_page_table (vma, flags); -if (pmd_huge (pmdval) && vma->vm_flags &VM_HUGETLB ) { +if (pmd_huge (pmdval) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pmd (mm, address, pmd, flags);if (page)return page;@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, pud =pud_offset (p4dp, address);if (pud_none (*pud))return no_page_table (vma, flags); -if (pud_huge (*pud) && vma->vm_flags &VM_HUGETLB ) { +if (pud_huge (*pud) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pud (mm, address, pud, flags);if (page)return page;
Quoted 4 lines · Wei Yang
No functional change, just leverage the helper function to improve readability as others.
Signed-off-by Wei Yang <[email protected]>
Acked-by David Rientjes <[email protected]>
Quoted 4 lines · Wei Yang
No functional change, just leverage the helper function to improve readability as others.
Signed-off-by Wei Yang <[email protected]>
I had thought about doing this same thing. :-)
Reviewed-by Ralph Campbell <[email protected]>
Quoted 27 lines
--- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/gup.c +2
-2@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma, pmdval =READ_ONCE (*pmd);if (pmd_none (pmdval))return no_page_table (vma, flags); -if (pmd_huge (pmdval) && vma->vm_flags &VM_HUGETLB ) { +if (pmd_huge (pmdval) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pmd (mm, address, pmd, flags);if (page)return page;@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, pud =pud_offset (p4dp, address);if (pud_none (*pud))return no_page_table (vma, flags); -if (pud_huge (*pud) && vma->vm_flags &VM_HUGETLB ) { +if (pud_huge (*pud) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pud (mm, address, pud, flags);if (page)return page;
Quoted 8 lines · Ralph Campbell
Quoted 4 lines · Wei Yang
No functional change, just leverage the helper function to improve readability as others.
Signed-off-by Wei Yang <[email protected]>I had thought about doing this same thing. :-)
Ah, in Chinese, there is a saying: Heroes see the same :-)
Quoted 29 lines
Reviewed-by Ralph Campbell <[email protected]>Quoted 27 lines
--- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/gup.c +2
-2@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma, pmdval =READ_ONCE (*pmd);if (pmd_none (pmdval))return no_page_table (vma, flags); -if (pmd_huge (pmdval) && vma->vm_flags &VM_HUGETLB ) { +if (pmd_huge (pmdval) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pmd (mm, address, pmd, flags);if (page)return page;@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma, pud =pud_offset (p4dp, address);if (pud_none (*pud))return no_page_table (vma, flags); -if (pud_huge (*pud) && vma->vm_flags &VM_HUGETLB ) { +if (pud_huge (*pud) &&is_vm_hugetlb_page (vma)) { page =follow_huge_pud (mm, address, pud, flags);if (page)return page;
Signature · 2 lines
Wei Yang Help you, Help me