Skip to contentSkip to conversation

mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

PATCH Applied Wei Yang 4 participants 5 messages Jan 13, 2020 – Jan 15, 2020

Subsystems (2)
lore
Share & tools
lore

Wei Yang

author
#0 lore raw

PATCH 1/1 mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

No functional change, just leverage the helper function to improve readability as others.

---
 mm/gup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/gup.c +2 -2
index 7646bf993b25..7705929cc920 100644
@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
 	pmdval = READ_ONCE(*pmd);
 	if (pmd_none(pmdval))
 		return no_page_table(vma, flags);
-	if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
+	if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
 		page = follow_huge_pmd(mm, address, pmd, flags);
 		if (page)
 			return page;
@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
 	pud = pud_offset(p4dp, address);
 	if (pud_none(*pud))
 		return no_page_table(vma, flags);
-	if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
+	if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
 		page = follow_huge_pud(mm, address, pud, flags);
 		if (page)
 			return page;
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Wei Yang

No functional change, just leverage the helper function to improve readability as others.

Quoted 27 lines
---
 mm/gup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/gup.c +2 -2
index 7646bf993b25..7705929cc920 100644
@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
 	pmdval = READ_ONCE(*pmd);
 	if (pmd_none(pmdval))
 		return no_page_table(vma, flags);
-	if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
+	if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
 		page = follow_huge_pmd(mm, address, pmd, flags);
 		if (page)
 			return page;
@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
 	pud = pud_offset(p4dp, address);
 	if (pud_none(*pud))
 		return no_page_table(vma, flags);
-	if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
+	if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
 		page = follow_huge_pud(mm, address, pud, flags);
 		if (page)
 			return page;
Reviewed-by on v1 1/1
#3 lore raw
In reply to Wei Yang
Quoted 4 lines · Wei Yang

No functional change, just leverage the helper function to improve readability as others.

I had thought about doing this same thing. :-)

Quoted 27 lines
---
  mm/gup.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
mm/gup.c +2 -2
index 7646bf993b25..7705929cc920 100644
@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
  	pmdval = READ_ONCE(*pmd);
  	if (pmd_none(pmdval))
  		return no_page_table(vma, flags);
-	if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
+	if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
  		page = follow_huge_pmd(mm, address, pmd, flags);
  		if (page)
  			return page;
@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
  	pud = pud_offset(p4dp, address);
  	if (pud_none(*pud))
  		return no_page_table(vma, flags);
-	if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
+	if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
  		page = follow_huge_pud(mm, address, pud, flags);
  		if (page)
  			return page;
author
#4 lore raw
Quoted 8 lines · Ralph Campbell
Quoted 4 lines · Wei Yang

No functional change, just leverage the helper function to improve readability as others.

I had thought about doing this same thing. :-)

Ah, in Chinese, there is a saying: Heroes see the same :-)

Quoted 29 lines
Quoted 27 lines
---
  mm/gup.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
mm/gup.c +2 -2
index 7646bf993b25..7705929cc920 100644
@@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
  	pmdval = READ_ONCE(*pmd);
  	if (pmd_none(pmdval))
  		return no_page_table(vma, flags);
-	if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
+	if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
  		page = follow_huge_pmd(mm, address, pmd, flags);
  		if (page)
  			return page;
@@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
  	pud = pud_offset(p4dp, address);
  	if (pud_none(*pud))
  		return no_page_table(vma, flags);
-	if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
+	if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
  		page = follow_huge_pud(mm, address, pud, flags);
  		if (page)
  			return page;
Signature · 2 lines
Wei Yang
Help you, Help me