hw/input: Do not enable CONFIG_PCKBD by default
PATCH 1/1 hw/input: Do not enable CONFIG_PCKBD by default
The i8042 device is part of the chipset of a machine, so it should be selected by the machines or chipsets (e.g. SuperIO chipsets), and not be enabled by default.
--- hw/input/Kconfig | 1 - hw/isa/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
hw/input/Kconfig +0 -1
@@ -7,7 +7,6 @@ config LM832X config PCKBD bool - default y select PS2 depends on ISA_BUS
hw/isa/Kconfig +1 -0
@@ -16,6 +16,7 @@ config I82378 config ISA_SUPERIO bool select ISA_BUS + select PCKBD config PC87312 bool
Signature · 1 line
2.18.1
Le 15/01/2020 à 12:37, Thomas Huth a écrit :
Quoted 28 lines
The i8042 device is part of the chipset of a machine, so it should be selected by the machines or chipsets (e.g. SuperIO chipsets), and not be enabled by default.
Signed-off-by Thomas Huth <[email protected]>--- hw/input/Kconfig | 1 - hw/isa/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)hw/input/Kconfig +0
-1@@ -7,7 +7,6 @@ config LM832X config PCKBD bool - default y select PS2 depends on ISA_BUShw/isa/Kconfig +0
-0
hw/isa/Kconfig config I82378 · line 22
Quoted 7 lines
hw/isa/Kconfig +1
-0@@ -16,6 +16,7 @@ config I82378 config ISA_SUPERIO bool select ISA_BUS + select PCKBD config PC87312 bool
It is also used by R4K but the Kconfig already includes it, so:
Philippe Mathieu-Daudé
Reviewed-byQuoted 4 lines · Laurent Vivier
Le 15/01/2020 à 12:37, Thomas Huth a écrit :
Quoted 3 lines
The i8042 device is part of the chipset of a machine, so it should be selected by the machines or chipsets (e.g. SuperIO chipsets), and not be enabled by default.
The sentence "The i8042 device is part of the chipset of a machine" sounds odd to me.
Maybe simply use "The i8042 PS/2 Controller should not be enabled by default. It has to be selected by machines or chipsets (e.g. SuperIO chipsets)."
Quoted 29 lines
Quoted 29 lines
Signed-off-by Thomas Huth <[email protected]>--- hw/input/Kconfig | 1 - hw/isa/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)hw/input/Kconfig +0
-1@@ -7,7 +7,6 @@ config LM832X config PCKBD bool - default y select PS2 depends on ISA_BUShw/isa/Kconfig +1
-0@@ -16,6 +16,7 @@ config I82378 config ISA_SUPERIO bool select ISA_BUS + select PCKBD
Quoted 5 lines
hw/isa/Kconfig config I82378 · line 22
Quoted 3 lines
hw/isa/Kconfig +0
-0config PC87312 boolIt is also used by R4K but the
Kconfigalready includes it, so:
I believe R4K should 'select ISA_SUPERIO' but we don't have specs and this machine is deprecated, so I didn't bother improving it.
Quoted 3 lines
Reviewed-by Laurent Vivier <[email protected]>
Quoted 28 lines · Thomas Huth
The i8042 device is part of the chipset of a machine, so it should be selected by the machines or chipsets (e.g. SuperIO chipsets), and not be enabled by default.
Signed-off-by Thomas Huth <[email protected]>--- hw/input/Kconfig | 1 - hw/isa/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)hw/input/Kconfig +0
-1@@ -7,7 +7,6 @@ config LM832X config PCKBD bool - default y select PS2 depends on ISA_BUShw/isa/Kconfig +0
-0
hw/isa/Kconfig config I82378 · line 22
Quoted 7 lines
hw/isa/Kconfig +1
-0@@ -16,6 +16,7 @@ config I82378 config ISA_SUPERIO bool select ISA_BUS + select PCKBD config PC87312 bool
Since you CCed qemu-trivial,