clk: imx8qxp: extend to support getting I2C IPG clock
Subsystems (4)
PATCH 1/2 clk: imx8qxp: extend to support getting I2C IPG clock
Since commit d02be21d3004 ("i2c: imx_lpi2c: add ipg clk") getting I2C clocks doesn't work. Add I2C IPG clock IDs to related switch statements to fix it.
--- drivers/clk/imx/clk-imx8qxp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/clk/imx/clk-imx8qxp.c +12 -0
@@ -56,18 +56,22 @@ ulong imx8_clk_get_rate(struct clk *clk) pm_clk =SC_PM_CLK_CPU ;break ;case IMX8QXP_I2C0_CLK : +case IMX8QXP_I2C0_IPG_CLK : resource =SC_R_I2C_0 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C1_CLK : +case IMX8QXP_I2C1_IPG_CLK : resource =SC_R_I2C_1 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C2_CLK : +case IMX8QXP_I2C2_IPG_CLK : resource =SC_R_I2C_2 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C3_CLK : +case IMX8QXP_I2C3_IPG_CLK : resource =SC_R_I2C_3 ; pm_clk =SC_PM_CLK_PER ;break ;
@@ -145,18 +149,22 @@ ulong imx8_clk_set_rate(struct clk *clk, unsigned long rate)switch (clk->id) {case IMX8QXP_I2C0_CLK : +case IMX8QXP_I2C0_IPG_CLK : resource =SC_R_I2C_0 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C1_CLK : +case IMX8QXP_I2C1_IPG_CLK : resource =SC_R_I2C_1 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C2_CLK : +case IMX8QXP_I2C2_IPG_CLK : resource =SC_R_I2C_2 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C3_CLK : +case IMX8QXP_I2C3_IPG_CLK : resource =SC_R_I2C_3 ; pm_clk =SC_PM_CLK_PER ;break ;
@@ -234,18 +242,22 @@ int __imx8_clk_enable(struct clk *clk, bool enable)switch (clk->id) {case IMX8QXP_I2C0_CLK : +case IMX8QXP_I2C0_IPG_CLK : resource =SC_R_I2C_0 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C1_CLK : +case IMX8QXP_I2C1_IPG_CLK : resource =SC_R_I2C_1 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C2_CLK : +case IMX8QXP_I2C2_IPG_CLK : resource =SC_R_I2C_2 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C3_CLK : +case IMX8QXP_I2C3_IPG_CLK : resource =SC_R_I2C_3 ; pm_clk =SC_PM_CLK_PER ;break ;
Signature · 1 line
2.7.4
PATCH 2/2 imx: dts: imx8dx: add I2C IPG clock for bus 0 and 2
IPG clock description is missing for I2C0 and I2C2 busses, add it. Otherwise we see -ENODATA error when trying to get I2C clock for these busses.
--- arch/arm/dts/fsl-imx8dx.dtsi | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
arch/arm/dts/fsl-imx8dx.dtsi +6 -4
@@ -268,8 +268,9 @@ reg = <0x0 0x5a800000 0x0 0x4000>; interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; - clocks = <&clk IMX8QXP_I2C0_CLK>; - clock-names = "per"; + clocks = <&clk IMX8QXP_I2C0_CLK>, + <&clk IMX8QXP_I2C0_IPG_CLK>; + clock-names = "per", "ipg"; assigned-clocks = <&clk IMX8QXP_I2C0_CLK>; assigned-clock-rates = <24000000>; power-domains = <&pd_dma_lpi2c0>;
@@ -299,8 +300,9 @@ reg = <0x0 0x5a820000 0x0 0x4000>; interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; - clocks = <&clk IMX8QXP_I2C2_CLK>; - clock-names = "per"; + clocks = <&clk IMX8QXP_I2C2_CLK>, + <&clk IMX8QXP_I2C2_IPG_CLK>; + clock-names = "per", "ipg"; assigned-clocks = <&clk IMX8QXP_I2C2_CLK>; assigned-clock-rates = <24000000>; power-domains = <&pd_dma_lpi2c2>;
Signature · 1 line
2.7.4
PATCH 2/2 imx: dts: imx8dx: add I2C IPG clock for bus 0 and 2
Quoted 5 lines
IPG clock description is missing for I2C0 and I2C2 busses, add it. Otherwise we see
-ENODATAerror when trying to get I2C clock for these busses.Signed-off-by Anatolij Gustschin <[email protected]>Cc Stefano Babic <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH 1/2 clk: imx8qxp: extend to support getting I2C IPG clock
In reply to Anatolij GustschinHi Anatolij,
Quoted 4 lines · Anatolij Gustschin
Since commit
d02be21d3004("i2c:imx_lpi2c: add ipg clk") getting I2C clocks doesn't work. Add I2C IPG clock IDs to related switch statements to fix it.
I am wondering if we should just revert this commit instead?
PATCH 1/2 clk: imx8qxp: extend to support getting I2C IPG clock
Hi Fabio,
Quoted 9 lines · On Thu, 9 Jan 2020 10:58:30 -0300 Fabio Estevam festevam at gmail.com wrote:
Hi Anatolij,
Quoted 4 lines · Anatolij Gustschin
Since commit
d02be21d3004("i2c:imx_lpi2c: add ipg clk") getting I2C clocks doesn't work. Add I2C IPG clock IDs to related switch statements to fix it.I am wondering if we should just revert this commit instead?
I'm not sure, this might be required for other i.MX8 SoCs. Peng, what do you think?
--
Anatolij
Peng Fan
reviewerPATCH 1/2 clk: imx8qxp: extend to support getting I2C IPG clock
In reply to Anatolij GustschinQuoted 7 lines
Subject: [PATCH 1/2] clk: imx8qxp: extend to support getting I2C IPG clock
Since commit
d02be21d3004("i2c:imx_lpi2c: add ipg clk") getting I2C clocks doesn't work. Add I2C IPG clock IDs to related switch statements to fix it.Signed-off-by Anatolij Gustschin <[email protected]>Cc Lukasz Majewski <[email protected]>
Quoted 80 lines
--- drivers/clk/imx/clk-imx8qxp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/clk/imx/clk-imx8qxp.c +8
-0@@ -56,18 +56,22 @@ ulong imx8_clk_get_rate(struct clk *clk) pm_clk =SC_PM_CLK_CPU ;break ;case IMX8QXP_I2C0_CLK : +case IMX8QXP_I2C0_IPG_CLK : resource =SC_R_I2C_0 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C1_CLK : +case IMX8QXP_I2C1_IPG_CLK : resource =SC_R_I2C_1 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C2_CLK : +case IMX8QXP_I2C2_IPG_CLK : resource =SC_R_I2C_2 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C3_CLK : +case IMX8QXP_I2C3_IPG_CLK : resource =SC_R_I2C_3 ; pm_clk =SC_PM_CLK_PER ;break ;@@ -145,18 +149,22 @@ ulong imx8_clk_set_rate(struct clk *clk, unsigned long rate)switch (clk->id) {case IMX8QXP_I2C0_CLK : +case IMX8QXP_I2C0_IPG_CLK : resource =SC_R_I2C_0 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C1_CLK : +case IMX8QXP_I2C1_IPG_CLK : resource =SC_R_I2C_1 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C2_CLK : +case IMX8QXP_I2C2_IPG_CLK : resource =SC_R_I2C_2 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C3_CLK : +case IMX8QXP_I2C3_IPG_CLK : resource =SC_R_I2C_3 ; pm_clk =SC_PM_CLK_PER ;drivers/clk/imx/clk-imx8qxp.c +4
-1break ;@@ -234,18 +242,22 @@ int __imx8_clk_enable(struct clk *clk, bool enable)switch (clk->id) {case IMX8QXP_I2C0_CLK : +case IMX8QXP_I2C0_IPG_CLK : resource =SC_R_I2C_0 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C1_CLK : +case IMX8QXP_I2C1_IPG_CLK : resource =SC_R_I2C_1 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C2_CLK : +case IMX8QXP_I2C2_IPG_CLK : resource =SC_R_I2C_2 ; pm_clk =SC_PM_CLK_PER ;break ;case IMX8QXP_I2C3_CLK : +case IMX8QXP_I2C3_IPG_CLK : resource =SC_R_I2C_3 ; pm_clk =SC_PM_CLK_PER ;break ; --2.7.4
PATCH 1/2 clk: imx8qxp: extend to support getting I2C IPG clock
In reply to Anatolij GustschinQuoted 6 lines
Since commit
d02be21d3004("i2c:imx_lpi2c: add ipg clk") getting I2C clocks doesn't work. Add I2C IPG clock IDs to related switch statements to fix it.Signed-off-by Anatolij Gustschin <[email protected]>Cc Lukasz Majewski <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================