travis.yml: Prevent 'script' from premature exit
PATCH v2 1/1 travis.yml: Prevent 'script' from premature exit
The 'script' section finishes its execution prematurely whenever a shell's exit is called. If the intention is to force Travis to flag a build/test failure then the correct approach is erroring any command statement. In this change, it combines the grep's in a single AND statement that in case of false Travis will interpret as a build error.
---
Changes v1 to v2:
- Simplify the grep's in a single statement [thuth]
- Also grep for SKIP (besides PASS) [myself]
.travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
.travis.yml +1 -2
@@ -119,5 +119,4 @@ before_script: script: - make -j3 - ACCEL="${ACCEL:-tcg}" ./run_tests.sh -v $TESTS | tee results.txt - - if grep -q FAIL results.txt ; then exit 1 ; fi - - if ! grep -q PASS results.txt ; then exit 1 ; fi + - grep -q 'PASS\|SKIP' results.txt && ! grep -q FAIL results.txt
Signature · 1 line
2.23.0
Quoted 20 lines · Wainer dos Santos Moschetta
The 'script' section finishes its execution prematurely whenever a shell's exit is called. If the intention is to force Travis to flag a build/test failure then the correct approach is erroring any command statement. In this change, it combines the grep's in a single AND statement that in case of false Travis will interpret as a build error.
Signed-off-by Wainer dos Santos Moschetta <[email protected]>---
Changes v1 to v2:
- Simplify the grep's in a single statement [thuth]
- Also grep for SKIP (besides PASS) [myself].travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-).travis.yml +0
-0
.travis.yml before_script: · line 122
Quoted 6 lines
.travis.yml +1
-2@@ -119,5 +119,4 @@ before_script: script: - make -j3 - ACCEL="${ACCEL:-tcg}" ./run_tests.sh -v $TESTS | tee results.txt - - if grep -q FAIL results.txt ; then exit 1 ; fi - - if ! grep -q PASS results.txt ; then exit 1 ; fi + - grep -q 'PASS\|SKIP' results.txt && ! grep -q FAIL results.txt
I think we want to see at least one "PASS" in the output, otherwise it's an indication that something went wrong in the CI - I've seen bugs in the past that caused all tests to SKIP, and we should fail the CI in that case, too. So I'd suggest to remove the "SKIP" from the grep statement again.
Thomas