xfs/191 failures?
Hi Jan and Baihua,
the xfs/191 test case has been failing for me basically since it was added. Does it succeed for anyone with an upstream kernel and xfsprogs? Here is my diff between the golden and the actual output:
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +11 -0
@@ -1,2 +1,13 @@ QA output created by 191-input-validation silence is golden +pass -n size=2b /dev/vdc +pass -d agsize=8192b /dev/vdc +pass -d agsize=65536s /dev/vdc +pass -d su=0,sw=64 /dev/vdc +pass -d su=4096s,sw=64 /dev/vdc +pass -d su=4096b,sw=64 /dev/vdc +pass -l su=10b /dev/vdc +fail -n log=15 /dev/vdc +fail -r rtdev=/mnt/test/191-input-validation.img /dev/vdc +fail -r size=65536,rtdev=/mnt/test/191-input-validation.img /dev/vdc +fail -i log=10 /dev/vdc
Quoted 5 lines · Christoph Hellwig
Hi Jan and Baihua,
the xfs/191 test case has been failing for me basically since it was added. Does it succeed for anyone with an upstream kernel and xfsprogs?
It never succeeds here.
--D
Quoted 19 lines
Here is my diff between the golden and the actual
output:root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +11
-0@@ -1,2 +1,13 @@ QA output created by 191-input-validation silence is golden +pass -n size=2b /dev/vdc +pass -d agsize=8192b /dev/vdc +pass -d agsize=65536s /dev/vdc +pass -d su=0,sw=64 /dev/vdc +pass -d su=4096s,sw=64 /dev/vdc +pass -d su=4096b,sw=64 /dev/vdc +pass -l su=10b /dev/vdc +fail -n log=15 /dev/vdc +fail -r rtdev=/mnt/test/191-input-validation.img /dev/vdc +fail -r size=65536,rtdev=/mnt/test/191-input-validation.img /dev/vdc +fail -i log=10 /dev/vdc
Quoted 8 lines · Darrick J. Wong
Quoted 5 lines · Christoph Hellwig
Hi Jan and Baihua,
the xfs/191 test case has been failing for me basically since it was added. Does it succeed for anyone with an upstream kernel and xfsprogs?
It never succeeds here.
<Jan has left Red Hat>
yeah I think this has always been a mess, not sure why it took so long to highlight it. Seems like a combination of WTF? and general rot.
Quoted 10 lines
--D
root/xfstests/results//xfs/191-input-validation.out.bad line 2
Quoted 8 lines
Here is my diff between the golden and the actual
output:root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +0
-0@@ -1,2 +1,13 @@ QA output created by 191-input-validation silence is golden
supposedly these should fail, but they pass:
Quoted 3 lines
root/xfstests/results//xfs/191-input-validation.out.bad line 5
Quoted 3 lines
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +3
-0+pass -n size=2b /dev/vdc +pass -d agsize=8192b /dev/vdc +pass -d agsize=65536s /dev/vdc
I don't know why it wouldn't be valid to use block & sector units for these values. But this whole mkfs reworking discussion was so long ago :(
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad line 6
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +1
-0+pass -d su=0,sw=64 /dev/vdc
not sure why this passes
Quoted 2 lines
root/xfstests/results//xfs/191-input-validation.out.bad line 8
Quoted 2 lines
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +2
-0+pass -d su=4096s,sw=64 /dev/vdc +pass -d su=4096b,sw=64 /dev/vdc
s & b suffixes seem to be ignored here, which seems like a bug.
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad line 9
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +1
-0+pass -l su=10b /dev/vdc
again this seems to DTRT.
according to the test, these should pass, but they fail:
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad line 10
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +1
-0+fail -n log=15 /dev/vdc
uh, "-n log=" isn't even a mkfs option so of course it fails
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad line 11
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +1
-0+fail -r rtdev=/mnt/test/191-input-validation.img /dev/vdc
this fails because reflink is default now
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad line 12
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +1
-0+fail -r size=65536,rtdev=/mnt/test/191-input-validation.img /dev/vdc
ditto
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad line 13
Quoted 1 line
root/xfstests/results//xfs/191-input-validation.out.bad renamed from root/xfstests/tests/xfs/191-input-validation.out +1
-0+fail -i log=10 /dev/vdc
-i log is not a valid option either so of course it fails.
My first thought was to nuke it all, but I think the test could be salvaged by anyone motivated to do so.
-Eric