Skip to contentSkip to conversation

arm: exynos: Read default MMC device from XOM[7:5] pins

PATCH Superseded Marek Szyprowski 3 participants 3 messages Jan 15, 2020 1 message not in the archive

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200115140607eucas1p2abbf759b7ebbe07b14455bb135c02fa0@eucas1p2.samsung.com

#1 lore raw

PATCH 1/1 arm: exynos: Read default MMC device from XOM[7:5] pins

XOM pins provide information for iROM bootloader about the boot device. Those pins are mapped to lower bits of OP_MODE register (0x10000008), which is common for all Exynos SoC variants. Set the default MMC device id to reflect the boot device selected by XOM[7:5] pins (2 for the SD or 0 for the eMMC).

---
 arch/arm/mach-exynos/include/mach/cpu.h |  1 +
 board/samsung/common/board.c            | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
arch/arm/mach-exynos/include/mach/cpu.h +1 -0
index 766edeeb29..fb5fdaf3ba 100644
@@ -17,6 +17,7 @@
 
 #define EXYNOS4_GPIO_PART3_BASE		0x03860000
 #define EXYNOS4_PRO_ID			0x10000000
+#define EXYNOS4_OP_MODE			0x10000008
 #define EXYNOS4_SYSREG_BASE		0x10010000
 #define EXYNOS4_POWER_BASE		0x10020000
 #define EXYNOS4_SWRESET			0x10020400
board/samsung/common/board.c +14 -0
index ee2fc7971e..ac91c0a6fb 100644
@@ -359,3 +359,17 @@ int board_usb_cleanup(int index, enum usb_init_type init)
 #endif
 	return 0;
 }
+
+/**
+ * mmc_get_env_dev() - read boot MMC device id from XOM[7:5] pins.
+ */
+int mmc_get_env_dev(void)
+{
+	u32 mode = readl(EXYNOS4_OP_MODE) & 0x1C;
+
+	if (mode == 0x04)
+		return 2; /* MMC2: SD */
+
+	/* MMC0: eMMC or unknown */
+	return 0;
+}
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 arm: exynos: Read default MMC device from XOM[7:5] pins

Quoted 36 lines · On Wed, 15 Jan 2020 15:05:58 +0100 Marek Szyprowski <[email protected]>…

XOM pins provide information for iROM bootloader about the boot device. Those pins are mapped to lower bits of OP_MODE register (0x10000008), which is common for all Exynos SoC variants. Set the default MMC device id to reflect the boot device selected by XOM[7:5] pins (2 for the SD or 0 for the eMMC).

---
 arch/arm/mach-exynos/include/mach/cpu.h |  1 +
 board/samsung/common/board.c            | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
(quoted diff) +0 -0

b/arch/arm/mach-exynos/include/mach/cpu.h index 766edeeb29..fb5fdaf3ba 100644 --- a/arch/arm/mach-exynos/include/mach/cpu.h +++ b/arch/arm/mach-exynos/include/mach/cpu.h @@ -17,6 +17,7 @@

#define EXYNOS4_GPIO_PART3_BASE 0x03860000
#define EXYNOS4_PRO_ID 0x10000000

arch/arm/mach-exynos/include/mach/cpu.h +1 -0
+#define EXYNOS4_OP_MODE			0x10000008
 #define EXYNOS4_SYSREG_BASE		0x10010000
 #define EXYNOS4_POWER_BASE		0x10020000
 #define EXYNOS4_SWRESET			0x10020400
(quoted diff) +0 -0

b/board/samsung/common/board.c index ee2fc7971e..ac91c0a6fb 100644

board/samsung/common/board.c +0 -0
@@ -359,3 +359,17 @@ int board_usb_cleanup(int index, enum

usb_init_type init) #endif

board/samsung/common/board.c +4 -0
 	return 0;
 }
+
+/**
+ * mmc_get_env_dev() - read boot MMC device id from XOM[7:5] pins.
+ */

board/samsung/common/board.c int board_usb_cleanup(int index, enum usb_init_type init) · line 375

Quoted 10 lines
board/samsung/common/board.c +10 -0
+int mmc_get_env_dev(void)
+{
+	u32 mode = readl(EXYNOS4_OP_MODE) & 0x1C;
+
+	if (mode == 0x04)
+		return 2; /* MMC2: SD */
+
+	/* MMC0: eMMC or unknown */
+	return 0;
+}

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200115/2f754d3a/attachment.sig>

#3 lore raw

PATCH 1/1 arm: exynos: Read default MMC device from XOM[7:5] pins

In reply to Marek Szyprowski

Hi Marek,

Quoted 48 lines · Marek Szyprowski

XOM pins provide information for iROM bootloader about the boot device. Those pins are mapped to lower bits of OP_MODE register (0x10000008), which is common for all Exynos SoC variants. Set the default MMC device id to reflect the boot device selected by XOM[7:5] pins (2 for the SD or 0 for the eMMC).

---
 arch/arm/mach-exynos/include/mach/cpu.h |  1 +
 board/samsung/common/board.c            | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
arch/arm/mach-exynos/include/mach/cpu.h +1 -0
index 766edeeb29..fb5fdaf3ba 100644
@@ -17,6 +17,7 @@
 
 #define EXYNOS4_GPIO_PART3_BASE                0x03860000
 #define EXYNOS4_PRO_ID                 0x10000000
+#define EXYNOS4_OP_MODE                        0x10000008
 #define EXYNOS4_SYSREG_BASE            0x10010000
 #define EXYNOS4_POWER_BASE             0x10020000
 #define EXYNOS4_SWRESET                        0x10020400
board/samsung/common/board.c +14 -1
index ee2fc7971e..ac91c0a6fb 100644
@@ -359,3 +359,17 @@ int board_usb_cleanup(int index, enum usb_init_type init)
 #endif
        return 0;
 }
+
+/**
+ * mmc_get_env_dev() - read boot MMC device id from XOM[7:5] pins.
+ */
+int mmc_get_env_dev(void)
+{
+       u32 mode = readl(EXYNOS4_OP_MODE) & 0x1C;
+
+       if (mode == 0x04)
+               return 2; /* MMC2: SD */
+
+       /* MMC0: eMMC or unknown */
+       return 0;
+}
--
Quoted 2 lines

2.17.1

If you could add some debug prints which boot mode got selected, It will be much help. Please add my

-Anand