Skip to contentSkip to conversation

arm: exynos: Use proper PMIC device name

PATCH Superseded Marek Szyprowski 2 participants 2 messages Jan 15, 2020 1 message not in the archive Arm Samsung Exynos

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200115153914eucas1p28ecc7976969fcbc50ac8eb15abe05f22@eucas1p2.samsung.com

#1 lore raw

PATCH v2 1/1 arm: exynos: Use proper PMIC device name

Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect enable power regulators on Odroid boards to use proper PMIC device device name then.

---
 board/samsung/common/exynos5-dt-types.c | 2 +-
 board/samsung/common/exynos5-dt.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
board/samsung/common/exynos5-dt-types.c +1 -1
index d51cc4eedc..31e23e8b07 100644
@@ -129,7 +129,7 @@ static const char *odroid_get_type_str(void)
 	if (gd->board_type != EXYNOS5_BOARD_ODROID_XU3_REV02)
 		goto exit;
 
-	ret = pmic_get("s2mps11", &dev);
+	ret = pmic_get("s2mps11_pmic at 66", &dev);
 	if (ret)
 		goto exit;
 
board/samsung/common/exynos5-dt.c +1 -1
index 87eb381345..c5e77480f5 100644
@@ -64,7 +64,7 @@ int exynos_power_init(void)
 	int ret;
 
 #ifdef CONFIG_PMIC_S2MPS11
-	ret = pmic_get("s2mps11_pmic", &dev);
+	ret = pmic_get("s2mps11_pmic at 66", &dev);
 #else
 	ret = pmic_get("max77686", &dev);
 	if (!ret) {
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 1/1 arm: exynos: Use proper PMIC device name

Quoted 30 lines · On Wed, 15 Jan 2020 16:39:09 +0100 Marek Szyprowski <[email protected]>…

Since commit 4213609cc7 ("drivers: core: use strcmp when find device by name") one has to provide full name to get requested object. Fix the code used to detect enable power regulators on Odroid boards to use proper PMIC device device name then.

---
 board/samsung/common/exynos5-dt-types.c | 2 +-
 board/samsung/common/exynos5-dt.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/board/samsung/common/exynos5-dt-types.c index d51cc4eedc..31e23e8b07 100644 --- a/board/samsung/common/exynos5-dt-types.c +++ b/board/samsung/common/exynos5-dt-types.c @@ -129,7 +129,7 @@ static const char *odroid_get_type_str(void) if (gd->board_type != EXYNOS5_BOARD_ODROID_XU3_REV02) goto exit;

board/samsung/common/exynos5-dt-types.c +1 -1
-	ret = pmic_get("s2mps11", &dev);
+	ret = pmic_get("s2mps11_pmic at 66", &dev);
 	if (ret)
 		goto exit;
(quoted diff) +0 -0

b/board/samsung/common/exynos5-dt.c index 87eb381345..c5e77480f5 100644 --- a/board/samsung/common/exynos5-dt.c
+++ b/board/samsung/common/exynos5-dt.c

board/samsung/common/exynos5-dt.c int exynos_power_init(void) · line 70

Quoted 8 lines
board/samsung/common/exynos5-dt.c +1 -1
@@ -64,7 +64,7 @@ int exynos_power_init(void)
 	int ret;
 
 #ifdef CONFIG_PMIC_S2MPS11
-	ret = pmic_get("s2mps11_pmic", &dev);
+	ret = pmic_get("s2mps11_pmic at 66", &dev);
 #else
 	ret = pmic_get("max77686", &dev);
 	if (!ret) {

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200115/e8d18b91/attachment.sig>