i2c: pmcmsp: Use proper printk format for resource_size_t
Subsystems (2)
PATCH v3 1/3 i2c: pmcmsp: Use proper printk format for resource_size_t
resource_size_t should be printed with its own size-independent format to fix warnings when compiling on 64-bit platform (e.g. with COMPILE_TEST):
drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’:
drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
---
Changes since v2:
1. Remove parentheses around res->start.
Changes since v1:
1. Use %pap, not %pa[p].
--- drivers/i2c/busses/i2c-pmcmsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/i2c/busses/i2c-pmcmsp.c +3 -3
@@ -274,8 +274,8 @@ static int pmcmsptwi_probe(struct platform_device *pldev)if (!request_mem_region (res->start,resource_size (res), pldev->name)) {dev_err (&pldev->dev, -"Unable to get memory/io address region 0x%08x\n" , - res->start); +"Unable to get memory/io address region %pap\n" , + &res->start); rc = -EBUSY ; goto ret_err; }
@@ -285,7 +285,7 @@ static int pmcmsptwi_probe(struct platform_device *pldev) resource_size(res));if (!pmcmsptwi_data.iobase) {dev_err (&pldev->dev, -"Unable to ioremap address 0x%08x\n" , res->start); +"Unable to ioremap address %pap\n" , &res->start); rc = -EIO ; goto ret_unreserve; }
Signature · 1 line
2.17.1
PATCH v3 2/3 i2c: pnx: Use proper printk format for resource_size_t
resource_size_t should be printed with its own size-independent format to fix warnings when compiling on 64-bit platform (e.g. with COMPILE_TEST):
drivers/i2c/busses/i2c-pnx.c: In function ‘i2c_pnx_probe’:
drivers/i2c/busses/i2c-pnx.c:737:47: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 5 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]
---
Changes since v2:
1. Remove parentheses around res->start.
Changes since v1:
1. Use %pap, not %pa[p].
--- drivers/i2c/busses/i2c-pnx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-pnx.c +2 -2
@@ -734,8 +734,8 @@ static int i2c_pnx_probe(struct platform_device *pdev)if (ret <0 ) goto out_clock; -dev_dbg (&pdev->dev,"%s: Master at %#8x, irq %d.\n" , - alg_data->adapter.name, res->start, alg_data->irq); +dev_dbg (&pdev->dev,"%s: Master at %pap, irq %d.\n" , + alg_data->adapter.name, &res->start, alg_data->irq);return 0 ;
Signature · 1 line
2.17.1
Wolfram Sang
AppliedRe: [PATCH v3 2/3] i2c: pnx: Use proper printk format for resource_size_t
Quoted 11 lines · Krzysztof Kozlowski
resource_size_tshould be printed with its own size-independent format to fix warnings when compiling on 64-bit platform (e.g. withCOMPILE_TEST):
drivers/i2c/busses/i2c-pnx.c: In function ‘i2c_pnx_probe’:
drivers/i2c/busses/i2c-pnx.c:737:47: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 5 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied to for-next, thanks!
PATCH v3 3/3 i2c: highlander: Use proper printk format for size_t
In reply to Krzysztof Kozlowskisize_t should be printed with its own format to be 64-bit friendly and fix warning when compiling on 64-bit platform (e.g. with COMPILE_TEST):
drivers/i2c/busses/i2c-highlander.c: In function ‘highlander_i2c_smbus_xfer’:
drivers/i2c/busses/i2c-highlander.c:325:22: warning:
format ‘%d’ expects argument of type ‘int’,
but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
---
Changes since v2:
1. Rewrite incorrect commit msg.
Changes since v1:
1. None
--- drivers/i2c/busses/i2c-highlander.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-highlander.c +1 -1
@@ -322,7 +322,7 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr, tmp |= (SMMR_MODE0 |SMMR_MODE1 );break ;default : -dev_err (dev->dev,"unsupported xfer size %d\n" , dev->buf_len); +dev_err (dev->dev,"unsupported xfer size %zu\n" , dev->buf_len);return -EINVAL ; }
Signature · 1 line
2.17.1
Wolfram Sang
AppliedRe: [PATCH v3 3/3] i2c: highlander: Use proper printk format for size_t
Quoted 10 lines · Krzysztof Kozlowski
size_tshould be printed with its own format to be 64-bit friendly and fix warning when compiling on 64-bit platform (e.g. withCOMPILE_TEST):
drivers/i2c/busses/i2c-highlander.c: In function ‘highlander_i2c_smbus_xfer’:
drivers/i2c/busses/i2c-highlander.c:325:22: warning:
format ‘%d’ expects argument of type ‘int’,
but argument 3 has type ‘size_t {aka long unsigned int}’ [-Wformat=]Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied to for-next, thanks!
Wolfram Sang
AppliedQuoted 11 lines · Krzysztof Kozlowski
resource_size_tshould be printed with its own size-independent format to fix warnings when compiling on 64-bit platform (e.g. withCOMPILE_TEST):
drivers/i2c/busses/i2c-pmcmsp.c: In function ‘pmcmsptwi_probe’:
drivers/i2c/busses/i2c-pmcmsp.c:276:25: warning:
format ‘%x’ expects argument of type ‘unsigned int’,
but argument 3 has type ‘resource_size_t {aka long long unsigned int}’ [-Wformat=]Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied to for-next, thanks!