HID: logitech-dj: add support for the static device in the Powerplay mat/receiver
Subsystems (2)
PATCH 1/1 HID: logitech-dj: add support for the static device in the Powerplay mat/receiver
The Logitech G Powerplay has a lightspeed receiver with a static HID++ device with ID 7 attached to it to. It is used to configure the led on the mat. For this reason I increased the max number of devices.
--- drivers/hid/hid-logitech-dj.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/hid/hid-logitech-dj.c +7 -2
@@ -16,11 +16,11 @@#include <asm/unaligned.h> #include "hid-ids.h" -#define DJ_MAX_PAIRED_DEVICES 6 +#define DJ_MAX_PAIRED_DEVICES 7#define DJ_MAX_NUMBER_NOTIFS 8#define DJ_RECEIVER_INDEX 0#define DJ_DEVICE_INDEX_MIN 1 -#define DJ_DEVICE_INDEX_MAX 6 +#define DJ_DEVICE_INDEX_MAX 7#define DJREPORT_SHORT_LENGTH 15#define DJREPORT_LONG_LENGTH 32
@@ -980,6 +980,11 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,break ; } +/* custom receiver device (eg. powerplay) */ +if (hidpp_report->device_index ==7 ) { + workitem.reports_supported |=HIDPP ; + } +if (workitem.type ==WORKITEM_TYPE_EMPTY ) { hid_warn(hdev, "unusable device of type %s (0x%02x) connected on slot %d",
Signature · 1 line
2.24.1
Quoted 42 lines · Filipe Laíns
The Logitech G Powerplay has a lightspeed receiver with a static HID++
device with ID 7 attached to it to. It is used to configure the led on
the mat. For this reason I increased the max number of devices.Signed-off-by Filipe Laíns <[email protected]>--- drivers/hid/hid-logitech-dj.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/hid/hid- renamed from drivers/hid/hid-logitech-dj.c +0
-0
logitech-dj.c
indexbb50d6e7745b..79294b873057100644drivers/hid/hid-logitech-dj.c +7
-2@@ -16,11 +16,11 @@#include <asm/unaligned.h> #include "hid-ids.h" -#define DJ_MAX_PAIRED_DEVICES 6 +#define DJ_MAX_PAIRED_DEVICES 7#define DJ_MAX_NUMBER_NOTIFS 8#define DJ_RECEIVER_INDEX 0#define DJ_DEVICE_INDEX_MIN 1 -#define DJ_DEVICE_INDEX_MAX 6 +#define DJ_DEVICE_INDEX_MAX 7#define DJREPORT_SHORT_LENGTH 15#define DJREPORT_LONG_LENGTH 32@@ -980,6 +980,11 @@ static void logi_hidpp_recv_queue_notif(structhid_device *hdev, break; } +/* custom receiver device (eg. powerplay) */ +if (hidpp_report->device_index ==7 ) { + workitem.reports_supported |=HIDPP ; + } +if (workitem.type ==WORKITEM_TYPE_EMPTY ) { hid_warn(hdev,
Quoted 2 lines
"unusable device of type %s (0x%02x) connected
on slot %d",
Benjamin, is there any updates on this? Were you able to test it?
Thank you,
Filipe Laíns
Jiri Kosina
maintainerQuoted 28 lines · Filipe Laíns
The Logitech G Powerplay has a lightspeed receiver with a static HID++ device with ID 7 attached to it to. It is used to configure the led on the mat. For this reason I increased the max number of devices.
Signed-off-by Filipe Laíns <[email protected]>--- drivers/hid/hid-logitech-dj.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/hid/hid-logitech-dj.c +2
-2@@ -16,11 +16,11 @@#include <asm/unaligned.h> #include "hid-ids.h" -#define DJ_MAX_PAIRED_DEVICES 6 +#define DJ_MAX_PAIRED_DEVICES 7#define DJ_MAX_NUMBER_NOTIFS 8#define DJ_RECEIVER_INDEX 0#define DJ_DEVICE_INDEX_MIN 1 -#define DJ_DEVICE_INDEX_MAX 6 +#define DJ_DEVICE_INDEX_MAX 7#define DJREPORT_SHORT_LENGTH 15#define DJREPORT_LONG_LENGTH 32
drivers/hid/hid-logitech-dj.c static void logi_hidpp_recv_queue_notif(struct hid_device *hdev, · line 987
Quoted 8 lines
drivers/hid/hid-logitech-dj.c +5
-0@@ -980,6 +980,11 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,break ; } +/* custom receiver device (eg. powerplay) */ +if (hidpp_report->device_index ==7 ) { + workitem.reports_supported |=HIDPP ; + } +
I guess we can't do anything else than to trust Logitech that they will not assign conflicting device_index ID in the future to something that will not be HID++, right?
Or is this properly documented somewhere?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs
Quoted 43 lines · Jiri Kosina
Quoted 28 lines · Filipe Laíns
The Logitech G Powerplay has a lightspeed receiver with a static HID++ device with ID 7 attached to it to. It is used to configure the led on the mat. For this reason I increased the max number of devices.
Signed-off-by Filipe Laíns <[email protected]>--- drivers/hid/hid-logitech-dj.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)drivers/hid/hid-logitech-dj.c +2
-2@@ -16,11 +16,11 @@#include <asm/unaligned.h> #include "hid-ids.h" -#define DJ_MAX_PAIRED_DEVICES 6 +#define DJ_MAX_PAIRED_DEVICES 7#define DJ_MAX_NUMBER_NOTIFS 8#define DJ_RECEIVER_INDEX 0#define DJ_DEVICE_INDEX_MIN 1 -#define DJ_DEVICE_INDEX_MAX 6 +#define DJ_DEVICE_INDEX_MAX 7#define DJREPORT_SHORT_LENGTH 15#define DJREPORT_LONG_LENGTH 32drivers/hid/hid-logitech-dj.c static void logi_hidpp_recv_queue_notif(struct hid_device *hdev, · line 987
Quoted 8 lines
drivers/hid/hid-logitech-dj.c +5
-0@@ -980,6 +980,11 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,break ; } +/* custom receiver device (eg. powerplay) */ +if (hidpp_report->device_index ==7 ) { + workitem.reports_supported |=HIDPP ; + } +I guess we can't do anything else than to trust Logitech that they will not assign conflicting
device_indexID in the future to something that will not be HID++, right?
Quoted 3 lines
Or is this properly documented somewhere?
Thanks,
CCing Nestor
Yes, we need to trust Logitech on this. There's isn't anything documented regarding this AFAIK.
Even if Logitech released a device with index 7 that didn't support HID++, it wouldn't be that big of an issue. We would just end up with a hidraw node which would export a vendor page report descriptor but the device wouldn't actually reply to anything.
Regards,
Filipe Laíns
Jiri Kosina
maintainerQuoted 17 lines · Filipe Laíns
Quoted 10 lines
drivers/hid/hid-logitech-dj.c static void logi_hidpp_recv_queue_notif(struct hid_device *hdev, · line 987
Quoted 5 lines
drivers/hid/hid-logitech-dj.c +5
-0+/* custom receiver device (eg. powerplay) */ +if (hidpp_report->device_index ==7 ) { + workitem.reports_supported |=HIDPP ; + } +I guess we can't do anything else than to trust Logitech that they will not assign conflicting
device_indexID in the future to something that will not be HID++, right?Quoted 3 lines
Or is this properly documented somewhere?
Thanks,
CCing Nestor
Quoted 7 lines
Yes, we need to trust Logitech on this. There's isn't anything documented regarding this AFAIK.
Even if Logitech released a device with index 7 that didn't support HID++, it wouldn't be that big of an issue. We would just end up with a hidraw node which would export a vendor page report descriptor but the device wouldn't actually reply to anything.
Given the silence from Nestor, I guess we can just apply this for 5.7; pushing to for-5.7/logitech branch.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs