kcov: ignore fault-inject and stacktrace
Subsystems (2)
PATCH 1/1 kcov: ignore fault-inject and stacktrace
From: Dmitry Vyukov <[email protected]>
Don't instrument 3 more files that contain debugging facilities and produce large amounts of uninteresting coverage for every syscall. The following snippets are sprinkled all over the place in kcov traces in a debugging kernel. We already try to disable instrumentation of stack unwinding code and of most debug facilities. I guess we did not use fault-inject.c at the time, and stacktrace.c was somehow missed (or something has changed in kernel/configs).
This change both speeds up kcov (kernel doesn't need to store these PCs, user-space doesn't need to process them) and frees trace buffer capacity for more useful coverage.
should_faillib/fault-inject.c:149fail_dumplib/fault-inject.c:45
stack_trace_savekernel/stacktrace.c:124stack_trace_consume_entrykernel/stacktrace.c:86stack_trace_consume_entrykernel/stacktrace.c:89
... a hundred frames skipped ...stack_trace_consume_entrykernel/stacktrace.c:93stack_trace_consume_entrykernel/stacktrace.c:86
--- kernel/Makefile | 1 + lib/Makefile | 1 + mm/Makefile | 1 + 3 files changed, 3 insertions(+)
kernel/Makefile +1 -0
@@ -30,6 +30,7 @@ KCSAN_SANITIZE_softirq.o = n # and produce insane amounts of uninteresting coverage. KCOV_INSTRUMENT_module.o := n KCOV_INSTRUMENT_extable.o := n +KCOV_INSTRUMENT_stacktrace.o := n # Don't self-instrument. KCOV_INSTRUMENT_kcov.o := n KASAN_SANITIZE_kcov.o := n
lib/Makefile +1 -0
@@ -16,6 +16,7 @@ KCOV_INSTRUMENT_rbtree.o := n KCOV_INSTRUMENT_list_debug.o := n KCOV_INSTRUMENT_debugobjects.o := n KCOV_INSTRUMENT_dynamic_debug.o := n +KCOV_INSTRUMENT_fault-inject.o := n # Early boot use of cmdline, don't instrument it ifdef CONFIG_AMD_MEM_ENCRYPT
mm/Makefile +1 -0
@@ -28,6 +28,7 @@ KCOV_INSTRUMENT_kmemleak.o := n KCOV_INSTRUMENT_memcontrol.o := n KCOV_INSTRUMENT_mmzone.o := n KCOV_INSTRUMENT_vmstat.o := n +KCOV_INSTRUMENT_failslab.o := n CFLAGS_init-mm.o += $(call cc-disable-warning, override-init) CFLAGS_init-mm.o += $(call cc-disable-warning, initializer-overrides)
Signature · 1 line
2.25.0.rc1.283.g88dfdc4193-goog
Quoted 31 lines · Dmitry Vyukov
From: Dmitry Vyukov <[email protected]>
Don't instrument 3 more files that contain debugging facilities and produce large amounts of uninteresting coverage for every syscall. The following snippets are sprinkled all over the place in kcov traces in a debugging kernel. We already try to disable instrumentation of stack unwinding code and of most debug facilities. I guess we did not use
fault-inject.cat the time, andstacktrace.cwas somehow missed (or something has changed in kernel/configs).
This change both speeds up kcov (kernel doesn't need to store these PCs, user-space doesn't need to process them) and frees trace buffer capacity for more useful coverage.
should_faillib/fault-inject.c:149fail_dumplib/fault-inject.c:45
stack_trace_savekernel/stacktrace.c:124stack_trace_consume_entrykernel/stacktrace.c:86stack_trace_consume_entrykernel/stacktrace.c:89
... a hundred frames skipped ...stack_trace_consume_entrykernel/stacktrace.c:93stack_trace_consume_entrykernel/stacktrace.c:86
Quoted 1 line
Signed-off-by Dmitry Vyukov <[email protected]>
Quoted 49 lines
Cc Andrew Morton <[email protected]>Cc Andrey Konovalov <[email protected]>--- kernel/Makefile | 1 + lib/Makefile | 1 + mm/Makefile | 1 + 3 files changed, 3 insertions(+)kernel/Makefile +1
-0@@ -30,6 +30,7 @@ KCSAN_SANITIZE_softirq.o = n # and produce insane amounts of uninteresting coverage. KCOV_INSTRUMENT_module.o := n KCOV_INSTRUMENT_extable.o := n +KCOV_INSTRUMENT_stacktrace.o := n # Don't self-instrument. KCOV_INSTRUMENT_kcov.o := n KASAN_SANITIZE_kcov.o := nlib/Makefile +1
-0@@ -16,6 +16,7 @@ KCOV_INSTRUMENT_rbtree.o := n KCOV_INSTRUMENT_list_debug.o := n KCOV_INSTRUMENT_debugobjects.o := n KCOV_INSTRUMENT_dynamic_debug.o := n +KCOV_INSTRUMENT_fault-inject.o := n # Early boot use of cmdline, don't instrument it ifdef CONFIG_AMD_MEM_ENCRYPTmm/Makefile +1
-1@@ -28,6 +28,7 @@ KCOV_INSTRUMENT_kmemleak.o := n KCOV_INSTRUMENT_memcontrol.o := n KCOV_INSTRUMENT_mmzone.o := n KCOV_INSTRUMENT_vmstat.o := n +KCOV_INSTRUMENT_failslab.o := n CFLAGS_init-mm.o += $(call cc-disable-warning, override-init) CFLAGS_init-mm.o += $(call cc-disable-warning, initializer-overrides) --2.25.0.rc1.283.g88dfdc4193-goog