Skip to contentSkip to conversation

cmd/blk_common: clarify no partition error message

PATCH New Alexandre Besnard 2 participants 2 messages Dec 20, 2019 – Jan 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd/blk_common: clarify no partition error message

When no partition table is found, users should be warned so. Warning that no device is available in this case could be misleading, especially as it is the same error when no device is selected.

---
 cmd/blk_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
cmd/blk_common.c +2 -1
index c5514cf8f8..cc6e161ba0 100644
@@ -32,7 +32,8 @@ int blk_common_cmd(int argc, char * const argv[], enum if_type if_type,
 			return 0;
 		} else if (strncmp(argv[1], "part", 4) == 0) {
 			if (blk_list_part(if_type))
-				printf("\nno %s devices available\n", if_name);
+				printf("\nno %s partition table available\n",
+				       if_name);
 			return 0;
 		}
 		return CMD_RET_USAGE;

--
2.24.1

#1 lore raw

PATCH 1/1 cmd/blk_common: clarify no partition error message

Quoted 5 lines · Alexandre Besnard

When no partition table is found, users should be warned so. Warning that no device is available in this case could be misleading, especially as it is the same error when no device is selected.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200116/c55e8bed/attachment.sig>