Skip to contentSkip to conversation

enetc: Don't print from enetc_sched_speed_set when link goes down

PATCH Applied Vladimir Oltean 3 participants 3 messages Jan 16, 2020 – Jan 17, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 enetc: Don't print from enetc_sched_speed_set when link goes down

From: Vladimir Oltean <[email protected]>

It is not an error to unplug a cable from the ENETC port even with TSN offloads, so don't spam the log with link-related messages from the tc-taprio offload subsystem, a single notification is sufficient:

[10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
[10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
Fixes 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")
---
 drivers/net/ethernet/freescale/enetc/enetc_qos.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/freescale/enetc/enetc_qos.c +0 -1
index 00382b7c5bd8..0c6bf3a55a9a 100644
@@ -36,7 +36,6 @@ void enetc_sched_speed_set(struct net_device *ndev)
 	case SPEED_10:
 	default:
 		pspeed = ENETC_PMR_PSPEED_10M;
-		netdev_err(ndev, "Qbv PSPEED set speed link down.\n");
 	}
 
 	priv->speed = speed;
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Vladimir Oltean

From: Vladimir Oltean <[email protected]>

It is not an error to unplug a cable from the ENETC port even with TSN offloads, so don't spam the log with link-related messages from the tc-taprio offload subsystem, a single notification is sufficient:

[10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
[10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
Fixes 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")

Andrew

maintainer Applied
#2 lore raw
In reply to Vladimir Oltean

From: Vladimir Oltean <[email protected]>
Date: Thu, 16 Jan 2020 19:18:28 +0200

Quoted 11 lines

From: Vladimir Oltean <[email protected]>

It is not an error to unplug a cable from the ENETC port even with TSN offloads, so don't spam the log with link-related messages from the tc-taprio offload subsystem, a single notification is sufficient:

[10972.351859] fsl_enetc 0000:00:00.0 eno0: Qbv PSPEED set speed link down.
[10972.360241] fsl_enetc 0000:00:00.0 eno0: Link is Down
Fixes 2e47cb415f0a ("enetc: update TSN Qbv PSPEED set according to adjust link speed")

Applied, thanks.