net: dsa: felix: Set USXGMII link based on BMSR, not LPA
Subsystems (4)
Vladimir Oltean
maintainerPATCH 1/1 net: dsa: felix: Set USXGMII link based on BMSR, not LPA
From: Alex Marginean <[email protected]>
At least some PHYs (AQR412) don't advertise copper-side link status during system side AN.
So remove this duplicate assignment to pcs->link and rely on the previous one for link state: the local indication from the MAC PCS.
Fixes bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
Signed-off-by Alex Marginean <[email protected]>
Signed-off-by Vladimir Oltean <[email protected]>
--- drivers/net/dsa/ocelot/felix_vsc9959.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/dsa/ocelot/felix_vsc9959.c +0 -1
@@ -892,7 +892,6 @@ static void vsc9959_pcs_link_state_usxgmii(struct phy_device *pcs,break ; } - pcs->link =USXGMII_LPA_LNKS (lpa);if (USXGMII_LPA_DUPLEX (lpa)) pcs->duplex =DUPLEX_FULL ;else
Signature · 1 line
2.17.1
From: Vladimir Oltean <[email protected]>
Date: Thu, 16 Jan 2020 20:05:06 +0200
Quoted 11 lines
From: Alex Marginean <[email protected]>
At least some PHYs (AQR412) don't advertise copper-side link status during system side AN.
So remove this duplicate assignment to
pcs->linkand rely on the previous one for link state: the local indication from the MAC PCS.Fixes bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")Signed-off-by Alex Marginean <[email protected]>Signed-off-by Vladimir Oltean <[email protected]>
Applied, thanks.