net: dsa: sja1105: Don't error out on disabled ports with no phy-mode
Vladimir Oltean
maintainerPATCH v2 1/1 net: dsa: sja1105: Don't error out on disabled ports with no phy-mode
From: Vladimir Oltean <[email protected]>
The sja1105_parse_ports_node function was tested only on device trees where all ports were enabled. Fix this check so that the driver continues to probe only with the ports where status is not "disabled", as expected.
Fixes 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
Signed-off-by Vladimir Oltean <[email protected]>
Reviewed-by Florian Fainelli <[email protected]>
--- drivers/net/dsa/sja1105/sja1105_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/sja1105/sja1105_main.c +1 -1
@@ -574,7 +574,7 @@ static int sja1105_parse_ports_node(struct sja1105_private *priv,struct device *dev = &priv->spidev->dev;struct device_node *child; -for_each_child_of_node (ports_node, child) { +for_each_available_child_of_node (ports_node, child) {struct device_node *phy_node;phy_interface_t phy_mode;u32 index;
Signature · 1 line
2.17.1
David Miller
maintainerFrom: Vladimir Oltean <[email protected]>
Date: Thu, 16 Jan 2020 20:43:27 +0200
Quoted 10 lines
From: Vladimir Oltean <[email protected]>
The
sja1105_parse_ports_nodefunction was tested only on device trees where all ports were enabled. Fix this check so that the driver continues to probe only with the ports where status is not "disabled", as expected.Fixes 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")Signed-off-by Vladimir Oltean <[email protected]>Reviewed-by Florian Fainelli <[email protected]>
Applied and queued up for -stable.