uas: fix super speed bMaxPacketSize0
PATCH 1/1 uas: fix super speed bMaxPacketSize0
For usb2 bMaxPacketSize0 is "n", for usb3 it is "1 << n", so it must be 9 not 64 ...
--- hw/usb/dev-uas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/usb/dev-uas.c +1 -1
@@ -303,7 +303,7 @@ static const USBDescDevice desc_device_high = {static const USBDescDevice desc_device_super = { .bcdUSB =0x0300 , - .bMaxPacketSize0 =64 , + .bMaxPacketSize0 =9 , .bNumConfigurations =1 , .confs = (USBDescConfig []) { {
Signature · 1 line
2.18.1
Quoted 2 lines · Gerd Hoffmann
For usb2 bMaxPacketSize0 is "n", for usb3 it is "1 << n", so it must be 9 not 64 ...
Maybe add in description:
From "Universal Serial Bus 3.1 Specification":
If the device is operating at Gen X speed, the bMaxPacketSize0 field shall be set to 09H indicating a 512-byte maximum packet. An Enhanced SuperSpeed device shall not support any other maximum packet sizes for the default control pipe (endpoint 0) control endpoint.
We now announce a 512-byte maximum packet.
Quoted 1 line
Reported-by [email protected]
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
"Please use your real name to sign a patch (not an alias or acronym)."
OK this is not about the author name but reporter name.
Gerd, I think you we use 'Reported-by: Benjamin David Lunt <[email protected]>' instead, which was previously used in commit 9da82227caa7 (except if Ben refuses obviously).
Quoted 19 lines
Signed-off-by Gerd Hoffmann <[email protected]>--- hw/usb/dev-uas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/usb/dev-uas.c +1
-1@@ -303,7 +303,7 @@ static const USBDescDevice desc_device_high = {static const USBDescDevice desc_device_super = { .bcdUSB =0x0300 , - .bMaxPacketSize0 =64 , + .bMaxPacketSize0 =9 , .bNumConfigurations =1 , .confs = (USBDescConfig []) { {