Skip to contentSkip to conversation

EDAC/amd64: Do not warn when removing instances

PATCH New Borislav Petkov 1 participant 1 message Jan 17, 2020

Subsystems (2)
lore
Share & tools
lore

Borislav Petkov

author maintainer
#0 lore raw

PATCH 1/1 EDAC/amd64: Do not warn when removing instances

From: Borislav Petkov <[email protected]>

On machines which do not populate all nodes with DIMMs, the driver doesn't initialize an instance there. However, the instance removal remove_one_instance() path will warn unconditionally, which is wrong.

Remove the WARN_ON() even if the warning is innocent because it causes a splat in dmesg.

---
 drivers/edac/amd64_edac.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/edac/amd64_edac.c +0 -3
index 428ce98f6776..d2a6d3319650 100644
@@ -3573,9 +3573,6 @@ static void remove_one_instance(unsigned int nid)
 	struct mem_ctl_info *mci;
 	struct amd64_pvt *pvt;
 
-	mci = find_mci_by_dev(&F3->dev);
-	WARN_ON(!mci);
-
 	/* Remove from EDAC CORE tracking list */
 	mci = edac_mc_del_mc(&F3->dev);
 	if (!mci)
Signature · 1 line
2.21.0