Skip to contentSkip to conversation

rockchip: make_fit_atf: use correct fdt_x references in config nodes

PATCH New Heiko Stuebner 2 participants 2 messages Jan 17, 2020 – Feb 19, 2020

Subsystems (3)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/1 rockchip: make_fit_atf: use correct fdt_x references in config nodes

From: Heiko Stuebner <[email protected]>

The script iterates over the given devicetrees and creates both fdt_x node as well as a conf-node for each passed dt.

But there is a slight bug in that it always references fdt_1 in each conf node instead of the matching fdt_x as expected.

So fix that by referencing the number of the current dt similar to how the fdt_x nodes gets created.

---
 arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-rockchip/make_fit_atf.py +1 -1
index 3c045a5e17..aaec2cd270 100755
@@ -107,7 +107,7 @@ def append_conf_section(file, cnt, dtname, segments):
             file.write(';\n')
     if segments <= 1:
         file.write(';\n')
-    file.write('\t\t\tfdt = "fdt_1";\n')
+    file.write('\t\t\tfdt = "fdt_%d";\n' % cnt)
     file.write('\t\t};\n')
     file.write('\n')
 
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 rockchip: make_fit_atf: use correct fdt_x references in config nodes

<[email protected]>

Thanks,
- Kever

Heiko Stuebner <[email protected]> ?2020?1?18??? ??4:26???

Quoted 34 lines

From: Heiko Stuebner <[email protected]>

The script iterates over the given devicetrees and creates both fdt_x node as well as a conf-node for each passed dt.

But there is a slight bug in that it always references fdt_1 in each conf node instead of the matching fdt_x as expected.

So fix that by referencing the number of the current dt similar to how the fdt_x nodes gets created.

---
 arch/arm/mach-rockchip/make_fit_atf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-rockchip/make_fit_atf.py +1 -2
index 3c045a5e17..aaec2cd270 100755
@@ -107,7 +107,7 @@ def append_conf_section(file, cnt, dtname, segments):
             file.write(';\n')
     if segments <= 1:
         file.write(';\n')
-    file.write('\t\t\tfdt = "fdt_1";\n')
+    file.write('\t\t\tfdt = "fdt_%d";\n' % cnt)
     file.write('\t\t};\n')
     file.write('\n')
 
--

2.24.1