Skip to contentSkip to conversation

phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS

PATCH In review Kishon Vijay Abraham I 2 participants 3 messages Jan 17, 2020 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: ti: j721e-wiz: Fix build error without CONFIG_OF_ADDRESS

From: Hongbo Yao <[email protected]>

If CONFIG_OF_ADDRESS is not set and COMPILE_TEST=y, the following error is seen while building phy-j721e-wiz.c

drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
phy-j721e-wiz.c:(.text+0x1a): undefined reference to `of_platform_device_destroy'

Fix the config dependency for PHY_J721E_WIZ here.

Fixes 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
---
 drivers/phy/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/phy/ti/Kconfig +1 -0
index 3a1d3887c99c..6dbe9d0b9ff3 100644
@@ -36,6 +36,7 @@ config PHY_AM654_SERDES
 config PHY_J721E_WIZ
 	tristate "TI J721E WIZ (SERDES Wrapper) support"
 	depends on OF && ARCH_K3 || COMPILE_TEST
+	depends on HAS_IOMEM && OF_ADDRESS
 	depends on COMMON_CLK
 	select GENERIC_PHY
 	select MULTIPLEXER
Signature · 1 line
2.17.1
#1 lore raw
Quoted 11 lines · Kishon Vijay Abraham I

From: Hongbo Yao <[email protected]>

If CONFIG_OF_ADDRESS is not set and COMPILE_TEST=y, the following error is seen while building phy-j721e-wiz.c

drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
phy-j721e-wiz.c:(.text+0x1a): undefined reference to `of_platform_device_destroy'

Fix the config dependency for PHY_J721E_WIZ here.

Quoted 7 lines
Fixes 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
---
 drivers/phy/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Want me to just take this directly in my tree so the build error goes away?

thanks,

greg k-h

#2 lore raw
Quoted 20 lines · Greg Kroah-Hartman
Quoted 11 lines · Kishon Vijay Abraham I

From: Hongbo Yao <[email protected]>

If CONFIG_OF_ADDRESS is not set and COMPILE_TEST=y, the following error is seen while building phy-j721e-wiz.c

drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
phy-j721e-wiz.c:(.text+0x1a): undefined reference to `of_platform_device_destroy'

Fix the config dependency for PHY_J721E_WIZ here.

Quoted 7 lines
Fixes 091876cc355d ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
---
 drivers/phy/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 2 lines

Want me to just take this directly in my tree so the build error goes away?

Nevermind, I did :)