Skip to contentSkip to conversation

drm/i915: Nuke intel_atomic_lock/serialize_global_state()

PATCH New José Roberto de Souza 2 participants 4 messages Jan 18, 2020 – Jan 21, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Nuke intel_atomic_lock/serialize_global_state()

When computing GEN 9+ watermarks all the pipes were being added to the state whatever the state needs a modeset or the active pipes changed what is redundant.
As when a pipe/CRTC is added to the state it means that the state also holds the CRTC lock, so we can remove a lot of code and complexity by adding all CRTCs to the state earlier with no drawbacks for GEN 9+ and little to nothing in older GENs.

Also it brings other improvements like atomic state has now a device wide correctly active_pipes and it will fix the enabling of the right number of the dbufs as if the state was only enabling one pipe and only had one CRTC state it would only enable one slice.

Bellow some justifications that might not be so easy to understand:

- intel_atomic_lock_global_state() is not needed anymore in glk_force_audio_cdclk() because setting force_min_cdclk_changed will force a modeset
- intel_cdclk.c also don't need intel_atomic_lock_global_state() or intel_atomic_serialize_global_state() as those functions are called by intel_modeset_checks() call chain after the CRCTs are added to the state
- no need to call intel_atomic_lock_global_state() in intel_modeset_checks() as we just got the CRTCs locks.

Cc Stanislav Lisovskiy <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_atomic.c   | 38 -----------------
 drivers/gpu/drm/i915/display/intel_atomic.h   |  4 --
 drivers/gpu/drm/i915/display/intel_audio.c    |  6 +--
 drivers/gpu/drm/i915/display/intel_cdclk.c    | 33 +++------------
 drivers/gpu/drm/i915/display/intel_display.c  | 20 ++++-----
 .../drm/i915/display/intel_display_types.h    | 18 --------
 drivers/gpu/drm/i915/intel_pm.c               | 42 +++----------------
 7 files changed, 18 insertions(+), 143 deletions(-)
drivers/gpu/drm/i915/display/intel_atomic.c +0 -38
index c362eecdd414..03938ae2fb05 100644
@@ -499,7 +499,6 @@ void intel_atomic_state_clear(struct drm_atomic_state *s)
 	struct intel_atomic_state *state = to_intel_atomic_state(s);
 	drm_atomic_state_default_clear(&state->base);
 	state->dpll_set = state->modeset = false;
-	state->global_state_changed = false;
 	state->active_pipes = 0;
 	memset(&state->min_cdclk, 0, sizeof(state->min_cdclk));
 	memset(&state->min_voltage_level, 0, sizeof(state->min_voltage_level));
@@ -519,40 +518,3 @@ intel_atomic_get_crtc_state(struct drm_atomic_state *state,
 
 	return to_intel_crtc_state(crtc_state);
 }
-
-int intel_atomic_lock_global_state(struct intel_atomic_state *state)
-{
-	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
-	struct intel_crtc *crtc;
-
-	state->global_state_changed = true;
-
-	for_each_intel_crtc(&dev_priv->drm, crtc) {
-		int ret;
-
-		ret = drm_modeset_lock(&crtc->base.mutex,
-				       state->base.acquire_ctx);
-		if (ret)
-			return ret;
-	}
-
-	return 0;
-}
-
-int intel_atomic_serialize_global_state(struct intel_atomic_state *state)
-{
-	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
-	struct intel_crtc *crtc;
-
-	state->global_state_changed = true;
-
-	for_each_intel_crtc(&dev_priv->drm, crtc) {
-		struct intel_crtc_state *crtc_state;
-
-		crtc_state = intel_atomic_get_crtc_state(&state->base, crtc);
-		if (IS_ERR(crtc_state))
-			return PTR_ERR(crtc_state);
-	}
-
-	return 0;
-}
drivers/gpu/drm/i915/display/intel_atomic.h +0 -4
index 74c749dbfb4f..b324d12bdd97 100644
@@ -55,8 +55,4 @@ int intel_atomic_setup_scalers(struct drm_i915_private *dev_priv,
 			       struct intel_crtc *intel_crtc,
 			       struct intel_crtc_state *crtc_state);
 
-int intel_atomic_lock_global_state(struct intel_atomic_state *state);
-
-int intel_atomic_serialize_global_state(struct intel_atomic_state *state);
-
 #endif /* __INTEL_ATOMIC_H__ */
drivers/gpu/drm/i915/display/intel_audio.c +1 -5
index b18040793d9e..0147e1f382b6 100644
@@ -819,11 +819,7 @@ static void glk_force_audio_cdclk(struct drm_i915_private *dev_priv,
 	to_intel_atomic_state(state)->cdclk.force_min_cdclk =
 		enable ? 2 * 96000 : 0;
 
-	/* Protects dev_priv->cdclk.force_min_cdclk */
-	ret = intel_atomic_lock_global_state(to_intel_atomic_state(state));
-	if (!ret)
-		ret = drm_atomic_commit(state);
-
+	ret = drm_atomic_commit(state);
 	if (ret == -EDEADLK) {
 		drm_atomic_state_clear(state);
 		drm_modeset_backoff(&ctx);
drivers/gpu/drm/i915/display/intel_cdclk.c +5 -28
index 0ce5926006ca..469617436815 100644
@@ -2037,8 +2037,6 @@ static int intel_compute_min_cdclk(struct intel_atomic_state *state)
 	       sizeof(state->min_cdclk));
 
 	for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
-		int ret;
-
 		min_cdclk = intel_crtc_compute_min_cdclk(crtc_state);
 		if (min_cdclk < 0)
 			return min_cdclk;
@@ -2047,10 +2045,6 @@ static int intel_compute_min_cdclk(struct intel_atomic_state *state)
 			continue;
 
 		state->min_cdclk[i] = min_cdclk;
-
-		ret = intel_atomic_lock_global_state(state);
-		if (ret)
-			return ret;
 	}
 
 	min_cdclk = state->cdclk.force_min_cdclk;
@@ -2086,8 +2080,6 @@ static int bxt_compute_min_voltage_level(struct intel_atomic_state *state)
 	       sizeof(state->min_voltage_level));
 
 	for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
-		int ret;
-
 		if (crtc_state->hw.enable)
 			min_voltage_level = crtc_state->min_voltage_level;
 		else
@@ -2097,10 +2089,6 @@ static int bxt_compute_min_voltage_level(struct intel_atomic_state *state)
 			continue;
 
 		state->min_voltage_level[i] = min_voltage_level;
-
-		ret = intel_atomic_lock_global_state(state);
-		if (ret)
-			return ret;
 	}
 
 	min_voltage_level = 0;
@@ -2348,23 +2336,12 @@ int intel_modeset_calc_cdclk(struct intel_atomic_state *state)
 	 * by holding all the crtc mutexes even if we don't end up
 	 * touching the hardware
 	 */
-	if (intel_cdclk_changed(&dev_priv->cdclk.actual,
-				&state->cdclk.actual)) {
-		/*
-		 * Also serialize commits across all crtcs
-		 * if the actual hw needs to be poked.
-		 */
-		ret = intel_atomic_serialize_global_state(state);
-		if (ret)
-			return ret;
-	} else if (intel_cdclk_changed(&dev_priv->cdclk.logical,
-				       &state->cdclk.logical)) {
-		ret = intel_atomic_lock_global_state(state);
-		if (ret)
-			return ret;
-	} else {
+	ret = intel_cdclk_changed(&dev_priv->cdclk.actual,
+				  &state->cdclk.actual);
+	ret |= intel_cdclk_changed(&dev_priv->cdclk.logical,
+				   &state->cdclk.logical);
+	if (!ret)
 		return 0;
-	}
 
 	if (is_power_of_2(state->active_pipes) &&
 	    intel_cdclk_needs_cd2x_update(dev_priv,
drivers/gpu/drm/i915/display/intel_display.c +7 -13
index dd03987cc24f..b3a6e39e48c8 100644
@@ -14284,25 +14284,19 @@ static int intel_modeset_checks(struct intel_atomic_state *state)
 		state->cdclk.force_min_cdclk = dev_priv->cdclk.force_min_cdclk;
 
 	state->modeset = true;
-	state->active_pipes = dev_priv->active_pipes;
 	state->cdclk.logical = dev_priv->cdclk.logical;
 	state->cdclk.actual = dev_priv->cdclk.actual;
 
+	for_each_intel_crtc(&dev_priv->drm, crtc) {
+		new_crtc_state = intel_atomic_get_crtc_state(&state->base, crtc);
+		if (IS_ERR(new_crtc_state))
+			return PTR_ERR(new_crtc_state);
+	}
+
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
 					    new_crtc_state, i) {
 		if (new_crtc_state->hw.active)
 			state->active_pipes |= BIT(crtc->pipe);
-		else
-			state->active_pipes &= ~BIT(crtc->pipe);
-
-		if (old_crtc_state->hw.active != new_crtc_state->hw.active)
-			state->active_pipe_changes |= BIT(crtc->pipe);
-	}
-
-	if (state->active_pipe_changes) {
-		ret = intel_atomic_lock_global_state(state);
-		if (ret)
-			return ret;
 	}
 
 	ret = intel_modeset_calc_cdclk(state);
@@ -15586,7 +15580,7 @@ static int intel_atomic_commit(struct drm_device *dev,
 	intel_shared_dpll_swap_state(state);
 	intel_atomic_track_fbs(state);
 
-	if (state->global_state_changed) {
+	if (state->modeset) {
 		assert_global_state_locked(dev_priv);
 
 		memcpy(dev_priv->min_cdclk, state->min_cdclk,
drivers/gpu/drm/i915/display/intel_display_types.h +0 -18
index 155ce49ae764..60d812234654 100644
@@ -483,16 +483,6 @@ struct intel_atomic_state {
 
 	bool dpll_set, modeset;
 
-	/*
-	 * Does this transaction change the pipes that are active?  This mask
-	 * tracks which CRTC's have changed their active state at the end of
-	 * the transaction (not counting the temporary disable during modesets).
-	 * This mask should only be non-zero when intel_state->modeset is true,
-	 * but the converse is not necessarily true; simply changing a mode may
-	 * not flip the final active status of any CRTC's
-	 */
-	u8 active_pipe_changes;
-
 	u8 active_pipes;
 	/* minimum acceptable cdclk for each pipe */
 	int min_cdclk[I915_MAX_PIPES];
@@ -509,14 +499,6 @@ struct intel_atomic_state {
 
 	bool rps_interactive;
 
-	/*
-	 * active_pipes
-	 * min_cdclk[]
-	 * min_voltage_level[]
-	 * cdclk.*
-	 */
-	bool global_state_changed;
-
 	/* Gen9+ only */
 	struct skl_ddb_values wm_results;
 
drivers/gpu/drm/i915/intel_pm.c +5 -37

83 lines not on this page · raw message

Signature · 6 lines
2.25.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Nuke intel_atomic_lock/serialize_global_state()

== Series Details ==

== Series Details ==

Series: drm/i915: Nuke intel_atomic_lock/serialize_global_state()
URL : https://patchwork.freedesktop.org/series/72242/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7772 -> Patchwork_16167
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_16167 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_16167, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_16167:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-skl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-skl-guc/igt@[email protected]
- fi-cml-u2: [PASS][3] -> [FAIL][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-cml-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-cml-u2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_16167 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_blt:
- fi-hsw-4770: [PASS][5] -> [DMESG-FAIL][6] ([i915#553] / [i915#725])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-hsw-4770/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-hsw-4770/igt@i915_selftest@live_blt.html

* igt@kms_busy@basic-flip-pipe-a:
- fi-icl-u2: [PASS][7] -> [TIMEOUT][8] ([fdo#112271] / [i915#449])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-icl-u2/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-kbl-r: [PASS][9] -> [SKIP][10] ([fdo#109271]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-kbl-r/igt@kms_psr@cursor_plane_move.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-kbl-r/igt@kms_psr@cursor_plane_move.html

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [PASS][11] -> [SKIP][12] ([fdo#109271]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

#### Possible fixes ####

* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6700k2: [INCOMPLETE][13] ([i915#671]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7772/fi-skl-6700k2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/fi-skl-6700k2/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#449]: https://gitlab.freedesktop.org/drm/intel/issues/449
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725

Participating hosts (40 -> 34)
------------------------------

Additional (4): fi-hsw-4770r fi-skl-lmem fi-ivb-3770 fi-elk-e7500
Missing (10): fi-bsw-n3050 fi-byt-j1900 fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-whl-u fi-cfl-8109u fi-byt-clapper fi-bsw-nick

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7772 -> Patchwork_16167

CI-20190529: 20190529
CI_DRM_7772: f65c394056d8637ff151fa83d5d1613adc0932d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5372: 0d00a27fbbd4d4a77d24499ea9811e07e65eb0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16167: 94e06d9a50ba0bede5d44ab57fbe731cb8a6f7c7 @ git://anongit.freedesktop.org/gfx-ci/linux

== Kernel 32bit build ==

Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/Patchwork_16167/build_32bit.log

  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  CHK     include/generated/compile.h

Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 122 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1282: recipe for target 'modules' failed
make: *** [modules] Error 2

== Linux commits ==

94e06d9a50ba drm/i915: Nuke intel_atomic_lock/serialize_global_state()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915: Nuke intel_atomic_lock/serialize_global_state()

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915: Nuke intel_atomic_lock/serialize_global_state()
URL : https://patchwork.freedesktop.org/series/72242/
State : warning

== Summary ==

CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
Building modules, stage 2.
MODPOST 122 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1282: recipe for target 'modules' failed
make: *** [modules] Error 2

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16167/build_32bit.log
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Nuke intel_atomic_lock/serialize_global_state() (rev2)

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915: Nuke intel_atomic_lock/serialize_global_state() (rev2)
URL : https://patchwork.freedesktop.org/series/72242/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7786 -> Patchwork_16200
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_16200 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_16200, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_16200:

### IGT changes ###

#### Possible regressions ####

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-skl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-skl-guc/igt@[email protected]
- fi-cml-u2: [PASS][3] -> [FAIL][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-cml-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-cml-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-kbl-7500u/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_16200 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_close_race@basic-threads:
- fi-byt-n2820: [PASS][7] -> [TIMEOUT][8] ([fdo#112271] / [i915#816])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-byt-n2820/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-byt-n2820/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-8700k: [PASS][9] -> [INCOMPLETE][10] ([i915#505])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-cfl-8700k/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-cfl-8700k/igt@[email protected]
- fi-kbl-7500u: [PASS][11] -> [INCOMPLETE][12] ([i915#879])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-kbl-7500u/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][13] -> [DMESG-FAIL][14] ([i915#725])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-ivb-3770/igt@i915_selftest@live_blt.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-ivb-3770/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_hangcheck:
- fi-icl-dsi: [PASS][15] -> [DMESG-FAIL][16] ([fdo#108569] / [i915#333] / [i915#419])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-icl-dsi/igt@i915_selftest@live_hangcheck.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [PASS][17] -> [FAIL][18] ([i915#217])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-icl-u2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-icl-u2/igt@[email protected]
- fi-kbl-7500u: [PASS][19] -> [FAIL][20] ([fdo#111407])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-kbl-7500u/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-kbl-7500u/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-kbl-r: [PASS][21] -> [SKIP][22] ([fdo#109271] / [i915#668]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-kbl-r/igt@kms_psr@cursor_plane_move.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-kbl-r/igt@kms_psr@cursor_plane_move.html

#### Warnings ####

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][23] ([i915#770]) -> [DMESG-FAIL][24] ([i915#553] / [i915#725])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [DMESG-FAIL][25] ([i915#563]) -> [DMESG-FAIL][26] ([i915#553] / [i915#725])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7786/fi-hsw-4770/igt@i915_selftest@live_blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/fi-hsw-4770/igt@i915_selftest@live_blt.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#333]: https://gitlab.freedesktop.org/drm/intel/issues/333
[i915#419]: https://gitlab.freedesktop.org/drm/intel/issues/419
[i915#505]: https://gitlab.freedesktop.org/drm/intel/issues/505
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879
[i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937

Participating hosts (45 -> 39)
------------------------------

Additional (4): fi-hsw-peppy fi-kbl-7560u fi-skl-6600u fi-elk-e7500
Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ilk-650 fi-ctg-p8600 fi-whl-u fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7786 -> Patchwork_16200

CI-20190529: 20190529
CI_DRM_7786: 72275204176397fc718218335edabb840f520024 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5376: 5cf58d947a02379d2885d6dd4f8bb487cfc3eed2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16200: 8ebca6519f9a598ca616c5a62b1e91eb120a8236 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

8ebca6519f9a drm/i915: Nuke intel_atomic_lock/serialize_global_state()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16200/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx