Skip to contentSkip to conversation

KVM: arm/arm64: vgic: Drop the kvm_vgic_register_mmio_region()

PATCH In review Zenghui Yu 2 participants 2 messages Jan 19, 2020 KVM arm64

lore
Share & tools
lore

Zenghui Yu

author reviewer
#0 lore raw

PATCH 1/1 KVM: arm/arm64: vgic: Drop the kvm_vgic_register_mmio_region()

kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a ("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never used, and even never implemented. Remove it to avoid confusing readers.

---
 virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
 1 file changed, 5 deletions(-)
virt/kvm/arm/vgic/vgic-mmio.h +0 -5
index 836f418f1ee8..5af2aefad435 100644
@@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
 		.uaccess_write = uwr,					\
 	}
 
-int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
-				  struct vgic_register_region *reg_desc,
-				  struct vgic_io_device *region,
-				  int nr_irqs, bool offset_private);
-
 unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);
 
 void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,
Signature · 1 line
2.19.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Zenghui Yu

kvm_vgic_register_mmio_region() was introduced in commit 4493b1c4866a ("KVM: arm/arm64: vgic-new: Add MMIO handling framework") but never used, and even never implemented. Remove it to avoid confusing readers.

---

Quoted 20 lines
  virt/kvm/arm/vgic/vgic-mmio.h | 5 -----
  1 file changed, 5 deletions(-)
virt/kvm/arm/vgic/vgic-mmio.h +0 -5
index 836f418f1ee8..5af2aefad435 100644
@@ -98,11 +98,6 @@ extern struct kvm_io_device_ops kvm_io_gic_ops;
  		.uaccess_write = uwr,					\
  	}
 
-int kvm_vgic_register_mmio_region(struct kvm *kvm, struct kvm_vcpu *vcpu,
-				  struct vgic_register_region *reg_desc,
-				  struct vgic_io_device *region,
-				  int nr_irqs, bool offset_private);
-
  unsigned long vgic_data_mmio_bus_to_host(const void *val, unsigned int len);
 
  void vgic_data_host_to_mmio_bus(void *buf, unsigned int len,