Skip to contentSkip to conversation

i40e: remove unnecessary conversions to bool

PATCH In review Chen Zhou 2 participants 2 messages Jan 19, 2020 – Jan 23, 2020

Subsystems (3)
lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH 1/1 i40e: remove unnecessary conversions to bool

The conversions to bool are not needed, remove these.

---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +2 -2
index 33912cf..24cacfa 100644
@@ -1630,7 +1630,7 @@ static int i40e_config_rss_aq(struct i40e_vsi *vsi, const u8 *seed,
 		}
 	}
 	if (lut) {
-		bool pf_lut = vsi->type == I40E_VSI_MAIN ? true : false;
+		bool pf_lut = vsi->type == I40E_VSI_MAIN;
 
 		ret = i40e_aq_set_rss_lut(hw, vsi->id, pf_lut, lut, lut_size);
 		if (ret) {
@@ -11455,7 +11455,7 @@ static int i40e_get_rss_aq(struct i40e_vsi *vsi, const u8 *seed,
 	}
 
 	if (lut) {
-		bool pf_lut = vsi->type == I40E_VSI_MAIN ? true : false;
+		bool pf_lut = vsi->type == I40E_VSI_MAIN;
 
 		ret = i40e_aq_get_rss_lut(hw, vsi->id, pf_lut, lut, lut_size);
 		if (ret) {
Signature · 1 line
2.7.4
Tested-by on v1 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Chen Zhou
Sent: Sunday, January 19, 2020 5:22 AM
To: Kirsher, Jeffrey T <[email protected]>; davem at davemloft.net
Cc: chenzhou10 at huawei.com; netdev at vger.kernel.org; intel-wired- lan at lists.osuosl.org; linux-kernel at vger.kernel.org
Subject: [Intel-wired-lan] [PATCH -next] i40e: remove unnecessary conversions to bool

Quoted 6 lines

The conversions to bool are not needed, remove these.

---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)