Skip to contentSkip to conversation

staging: qlge: fix missing a blank line after declaration

PATCH In review Valery Ivanov 2 participants 2 messages Jan 19, 2020 – Jan 22, 2020

Subsystems (3)
Networking Network drivers Staging
lore
Share & tools
lore

Valery Ivanov

author
#0 lore raw

PATCH 1/1 staging: qlge: fix missing a blank line after declaration

This patch fixes "WARNING: Missing a blank lin after declarations" Issue found by checkpatch.pl

Signed-off-by Valery Ivanov <[email protected]>
---
 drivers/staging/qlge/qlge_ethtool.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/qlge/qlge_ethtool.c +3 -0
index 56d116d79e56..2872b7120e36 100644
@@ -412,6 +412,7 @@ static void ql_get_drvinfo(struct net_device *ndev,
 			   struct ethtool_drvinfo *drvinfo)
 {
 	struct ql_adapter *qdev = netdev_priv(ndev);
+
 	strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
 	strlcpy(drvinfo->version, qlge_driver_version,
 		sizeof(drvinfo->version));

@@ -703,12 +704,14 @@ static int ql_set_pauseparam(struct net_device *netdev,
 static u32 ql_get_msglevel(struct net_device *ndev)
 {
 	struct ql_adapter *qdev = netdev_priv(ndev);
+
 	return qdev->msg_enable;
 }
 
 static void ql_set_msglevel(struct net_device *ndev, u32 value)
 {
 	struct ql_adapter *qdev = netdev_priv(ndev);
+
 	qdev->msg_enable = value;
 }
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 25 lines · Valery Ivanov

This patch fixes "WARNING: Missing a blank lin after declarations" Issue found by checkpatch.pl

Signed-off-by Valery Ivanov <[email protected]>
---
 drivers/staging/qlge/qlge_ethtool.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/staging/qlge/qlge_ethtool.c +2 -0
index 56d116d79e56..2872b7120e36 100644
@@ -412,6 +412,7 @@ static void ql_get_drvinfo(struct net_device *ndev,
 			   struct ethtool_drvinfo *drvinfo)
 {
 	struct ql_adapter *qdev = netdev_priv(ndev);
+
 	strlcpy(drvinfo->driver, qlge_driver_name, sizeof(drvinfo->driver));
 	strlcpy(drvinfo->version, qlge_driver_version,
 		sizeof(drvinfo->version));

@@ -703,12 +704,14 @@ static int ql_set_pauseparam(struct net_device *netdev,
 static u32 ql_get_msglevel(struct net_device *ndev)
 {
 	struct ql_adapter *qdev = netdev_priv(ndev);
+

drivers/staging/qlge/qlge_ethtool.c static int ql_set_pauseparam(struct net_device *netdev, · line 717

Quoted 10 lines
drivers/staging/qlge/qlge_ethtool.c +1 -0
 	return qdev->msg_enable;
 }
 
 static void ql_set_msglevel(struct net_device *ndev, u32 value)
 {
 	struct ql_adapter *qdev = netdev_priv(ndev);
+
 	qdev->msg_enable = value;
 }

This fix is already in my tree, always be sure to work against linux-next for new development so you do not duplicate existing work.

thanks,

greg k-h