Skip to contentSkip to conversation

ARM: dts: stm32: Add Ethernet0 RMII pins A pinmux entry on stm32mp1

PATCH In review Marek Vasut 3 participants 12 messages Jan 19, 2020 – Mar 2, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/6 ARM: dts: stm32: Add Ethernet0 RMII pins A pinmux entry on stm32mp1

Add pinmux entry for ethernet0 RMII .

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: New patch

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 34 ++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +34 -0
index 0237d4ddaa92..f40f66a692a1 100644
@@ -162,6 +162,40 @@ pins1 {
 		};
 	};
 
+	ethernet0_rmii_pins_a: rmii-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G', 13, AF11)>, /* ETH1_RMII_TXD0 */
+				 <STM32_PINMUX('G', 14, AF11)>, /* ETH1_RMII_TXD1 */
+				 <STM32_PINMUX('B', 11, AF11)>, /* ETH1_RMII_TX_EN */
+				 <STM32_PINMUX('A', 1, AF0)>,   /* ETH1_RMII_REF_CLK */
+				 <STM32_PINMUX('A', 2, AF11)>,  /* ETH1_MDIO */
+				 <STM32_PINMUX('C', 1, AF11)>;  /* ETH1_MDC */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <2>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('C', 4, AF11)>,  /* ETH1_RMII_RXD0 */
+				 <STM32_PINMUX('C', 5, AF11)>,  /* ETH1_RMII_RXD1 */
+				 <STM32_PINMUX('A', 7, AF11)>;  /* ETH1_RMII_CRS_DV */
+			bias-disable;
+		};
+	};
+
+	ethernet0_rmii_pins_sleep_a: rmii-sleep-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G', 13, ANALOG)>, /* ETH1_RMII_TXD0 */
+				 <STM32_PINMUX('G', 14, ANALOG)>, /* ETH1_RMII_TXD1 */
+				 <STM32_PINMUX('B', 11, ANALOG)>, /* ETH1_RMII_TX_EN */
+				 <STM32_PINMUX('A', 2, ANALOG)>,  /* ETH1_MDIO */
+				 <STM32_PINMUX('C', 1, ANALOG)>,  /* ETH1_MDC */
+				 <STM32_PINMUX('C', 4, ANALOG)>,  /* ETH1_RMII_RXD0 */
+				 <STM32_PINMUX('C', 5, ANALOG)>,  /* ETH1_RMII_RXD1 */
+				 <STM32_PINMUX('A', 1, ANALOG)>,  /* ETH1_RMII_REF_CLK */
+				 <STM32_PINMUX('A', 7, ANALOG)>;  /* ETH1_RMII_CRS_DV */
+		};
+	};
+
 	fmc_pins_a: fmc-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('D', 4, AF12)>, /* FMC_NOE */
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH v2 2/6 ARM: dts: stm32: Add SAI2A pins B pinmux entry on stm32mp1

Add pinmux entry for SAI2A with alternative pin configuration. This is useful in combination with sai2b_pins_b e.g. for codecs like SGTL5000.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: New patch

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +20 -0
index f40f66a692a1..2927a812bb26 100644
@@ -719,6 +719,26 @@ pins {
 		};
 	};
 
+
+	sai2a_pins_b: sai2a-2 {
+		pins1 {
+			pinmux = <STM32_PINMUX('I', 6, AF10)>,	/* SAI2_SD_A */
+				 <STM32_PINMUX('I', 7, AF10)>,	/* SAI2_FS_A */
+				 <STM32_PINMUX('D', 13, AF10)>;	/* SAI2_SCK_A */
+			slew-rate = <0>;
+			drive-push-pull;
+			bias-disable;
+		};
+	};
+
+	sai2a_sleep_pins_b: sai2a-sleep-3 {
+		pins {
+			pinmux = <STM32_PINMUX('I', 6, ANALOG)>,  /* SAI2_SD_A */
+				 <STM32_PINMUX('I', 7, ANALOG)>,  /* SAI2_FS_A */
+				 <STM32_PINMUX('D', 13, ANALOG)>; /* SAI2_SCK_A */
+		};
+	};
+
 	sai2b_pins_a: sai2b-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('E', 12, AF10)>, /* SAI2_SCK_B */
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH v2 3/6 ARM: dts: stm32: Add USART3 pins A pinmux entry on stm32mp1

In reply to Marek Vasut

Add pinmux for USART3.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: New patch

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +13 -0
index 2927a812bb26..ac6fb333fee6 100644
@@ -1054,6 +1054,19 @@ pins {
 		};
 	};
 
+	usart3_pins_a: usart3-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('B', 10, AF7)>; /* USART3_TX */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('B', 12, AF8)>; /* USART3_RX */
+			bias-disable;
+		};
+	};
+
 	uart4_pins_a: uart4-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('G', 11, AF6)>; /* UART4_TX */
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH v2 4/6 ARM: dts: stm32: Add UART8 pins A pinmux entry on stm32mp1

In reply to Marek Vasut

Add pinmux for UART8.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: New patch

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +13 -0
index ac6fb333fee6..024a86e626b2 100644
@@ -1107,6 +1107,19 @@ pins2 {
 			bias-disable;
 		};
 	};
+
+	uart8_pins_a: uart8-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('E', 1, AF8)>; /* UART8_TX */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('E', 0, AF8)>; /* UART8_RX */
+			bias-disable;
+		};
+	};
 };
 
 &pinctrl_z {
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#4 lore raw

PATCH v2 5/6 ARM: dts: stm32: Add missing ETHCK clock to ethernet node on stm32mp1

In reply to Marek Vasut

Add missing 'eth-ck' clock to the ethernet node on stm32mp1. These clock are used to generate external clock signal for the PHY in case 'st,eth_ref_clk_sel' is specified.

Cc Alexandre Torgue <[email protected]>
Cc Christophe ROULLIER <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: Add stm32mp1 into the subject and commit message

---
 arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/stm32mp151.dtsi +2 -0
index fb41d0778b00..e0ecc5ee7d83 100644
@@ -1369,10 +1369,12 @@ ethernet0: ethernet@5800a000 {
 			clock-names = "stmmaceth",
 				      "mac-clk-tx",
 				      "mac-clk-rx",
+				      "eth-ck",
 				      "ethstp";
 			clocks = <&rcc ETHMAC>,
 				 <&rcc ETHTX>,
 				 <&rcc ETHRX>,
+				 <&rcc ETHCK_K>,
 				 <&rcc ETHSTP>;
 			st,syscon = <&syscfg 0x4>;
 			snps,mixed-burst;
Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw

PATCH v2 6/6 ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

In reply to Marek Vasut

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
- Sort DT alphanumerically
- Move all pincontrol entries into stm32mp15-pinctrl.dtsi

---
 arch/arm/boot/dts/Makefile                   |   1 +
 arch/arm/boot/dts/stm32mp157c-dhcom-pdk2.dts | 265 +++++++++++++
 arch/arm/boot/dts/stm32mp157c-dhcom-som.dtsi | 368 +++++++++++++++++++
 3 files changed, 634 insertions(+)
 create mode 100644 arch/arm/boot/dts/stm32mp157c-dhcom-pdk2.dts
 create mode 100644 arch/arm/boot/dts/stm32mp157c-dhcom-som.dtsi
arch/arm/boot/dts/Makefile +1 -0
index e006fef77499..c8a9f0c44f34 100644
@@ -1019,6 +1019,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
 	stm32h743i-disco.dtb \
 	stm32mp157a-avenger96.dtb \
 	stm32mp157a-dk1.dtb \
+	stm32mp157c-dhcom-pdk2.dtb \
 	stm32mp157c-dk2.dtb \
 	stm32mp157c-ed1.dtb \
 	stm32mp157c-ev1.dtb
arch/arm/boot/dts/stm32mp157c-dhcom-pdk2.dts new file +265 -0

265 lines not on this page · raw message

arch/arm/boot/dts/stm32mp157c-dhcom-som.dtsi new file +368 -0

368 lines not on this page · raw message

Signature · 7 lines
2.24.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#6 lore raw

Re: [PATCH V2 6/6] ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

Hi Marek

Quoted 10 lines · Marek Vasut

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
Quoted 6 lines

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
- Sort DT alphanumerically
- Move all pincontrol entries into stm32mp15-pinctrl.dtsi
---

Thanks to add a new STM32 board.

Series applied on stm32-next.

regards
Alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw

Re: [PATCH V2 6/6] ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 18 lines · Marek Vasut
Quoted 10 lines

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
Quoted 6 lines

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
     - Sort DT alphanumerically
     - Move all pincontrol entries into stm32mp15-pinctrl.dtsi
---

Quoted 3 lines

Thanks to add a new STM32 board.

Series applied on stm32-next.

How come these are not in next/master yet, is the branch not being merged into next regularly ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#8 lore raw

RE: [PATCH V2 6/6] ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

Hi Marek,

Quoted 26 lines

From: Marek Vasut <[email protected]>
Sent: dimanche 23 février 2020 15:38

Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 18 lines · Marek Vasut
Quoted 16 lines

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
     - Sort DT alphanumerically
     - Move all pincontrol entries into stm32mp15-pinctrl.dtsi
---

Quoted 6 lines
Quoted 3 lines

Thanks to add a new STM32 board.

Series applied on stm32-next.

How come these are not in next/master yet, is the branch not being merged into next regularly ?

This accepted patch is already in stm32-master, included in lasted pull request u-boot-stm32-20200214

SHA1 = 199537309ba53d294c31283064d63dafc995fbed

Merged in u-boot/master juste after v2020.04-rc2

Regards,

Patrick
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#9 lore raw

Re: [PATCH V2 6/6] ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

Quoted 1 line · Patrick DELAUNAY

Hi Marek,

Hi,

Quoted 30 lines
Quoted 30 lines

From: Marek Vasut <[email protected]>
Sent: dimanche 23 février 2020 15:38

Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 21 lines · Marek Vasut
Quoted 10 lines

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
Quoted 6 lines

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
     - Sort DT alphanumerically
     - Move all pincontrol entries into stm32mp15-pinctrl.dtsi
---

Thanks to add a new STM32 board.

Series applied on stm32-next.

Quoted 8 lines
Quoted 2 lines

How come these are not in next/master yet, is the branch not being merged into next regularly ?

This accepted patch is already in stm32-master, included in lasted pull request u-boot-stm32-20200214

SHA1 = 199537309ba53d294c31283064d63dafc995fbed

Merged in u-boot/master juste after v2020.04-rc2

This is a Linux kernel patchset though ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#10 lore raw

Re: [PATCH V2 6/6] ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

In reply to Marek Vasut

Hi Marek

Quoted 23 lines · Marek Vasut
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 18 lines · Marek Vasut
Quoted 16 lines

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
     - Sort DT alphanumerically
     - Move all pincontrol entries into stm32mp15-pinctrl.dtsi
---

Quoted 7 lines
Quoted 3 lines

Thanks to add a new STM32 board.

Series applied on stm32-next.

How come these are not in next/master yet, is the branch not being merged into next regularly ?

No this branch is not merged regularly in next/master. You'll get it in 5.7-rc1.

regards
Alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#11 lore raw

Re: [PATCH V2 6/6] ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board

Quoted 28 lines · Alexandre Torgue

Hi Marek

Quoted 25 lines · Marek Vasut
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

Quoted 20 lines · Marek Vasut
Quoted 10 lines

Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.

Cc Alexandre Torgue <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
Quoted 6 lines

To: [email protected]
---
V2: - Add stm32mp1 into the subject and commit message
      - Sort DT alphanumerically
      - Move all pincontrol entries into stm32mp15-pinctrl.dtsi
---

Thanks to add a new STM32 board.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Series applied on stm32-next.

How come these are not in next/master yet, is the branch not being merged into next regularly ?

No this branch is not merged regularly in next/master. You'll get it in 5.7-rc1.

Can we improve on that ? (and thus improve on testing) ?

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel