Skip to contentSkip to conversation

arm: zynq: zybo z7: fix MIO init issue

PATCH New Luis Araneda 2 participants 2 messages Jan 20, 2020 Arm/Zynq architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: zynq: zybo z7: fix MIO init issue

From: Milan Obuch <[email protected]>

The board has two push button connected to MIO pins 50 and 51, which have a pull-down resistor and are connected to 1.8V when pressed.

These two pins are wrongly initialized with internal pull-up enabled so they are reported as 1 all the time with no change when pressed.

Disable the internal pull-up to fix the issue.

---

This changes were originally sent by Milan Obuch using a diff format. As he didn't know how to properly send git patches to the mailing list, I converted them to a git commit, rephrased the commit message and added the Signed-off-by tags.

Milan Obuch then review and approved the current state of the patch.

Tested on a zybo z7-20 board by me

 board/xilinx/zynq/zynq-zybo-z7/ps7_init_gpl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/xilinx/zynq/zynq-zybo-z7/ps7_init_gpl.c +2 -2
index 7c6bc9fa3f..a376ba574e 100644
@@ -219,8 +219,8 @@ static unsigned long ps7_mio_init_data_3_0[] = {
 	EMIT_MASKWRITE(0xF80007BC, 0x00003F01U, 0x00001201U),
 	EMIT_MASKWRITE(0xF80007C0, 0x00003FFFU, 0x000012E0U),
 	EMIT_MASKWRITE(0xF80007C4, 0x00003FFFU, 0x000012E1U),
-	EMIT_MASKWRITE(0xF80007C8, 0x00003FFFU, 0x00001200U),
-	EMIT_MASKWRITE(0xF80007CC, 0x00003FFFU, 0x00001200U),
+	EMIT_MASKWRITE(0xF80007C8, 0x00003FFFU, 0x00000200U),
+	EMIT_MASKWRITE(0xF80007CC, 0x00003FFFU, 0x00000200U),
 	EMIT_MASKWRITE(0xF80007D0, 0x00003FFFU, 0x00001280U),
 	EMIT_MASKWRITE(0xF80007D4, 0x00003FFFU, 0x00001280U),
 	EMIT_MASKWRITE(0xF8000830, 0x003F003FU, 0x002F0037U),
Signature · 1 line
2.25.0
Applied
#1 lore raw

PATCH 1/1 arm: zynq: zybo z7: fix MIO init issue

Quoted 34 lines · Luis Araneda

From: Milan Obuch <[email protected]>

The board has two push button connected to MIO pins 50 and 51, which have a pull-down resistor and are connected to 1.8V when pressed.

These two pins are wrongly initialized with internal pull-up enabled so they are reported as 1 all the time with no change when pressed.

Disable the internal pull-up to fix the issue.

---

This changes were originally sent by Milan Obuch using a diff format. As he didn't know how to properly send git patches to the mailing list, I converted them to a git commit, rephrased the commit message and added the Signed-off-by tags.

Milan Obuch then review and approved the current state of the patch.

Tested on a zybo z7-20 board by me

 board/xilinx/zynq/zynq-zybo-z7/ps7_init_gpl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/xilinx/zynq/zynq-zybo-z7/ps7_init_gpl.c +0 -0
index 7c6bc9fa3f..a376ba574e 100644

board/xilinx/zynq/zynq-zybo-z7/ps7_init_gpl.c static unsigned long ps7_mio_init_data_3_0[] = { · line 226

Quoted 10 lines
board/xilinx/zynq/zynq-zybo-z7/ps7_init_gpl.c +2 -2
@@ -219,8 +219,8 @@ static unsigned long ps7_mio_init_data_3_0[] = {
 	EMIT_MASKWRITE(0xF80007BC, 0x00003F01U, 0x00001201U),
 	EMIT_MASKWRITE(0xF80007C0, 0x00003FFFU, 0x000012E0U),
 	EMIT_MASKWRITE(0xF80007C4, 0x00003FFFU, 0x000012E1U),
-	EMIT_MASKWRITE(0xF80007C8, 0x00003FFFU, 0x00001200U),
-	EMIT_MASKWRITE(0xF80007CC, 0x00003FFFU, 0x00001200U),
+	EMIT_MASKWRITE(0xF80007C8, 0x00003FFFU, 0x00000200U),
+	EMIT_MASKWRITE(0xF80007CC, 0x00003FFFU, 0x00000200U),
 	EMIT_MASKWRITE(0xF80007D0, 0x00003FFFU, 0x00001280U),
 	EMIT_MASKWRITE(0xF80007D4, 0x00003FFFU, 0x00001280U),
 	EMIT_MASKWRITE(0xF8000830, 0x003F003FU, 0x002F0037U),

Applied.
M

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200120/714b83cc/attachment.sig>