Skip to contentSkip to conversation

usb: typec: tcpci: mask event interrupts when remove driver

PATCH In review Jun Li 3 participants 3 messages Jan 20, 2020

Subsystems (3)
lore
Share & tools
lore

Jun Li

author
#0 lore raw

PATCH v3 1/1 usb: typec: tcpci: mask event interrupts when remove driver

This is to prevent any possible events generated while unregister tpcm port.

Fixes 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
---
 drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/usb/typec/tcpm/tcpci.c +6 -0
index c1f7073..dfae41f 100644
@@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
 static int tcpci_remove(struct i2c_client *client)
 {
 	struct tcpci_chip *chip = i2c_get_clientdata(client);
+	int err;
+
+	/* Disable chip interrupts before unregistering port */
+	err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
+	if (err < 0)
+		return err;
 
 	tcpci_unregister_port(chip->tcpci);
 
Signature · 1 line
2.7.4
Reviewed-by on v3 1/1
#1 lore raw
Quoted 5 lines · Jun Li

This is to prevent any possible events generated while unregister tpcm port.

Fixes 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
Quoted 22 lines
---
  drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/usb/typec/tcpm/tcpci.c +6 -0
index c1f7073..dfae41f 100644
@@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
  static int tcpci_remove(struct i2c_client *client)
  {
  	struct tcpci_chip *chip = i2c_get_clientdata(client);
+	int err;
+
+	/* Disable chip interrupts before unregistering port */
+	err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
+	if (err < 0)
+		return err;
 
  	tcpci_unregister_port(chip->tcpci);
 
maintainer Reviewed-by on v3 1/1
#2 lore raw
In reply to Jun Li
Quoted 5 lines · Jun Li

This is to prevent any possible events generated while unregister tpcm port.

Fixes 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
Quoted 23 lines
---
 drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/usb/typec/tcpm/tcpci.c +6 -0
index c1f7073..dfae41f 100644
@@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
 static int tcpci_remove(struct i2c_client *client)
 {
 	struct tcpci_chip *chip = i2c_get_clientdata(client);
+	int err;
+
+	/* Disable chip interrupts before unregistering port */
+	err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
+	if (err < 0)
+		return err;
 
 	tcpci_unregister_port(chip->tcpci);
 
Signature · 1 line
2.7.4
Signature · 1 line
heikki