tcp_bbr: improve arithmetic division in bbr_update_bw()
Subsystems (3)
PATCH 1/1 tcp_bbr: improve arithmetic division in bbr_update_bw()
do_div() does a 64-by-32 division. Use div64_long() instead of it if the divisor is long, to avoid truncation to 32-bit. And as a nice side effect also cleans up the function a bit.
Signed-off-by Wen Yang <[email protected]>
Cc Eric Dumazet <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Alexey Kuznetsov <[email protected]>
Cc Hideaki YOSHIFUJI <[email protected]>
--- net/ipv4/tcp_bbr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/ipv4/tcp_bbr.c +1 -2
@@ -779,8 +779,7 @@ static void bbr_update_bw(struct sock *sk, const struct rate_sample *rs)* bandwidth sample. Delivered is in packets and interval_us in uS and * ratio will be <<1 for most connections. So delivered is first scaled. */ - bw = (u64 )rs->delivered *BW_UNIT ; -do_div (bw, rs->interval_us); + bw =div64_long ((u64 )rs->delivered *BW_UNIT , rs->interval_us);/* If this sample is application-limited, it is likely to have a very * low delivered count that represents application behavior rather than
Signature · 1 line
2.23.0
Quoted 4 lines · Wen Yang
do_div()does a 64-by-32 division. Usediv64_long()instead of it if the divisor is long, to avoid truncation to 32-bit. And as a nice side effect also cleans up the function a bit.
Signed-off-by Eric Dumazet <[email protected]>
Thanks !
From: Wen Yang <[email protected]>
Date: Mon, 20 Jan 2020 18:04:56 +0800
Quoted 5 lines
do_div()does a 64-by-32 division. Usediv64_long()instead of it if the divisor is long, to avoid truncation to 32-bit. And as a nice side effect also cleans up the function a bit.Signed-off-by Wen Yang <[email protected]>
Applied, thank you.