Skip to contentSkip to conversation

gpiolib: remove unnecessary argument from set_config call

PATCH In review Kent Gibson 2 participants 4 messages Jan 20, 2020 – Feb 4, 2020 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: remove unnecessary argument from set_config call

Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.

Fixes 2148ad7790ea ("gpiolib: add support for disabling line bias")

---

No argument is expected by pinctrl, so removing it should be harmless.

 drivers/gpio/gpiolib.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpio/gpiolib.c +0 -1
index 78a16e42f222..93d12fc9f82d 100644
@@ -3057,7 +3057,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned offset,
 	unsigned arg;
 
 	switch (mode) {
-	case PIN_CONFIG_BIAS_DISABLE:
 	case PIN_CONFIG_BIAS_PULL_DOWN:
 	case PIN_CONFIG_BIAS_PULL_UP:
 		arg = 1;
Signature · 1 line
2.24.1
#1 lore raw

pon., 20 sty 2020 o 11:46 Kent Gibson <[email protected]> napisał(a):

Quoted 9 lines

Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.

Fixes 2148ad7790ea ("gpiolib: add support for disabling line bias")

---

No argument is expected by pinctrl, so removing it should be harmless.

This doesn't really fix any bug, does it? If not, then I'll just take it for v5.7 after the merge window.

Bart

#2 lore raw
Quoted 8 lines · Bartosz Golaszewski

pon., 20 sty 2020 o 11:46 Kent Gibson <[email protected]> napisał(a):

Quoted 7 lines

Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.

Fixes 2148ad7790ea ("gpiolib: add support for disabling line bias")

---

Quoted 6 lines
Quoted 2 lines

No argument is expected by pinctrl, so removing it should be harmless.

This doesn't really fix any bug, does it? If not, then I'll just take it for v5.7 after the merge window.

This is just fixing what I suspect was a cut-and-paste error on my part that wasn't picked up during review - until I had a closer look following Geert and Andy's recent comments on some of your proposed changes. So it is just a tidy up.

It could only a problem if a pinctrl is making use of the unnecessary argument, and there are no such pinctrls that I am aware of.

Merge it in whenever it is convenient.

Cheers,
Kent.

#3 lore raw

śr., 29 sty 2020 o 13:33 Kent Gibson <[email protected]> napisał(a):

Quoted 22 lines · Bartosz Golaszewski
Quoted 8 lines

pon., 20 sty 2020 o 11:46 Kent Gibson <[email protected]> napisał(a):

Quoted 7 lines

Remove unnecessary argument when setting PIN_CONFIG_BIAS_DISABLE.

Fixes 2148ad7790ea ("gpiolib: add support for disabling line bias")

---

Quoted 6 lines
Quoted 2 lines

No argument is expected by pinctrl, so removing it should be harmless.

This doesn't really fix any bug, does it? If not, then I'll just take it for v5.7 after the merge window.

This is just fixing what I suspect was a cut-and-paste error on my part that wasn't picked up during review - until I had a closer look following Geert and Andy's recent comments on some of your proposed changes. So it is just a tidy up.

Quoted 7 lines

It could only a problem if a pinctrl is making use of the unnecessary argument, and there are no such pinctrls that I am aware of.

Merge it in whenever it is convenient.

Cheers,
Kent.

I'm picking up various early fixes for v5.6 so I'll go ahead and apply it while at it.

Bart