Skip to contentSkip to conversation

net: hns3: replace snprintf with scnprintf in hns3_dbg_cmd_read

PATCH Superseded Chen Zhou 2 participants 2 messages Jan 20, 2020 – Jan 21, 2020

Subsystems (4)
lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH v2 1/1 net: hns3: replace snprintf with scnprintf in hns3_dbg_cmd_read

The return value of snprintf may be greater than the size of HNS3_DBG_READ_LEN, use scnprintf instead in hns3_dbg_cmd_read.

---

changes in v2:
- fix checkpatch style problem.

---
 drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c +2 -2
index 6b328a2..92ee1f5 100644
@@ -297,8 +297,8 @@ static ssize_t hns3_dbg_cmd_read(struct file *filp, char __user *buffer,
 	if (!buf)
 		return -ENOMEM;
 
-	len = snprintf(buf, HNS3_DBG_READ_LEN, "%s\n",
-		       "Please echo help to cmd to get help information");
+	len = scnprintf(buf, HNS3_DBG_READ_LEN, "%s\n",
+			"Please echo help to cmd to get help information");
 	uncopy_bytes = copy_to_user(buffer, buf, len);
 
 	kfree(buf);
Signature · 1 line
2.7.4
maintainer
#1 lore raw

From: Chen Zhou <[email protected]>
Date: Mon, 20 Jan 2020 20:49:43 +0800

Quoted 8 lines

The return value of snprintf may be greater than the size of HNS3_DBG_READ_LEN, use scnprintf instead in hns3_dbg_cmd_read.

---

changes in v2:
- fix checkpatch style problem.

Both conversion patches applied, thank you.