net: hns3: replace snprintf with scnprintf in hns3_dbg_cmd_read
Subsystems (4)
PATCH v2 1/1 net: hns3: replace snprintf with scnprintf in hns3_dbg_cmd_read
The return value of snprintf may be greater than the size of HNS3_DBG_READ_LEN, use scnprintf instead in hns3_dbg_cmd_read.
Signed-off-by Chen Zhou <[email protected]>
---
changes in v2:
- fix checkpatch style problem.
--- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c +2 -2
@@ -297,8 +297,8 @@ static ssize_t hns3_dbg_cmd_read(struct file *filp, char __user *buffer,if (!buf)return -ENOMEM ; - len =snprintf (buf,HNS3_DBG_READ_LEN ,"%s\n" , -"Please echo help to cmd to get help information" ); + len =scnprintf (buf,HNS3_DBG_READ_LEN ,"%s\n" , +"Please echo help to cmd to get help information" ); uncopy_bytes =copy_to_user (buffer, buf, len);kfree (buf);
Signature · 1 line
2.7.4
David Miller
maintainerFrom: Chen Zhou <[email protected]>
Date: Mon, 20 Jan 2020 20:49:43 +0800
Quoted 8 lines
The return value of snprintf may be greater than the size of
HNS3_DBG_READ_LEN, use scnprintf instead inhns3_dbg_cmd_read.Signed-off-by Chen Zhou <[email protected]>---
changes in v2:
- fix checkpatch style problem.
Both conversion patches applied, thank you.