Skip to contentSkip to conversation

mx7dsabre: Fix dm probe pmic

PATCH New Joris Offouga 3 participants 3 messages Jan 16, 2020 – Jan 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx7dsabre: Fix dm probe pmic

With commit mx7dsabre: Enable DM_ETH 0d52bab4

Device Tree has been update and change pfuze3000 node

---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx7dsabresd/mx7dsabresd.c +1 -1
index 835eed3316..41c620795c 100644
@@ -264,7 +264,7 @@ int power_init_board(void)
 	struct udevice *dev;
 	int ret, dev_id, rev_id;
 
-	ret = pmic_get("pfuze3000 at 08", &dev);
+	ret = pmic_get("pfuze3000 at 8", &dev);
 	if (ret == -ENODEV)
 		return 0;
 	if (ret != 0)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 mx7dsabre: Fix dm probe pmic

Hi Joris,

Quoted 2 lines · Joris Offouga

With commit mx7dsabre: Enable DM_ETH 0d52bab4

Please reference commit like this:

With commit 0d52bab4621 ("mx7dsabre: Enable DM_ETH")

BTW, it would be better if this commit were split in two:

- One for syncing the dts
- Other one for converting to DM_ETH

Quoted 13 lines

Device Tree has been update and change pfuze3000 node

---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/mx7dsabresd/mx7dsabresd.c +0 -0
index 835eed3316..41c620795c 100644

board/freescale/mx7dsabresd/mx7dsabresd.c int power_init_board(void) · line 267

Quoted 5 lines
board/freescale/mx7dsabresd/mx7dsabresd.c +1 -1
@@ -264,7 +264,7 @@ int power_init_board(void)
        struct udevice *dev;
        int ret, dev_id, rev_id;
 
-       ret = pmic_get("pfuze3000 at 08", &dev);
+       ret = pmic_get("pfuze3000 at 8", &dev);

Thanks for the fix:

#2 lore raw

PATCH 1/1 mx7dsabre: Fix dm probe pmic

In reply to Joris Offouga
Quoted 4 lines

With commit mx7dsabre: Enable DM_ETH 0d52bab4 Device Tree has been update and change pfuze3000 node

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================