gdb: add PACKAGECONFIG for xz (lzma) compression support
PATCH 1/1 gdb: add PACKAGECONFIG for xz (lzma) compression support
Similar to elfutils, when xz support is built into gdb it will be able to read xz-compressed ELF sections containing debuginfo. This is used by the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
--- meta/recipes-devtools/gdb/gdb-common.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-common.inc +2 -1
@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}" EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \ --with-curses --disable-multilib --disable-sim \ - --without-lzma --without-guile \ + --without-guile \ ${GDBPROPREFIX} ${EXPAT} \ ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \ --disable-rpath \
@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" # ncurses is already a hard DEPENDS, but would be added here if it weren't PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma" GDBPROPREFIX = "--program-prefix=''"
Signature · 1 line
2.21.0
✗ patchtest: failure for gdb: add PACKAGECONFIG for xz (lzma) compression support
== Series Details ==
Series: gdb: add PACKAGECONFIG for xz (lzma) compression support
Revision: 1
URL : https://patchwork.openembedded.org/series/22174/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Patch gdb: add PACKAGECONFIG for xz (lzma) compression support Issue Patch is missing Signed-off-by [test_signed_off_by_presence] Suggested fix Sign off the patch (either manually or with "git commit --amend -s")
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
Quoted 23 lines · Dan Callaghan
Similar to elfutils, when xz support is built into gdb it will be able to read xz-compressed ELF sections containing debuginfo. This is used by the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
--- meta/recipes-devtools/gdb/gdb-common.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-devtools/gdb/gdb-common.inc +1
-1@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}" EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \ --with-curses --disable-multilib --disable-sim \ - --without-lzma --without-guile \ + --without-guile \ ${GDBPROPREFIX} ${EXPAT} \ ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \ --disable-rpath \
meta/recipes-devtools/gdb/gdb-common.inc PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python · line 42
Quoted 6 lines
meta/recipes-devtools/gdb/gdb-common.inc +1
-0@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" # ncurses is already a hard DEPENDS, but would be added here if it weren't PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma" GDBPROPREFIX = "--program-prefix=''"
Is there an extra DEPENDS needed when enabling this?
Cheers,
Richard
Excerpts from Richard Purdie's message of 2020-01-21 00:04:53 +00:00:
Quoted 1 line
Is there an extra DEPENDS needed when enabling this?
Oops, yes it should really pull in xz. I missed this because xz is already a transitive dependency through something else. Will post a new patch.
Signature · 3 lines
Dan Callaghan <[email protected]> Software Engineer Opengear <https://opengear.com/>
PATCH v2 1/1 gdb: add PACKAGECONFIG for xz (lzma) compression support
In reply to Dan CallaghanSimilar to elfutils, when xz support is built into gdb it will be able to read xz-compressed ELF sections containing debuginfo. This is used by the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
--- meta/recipes-devtools/gdb/gdb-common.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-devtools/gdb/gdb-common.inc +2 -1
@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}" EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \ --with-curses --disable-multilib --disable-sim \ - --without-lzma --without-guile \ + --without-guile \ ${GDBPROPREFIX} ${EXPAT} \ ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \ --disable-rpath \
@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" # ncurses is already a hard DEPENDS, but would be added here if it weren't PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz" GDBPROPREFIX = "--program-prefix=''"
Signature · 1 line
2.21.0
Bump... I just noticed this patch was never applied. I have been carrying it locally all year and it still applies cleanly. Any issues preventing it from being applied?
Excerpts from Dan Callaghan's message of 2020-01-21 11:24:12 +10:00:
Quoted 31 lines
Similar to elfutils, when xz support is built into gdb it will be able to read xz-compressed ELF sections containing debuginfo. This is used by the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.htmlSigned-off-by Dan Callaghan <[email protected]>--- meta/recipes-devtools/gdb/gdb-common.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-devtools/gdb/gdb-common.inc +2
-1@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}" EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \ --with-curses --disable-multilib --disable-sim \ - --without-lzma --without-guile \ + --without-guile \ ${GDBPROPREFIX} ${EXPAT} \ ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \ --disable-rpath \@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" # ncurses is already a hard DEPENDS, but would be added here if it weren't PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz" GDBPROPREFIX = "--program-prefix=''"
Signature · 3 lines
Dan Callaghan <[email protected]> Software Engineer Opengear <https://opengear.com/>
Quoted 5 lines · Dan Callaghan via lists.openembedded.org
Bump... I just noticed this patch was never applied. I have been carrying it locally all year and it still applies cleanly. Any issues preventing it from being applied?
thanks, I think this patch is fine.
Quoted 40 lines
Excerpts from Dan Callaghan's message of 2020-01-21 11:24:12 +10:00:
Quoted 24 lines
Similar to elfutils, when xz support is built into gdb it will be able to read xz-compressed ELF sections containing debuginfo. This is used by the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.htmlSigned-off-by Dan Callaghan <[email protected]>--- meta/recipes-devtools/gdb/gdb-common.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-devtools/gdb/gdb-common.inc +1
-1@@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}" EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \ --with-curses --disable-multilib --disable-sim \ - --without-lzma --without-guile \ + --without-guile \ ${GDBPROPREFIX} ${EXPAT} \ ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \ --disable-rpath \meta/recipes-devtools/gdb/gdb-common.inc PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python · line 43
Quoted 7 lines
meta/recipes-devtools/gdb/gdb-common.inc +1
-0@@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace" # ncurses is already a hard DEPENDS, but would be added here if it weren't PACKAGECONFIG[tui] = "--enable-tui,--disable-tui" +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz" GDBPROPREFIX = "--program-prefix=''"--
Dan Callaghan <[email protected]>
Software Engineer
Opengear <https://opengear.com/>