Skip to contentSkip to conversation

net/ice: fix FDIR PASSTHRU issue

PATCH Applied Yahui Cao 3 participants 3 messages Jan 21, 2020 – Feb 10, 2020 Network drivers

lore
Share & tools
lore

Yahui Cao

author
#0 lore raw

PATCH 1/1 net/ice: fix FDIR PASSTHRU issue

The original PASSTHRU implementation is forwarding to queue 0. The corrected implementation is forwarding to the next stage filter.

Fixes f5cafa961fae ("net/ice: add flow director create and destroy")
---
 drivers/net/ice/base/ice_fdir.c   | 9 ++++++++-
 drivers/net/ice/ice_fdir_filter.c | 3 +--
 2 files changed, 9 insertions(+), 3 deletions(-)
drivers/net/ice/base/ice_fdir.c +8 -1
index 87fa0afba..49b1f06f1 100644
@@ -401,6 +401,10 @@ ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input,
 	if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DROP_PKT) {
 		fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_YES;
 		fdir_fltr_ctx.qindex = 0;
+	} else if (input->dest_ctl ==
+			ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER) {
+		fdir_fltr_ctx.drop = ICE_FXD_FLTR_QW0_DROP_NO;
+		fdir_fltr_ctx.qindex = 0;
 	} else {
 		if (input->dest_ctl ==
 		    ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QGROUP)
@@ -412,7 +416,10 @@ ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input,
 	fdir_fltr_ctx.cnt_index = input->cnt_index;
 	fdir_fltr_ctx.fd_vsi = ice_get_hw_vsi_num(hw, input->dest_vsi);
 	fdir_fltr_ctx.evict_ena = ICE_FXD_FLTR_QW0_EVICT_ENA_FALSE;
-	fdir_fltr_ctx.toq_prio = 3;
+	if (input->dest_ctl == ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER)
+		fdir_fltr_ctx.toq_prio = 0;
+	else
+		fdir_fltr_ctx.toq_prio = 3;
 	fdir_fltr_ctx.pcmd = (add) ? ICE_FXD_FLTR_QW1_PCMD_ADD :
 		ICE_FXD_FLTR_QW1_PCMD_REMOVE;
 	fdir_fltr_ctx.swap = ICE_FXD_FLTR_QW1_SWAP_NOT_SET;
drivers/net/ice/ice_fdir_filter.c +1 -2
index fa8707455..1b783a9f8 100644
@@ -1488,8 +1488,7 @@ ice_fdir_parse_action(struct ice_adapter *ad,
 			dest_num++;
 
 			filter->input.dest_ctl =
-				ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_QINDEX;
-			filter->input.q_index = 0;
+				ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
 			break;
 		case RTE_FLOW_ACTION_TYPE_RSS:
 			dest_num++;
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines

-----Original Message-----
From: Cao, Yahui <[email protected]>
Sent: Tuesday, January 21, 2020 10:26 AM
To: Yang, Qiming <[email protected]>; Lu, Wenzhuo <[email protected]>
Cc: [email protected]; [email protected]; Zhang, Qi Z <[email protected]>; Cao, Yahui <[email protected]>; Ye, Xiaolong <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/ice: fix FDIR PASSTHRU issue

Quoted 7 lines

The original PASSTHRU implementation is forwarding to queue 0. The corrected implementation is forwarding to the next stage filter.

Fixes f5cafa961fae ("net/ice: add flow director create and destroy")
Applied
#2 lore raw
Quoted 15 lines · Qi Z
Quoted 15 lines

-----Original Message-----
From: Cao, Yahui <[email protected]>
Sent: Tuesday, January 21, 2020 10:26 AM
To: Yang, Qiming <[email protected]>; Lu, Wenzhuo <[email protected]>
Cc: [email protected]; [email protected]; Zhang, Qi Z <[email protected]>; Cao, Yahui <[email protected]>; Ye, Xiaolong <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/ice: fix FDIR PASSTHRU issue

The original PASSTHRU implementation is forwarding to queue 0. The corrected implementation is forwarding to the next stage filter.

Quoted 7 lines
Quoted 4 lines
Fixes f5cafa961fae ("net/ice: add flow director create and destroy")

Applied to dpdk-next-net-intel, Thanks.