Skip to contentSkip to conversation

configure.ac: simplify AC_CHECK_FUNCS statements

PATCH In review Lev Stipakov 3 participants 3 messages Jan 21, 2020 – Feb 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure.ac: simplify AC_CHECK_FUNCS statements

From: Lev Stipakov <[email protected]...>

AC_CHECK_FUNCS checks availability of each function in argument list and defines HAVE_function macro. AC_CHECK_FUNC takes single function as an argument and doesn't automatically define any macros.

When we check for availability of a single function and define own macro, it is enough to use AC_CHECK_FUNC.

---
 configure.ac | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
configure.ac +6 -6
index 98fd39ce..3c057295 100644
@@ -906,17 +906,17 @@ if test "${with_crypto_library}" = "openssl"; then
 	fi
 
 	have_crypto_aead_modes="yes"
-	AC_CHECK_FUNCS(
+	AC_CHECK_FUNC(
 		[EVP_aes_256_gcm],
 		,
-		[have_crypto_aead_modes="no"; break]
+		[have_crypto_aead_modes="no"]
 	)
 
 	have_export_keying_material="yes"
-	AC_CHECK_FUNCS(
+	AC_CHECK_FUNC(
 		[SSL_export_keying_material],
 		,
-		[have_export_keying_material="no"; break]
+		[have_export_keying_material="no"]
 	)
 
 	AC_CHECK_FUNCS(
@@ -1018,10 +1018,10 @@ elif test "${with_crypto_library}" = "mbedtls"; then
 	)
 
 	have_export_keying_material="yes"
-	AC_CHECK_FUNCS(
+	AC_CHECK_FUNC(
 		[mbedtls_ssl_conf_export_keys_ext_cb],
 		,
-		[have_export_keying_material="no"; break]
+		[have_export_keying_material="no"]
 	)
 
 	CFLAGS="${saved_CFLAGS}"
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Am 21.01.20 um 09:08 schrieb Lev Stipakov:

Quoted 9 lines

From: Lev Stipakov <[email protected]...>

AC_CHECK_FUNCS checks availability of each function in argument list and defines HAVE_function macro. AC_CHECK_FUNC takes single function as an argument and doesn't automatically define any macros.

When we check for availability of a single function and define own macro, it is enough to use AC_CHECK_FUNC.

Looks good to me

#2 lore raw
In reply to Lev Stipakov

Your patch has been applied to the master branch.

Very lighty tested with FreeBSD and Linux builds with mbedtls/openssl "it builds and tests" (no idea if it produces the right result for the relevant library versions).

commit 91d84530d7eb24718b99478ebac6ba40b0615b28

Author: Lev Stipakov
Date:   Tue Jan 21 10:08:28 2020 +0200
     configure.ac: simplify AC_CHECK_FUNCS statements

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg19333.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering