Skip to contentSkip to conversation

sound/soc/soc-pcm.c:951 soc_pcm_hw_free() warn: inconsistent returns 'rtd->card->pcm_mutex'.

PATCH New Dan Carpenter 1 participant 1 message Jan 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 94/416 sound/soc/soc-pcm.c:951 soc_pcm_hw_free() warn: inconsistent returns 'rtd->card->pcm_mutex'.

tree:   https://github.com/morimoto/linux fw-cleanup-2020-01-10-v3
head:   109289147a86ef6391233055b9c74e475deaee0e
commit: 4d2384aa3e976e7fd983461a0ef97c9bb6c855b9 [94/416] ASoC: soc-pcm: remove soc_pcm_components_hw_free()

If you fix the issue, kindly add following tag

smatch warnings:
sound/soc/soc-pcm.c:951 soc_pcm_hw_free() warn: inconsistent returns 'rtd->card->pcm_mutex'.

# https://github.com/morimoto/linux/commit/4d2384aa3e976e7fd983461a0ef97c9bb6c855b9
git remote add morimoto-linux https://github.com/morimoto/linux
git remote update morimoto-linux
git checkout 4d2384aa3e976e7fd983461a0ef97c9bb6c855b9
vim +951 sound/soc/soc-pcm.c

53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  913  static int soc_pcm_hw_free(struct snd_pcm_substream *substream)
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  914  {
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  915  	struct snd_soc_pcm_runtime *rtd = substream->private_data;
4d2384aa3e976e Kuninori Morimoto 2019-07-24  916  	struct snd_soc_component *component;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  917  	struct snd_soc_dai *dai;
4d2384aa3e976e Kuninori Morimoto 2019-07-24  918  	int i, ret;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  919  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  920  	mutex_lock_nested(&rtd->card->pcm_mutex, rtd->card->pcm_subclass);
                                                        ^^^^^^^^^^^^^^^^^

Lock

53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  921  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  922  	/* clear the corresponding DAIs parameters when going to be inactive */
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  923  	for_each_rtd_dais(rtd, i, dai) {
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  924  		if (dai->active == 1) {
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  925  			dai->rate = 0;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  926  			dai->channels = 0;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  927  			dai->sample_bits = 0;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  928  			snd_soc_dai_digital_mute(dai, 1, substream->stream);
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  929  		}
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  930  	}
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  931  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  932  	/* free any machine hw params */
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  933  	soc_rtd_hw_free(rtd, substream);
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  934  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  935  	/* free any component resources */
4d2384aa3e976e Kuninori Morimoto 2019-07-24  936  	ret = 0;
4d2384aa3e976e Kuninori Morimoto 2019-07-24  937  	for_each_rtd_components(rtd, i, component)
4d2384aa3e976e Kuninori Morimoto 2019-07-24  938  		ret |= snd_soc_component_hw_free(component, substream);
4d2384aa3e976e Kuninori Morimoto 2019-07-24  939  	if (ret < 0)
4d2384aa3e976e Kuninori Morimoto 2019-07-24  940  		return ret;
                                                                ^^^^^^^^^^

Missing unlock

53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  941  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  942  	/* now free hw params for the DAIs  */
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  943  	for_each_rtd_dais(rtd, i, dai) {
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  944  		if (!snd_soc_dai_stream_valid(dai, substream->stream))
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  945  			continue;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  946  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  947  		snd_soc_dai_hw_free(dai, substream);
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  948  	}
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  949  
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02  950  	mutex_unlock(&rtd->card->pcm_mutex);
                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

53d7e3a8e5b89d Kuninori Morimoto 2019-10-02 @951 return 0;
53d7e3a8e5b89d Kuninori Morimoto 2019-10-02 952 }

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation