lib/test_bitmap: Make use of EXP2_IN_BITS
Subsystems (2)
PATCH 1/1 lib/test_bitmap: Make use of EXP2_IN_BITS
The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper") introduced some new test cases to the test_bitmap.c module. Among these it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.
Reported-by Alex Shi <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
--- lib/test_bitmap.c | 2 ++ 1 file changed, 2 insertions(+)
lib/test_bitmap.c +2 -0
@@ -278,6 +278,8 @@ static void __init test_replace(void)unsigned int nlongs =DIV_ROUND_UP (nbits,BITS_PER_LONG );DECLARE_BITMAP (bmap,1024 ); +BUILD_BUG_ON (EXP2_IN_BITS < nbits *2 ); +bitmap_zero (bmap,1024 );bitmap_replace (bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);expect_eq_bitmap (bmap, exp3_0_1, nbits);
Signature · 1 line
2.24.1
Quoted 16 lines · Andy Shevchenko
The commit
30544ed5de43("lib/bitmap: introducebitmap_replace()helper") introduced some new test cases to thetest_bitmap.cmodule. Among these it also introduced an (unused) definition. Let's make use ofEXP2_IN_BITS.Reported-by Alex Shi <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- lib/test_bitmap.c | 2 ++ 1 file changed, 2 insertions(+)lib/test_bitmap.c +0
-0
lib/test_bitmap.c static void __init test_replace(void) · line 285
Quoted 8 lines
lib/test_bitmap.c +2
-0@@ -278,6 +278,8 @@ static void __init test_replace(void)unsigned int nlongs =DIV_ROUND_UP (nbits,BITS_PER_LONG );DECLARE_BITMAP (bmap,1024 ); +BUILD_BUG_ON (EXP2_IN_BITS < nbits *2 ); +bitmap_zero (bmap,1024 );bitmap_replace (bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);expect_eq_bitmap (bmap, exp3_0_1, nbits);
It looks nice. :)
Reviewed-by Alex Shi <[email protected]>