Skip to contentSkip to conversation

lib/test_bitmap: Make use of EXP2_IN_BITS

PATCH Applied Andy Shevchenko 2 participants 2 messages Jan 21, 2020 – Jan 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/test_bitmap: Make use of EXP2_IN_BITS

The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper") introduced some new test cases to the test_bitmap.c module. Among these it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.

---
 lib/test_bitmap.c | 2 ++
 1 file changed, 2 insertions(+)
lib/test_bitmap.c +2 -0
index 61ed71c1daba..6b13150667f5 100644
@@ -278,6 +278,8 @@ static void __init test_replace(void)
 	unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
 	DECLARE_BITMAP(bmap, 1024);
 
+	BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
+
 	bitmap_zero(bmap, 1024);
 	bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
 	expect_eq_bitmap(bmap, exp3_0_1, nbits);
Signature · 1 line
2.24.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Andy Shevchenko

The commit 30544ed5de43 ("lib/bitmap: introduce bitmap_replace() helper") introduced some new test cases to the test_bitmap.c module. Among these it also introduced an (unused) definition. Let's make use of EXP2_IN_BITS.

---
 lib/test_bitmap.c | 2 ++
 1 file changed, 2 insertions(+)
lib/test_bitmap.c +0 -0
index 61ed71c1daba..6b13150667f5 100644

lib/test_bitmap.c static void __init test_replace(void) · line 285

Quoted 8 lines
lib/test_bitmap.c +2 -0
@@ -278,6 +278,8 @@ static void __init test_replace(void)
 	unsigned int nlongs = DIV_ROUND_UP(nbits, BITS_PER_LONG);
 	DECLARE_BITMAP(bmap, 1024);
 
+	BUILD_BUG_ON(EXP2_IN_BITS < nbits * 2);
+
 	bitmap_zero(bmap, 1024);
 	bitmap_replace(bmap, &exp2[0 * nlongs], &exp2[1 * nlongs], exp2_to_exp3_mask, nbits);
 	expect_eq_bitmap(bmap, exp3_0_1, nbits);

It looks nice. :)