Skip to contentSkip to conversation

board/ci20/genimage.cfg: drop hardcoded rootfs partition size

PATCH New Peter Korsgaard 1 participant 3 messages Jan 21, 2020 – Mar 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/ci20/genimage.cfg: drop hardcoded rootfs partition size

As recently reported to the list:
http://lists.busybox.net/pipermail/buildroot/2020-January/271937.html

The hardcoded rootfs partition size can lead to hard to understand build failures if more packages are added.

So drop the hardcoded partition size. Genimage will then size the partition to match the size of the rootfs image (which by default is also 60MB for ext4).

---
 board/ci20/genimage.cfg | 1 -
 1 file changed, 1 deletion(-)
board/ci20/genimage.cfg +0 -1
index fa3e7368d3..5f8a16c610 100644
@@ -24,6 +24,5 @@ image sdcard.img {
         partition-type = 0x83
         image = "rootfs.ext4"
         offset = 2M
-        size = 60M
     }
 }
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 board/ci20/genimage.cfg: drop hardcoded rootfs partition size

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

As recently reported to the list:
http://lists.busybox.net/pipermail/buildroot/2020-January/271937.html

Quoted 7 lines

The hardcoded rootfs partition size can lead to hard to understand build failures if more packages are added.

So drop the hardcoded partition size. Genimage will then size the partition to match the size of the rootfs image (which by default is also 60MB for ext4).

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 board/ci20/genimage.cfg: drop hardcoded rootfs partition size

In reply to Peter Korsgaard
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

As recently reported to the list:
http://lists.busybox.net/pipermail/buildroot/2020-January/271937.html

Quoted 7 lines

The hardcoded rootfs partition size can lead to hard to understand build failures if more packages are added.

So drop the hardcoded partition size. Genimage will then size the partition to match the size of the rootfs image (which by default is also 60MB for ext4).

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard