arm64: dts: rockchip: fix px30 lvds ports
Subsystems (2)
Heiko Stuebner
maintainerPATCH v2 1/1 arm64: dts: rockchip: fix px30 lvds ports
From: Heiko Stuebner <[email protected]>
The lvds controller has two ports. port@0 for the connection to the display controller(s) and port@1 for the connection to the panel, so should have a ports node covering the port@x nodes.
---
changes in v2:
- added review from Miquel
- removed global #address+size-cells from lvds as suggested by Robin Murphy
arch/arm64/boot/dts/rockchip/px30.dtsi | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
arch/arm64/boot/dts/rockchip/px30.dtsi +14 -11
@@ -413,27 +413,30 @@ io_domains: io-domains { lvds: lvds { compatible = "rockchip,px30-lvds"; - #address-cells = <1>; - #size-cells = <0>; phys = <&dsi_dphy>; phy-names = "dphy"; rockchip,grf = <&grf>; rockchip,output = "lvds"; status = "disabled"; - port@0 { - reg = <0>; + ports { #address-cells = <1>; #size-cells = <0>; - lvds_vopb_in: endpoint@0 { + port@0 { reg = <0>; - remote-endpoint = <&vopb_out_lvds>; - }; - - lvds_vopl_in: endpoint@1 { - reg = <1>; - remote-endpoint = <&vopl_out_lvds>; + #address-cells = <1>; + #size-cells = <0>; + + lvds_vopb_in: endpoint@0 { + reg = <0>; + remote-endpoint = <&vopb_out_lvds>; + }; + + lvds_vopl_in: endpoint@1 { + reg = <1>; + remote-endpoint = <&vopl_out_lvds>; + }; }; }; };
Signature · 1 line
2.24.1
Heiko Stuebner
maintainerPATCH 1/1 arm64: dts: rockchip: fix px30 lvds ports
From: Heiko Stuebner <[email protected]>
The lvds controller has two ports. port@0 for the connection to the display controller(s) and port@1 for the connection to the panel, so should have a ports node covering the port@x nodes.
--- arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)
arch/arm64/boot/dts/rockchip/px30.dtsi +14 -9
@@ -421,19 +421,24 @@ lvds: lvds { rockchip,output = "lvds"; status = "disabled"; - port@0 { - reg = <0>; + ports { #address-cells = <1>; #size-cells = <0>; - lvds_vopb_in: endpoint@0 { + port@0 { reg = <0>; - remote-endpoint = <&vopb_out_lvds>; - }; - - lvds_vopl_in: endpoint@1 { - reg = <1>; - remote-endpoint = <&vopl_out_lvds>; + #address-cells = <1>; + #size-cells = <0>; + + lvds_vopb_in: endpoint@0 { + reg = <0>; + remote-endpoint = <&vopb_out_lvds>; + }; + + lvds_vopl_in: endpoint@1 { + reg = <1>; + remote-endpoint = <&vopl_out_lvds>; + }; }; }; };
Signature · 1 line
2.24.1
Heiko Stuebner
maintainerAm Dienstag, 21. Januar 2020, 23:20:55 CET schrieb Heiko Stuebner:
Quoted 7 lines
From: Heiko Stuebner <[email protected]>
The lvds controller has two ports. port@0 for the connection to the display controller(s) and port@1 for the connection to the panel, so should have a ports node covering the port@x nodes.
Signed-off-by Heiko Stuebner <[email protected]>
ignore this second one please :-)
Something went wrong when sending.
Heiko Stuebner
maintainerAm Dienstag, 21. Januar 2020, 23:20:54 CET schrieb Heiko Stuebner:
Quoted 8 lines
From: Heiko Stuebner <[email protected]>
The lvds controller has two ports. port@0 for the connection to the display controller(s) and port@1 for the connection to the panel, so should have a ports node covering the port@x nodes.
Signed-off-by Heiko Stuebner <[email protected]>Reviewed-by Miquel Raynal <[email protected]>
applied for 5.7