devlink: Add enable_ecn boolean generic parameter
Subsystems (3)
PATCH 1/1 devlink: Add enable_ecn boolean generic parameter
enable_ecn - Enables Explicit Congestion Notification characteristic of the device.
Cc Jiri Pirko <[email protected]>
Signed-off-by Pavan Chebbi <[email protected]>
--- include/net/devlink.h | 4 ++++ net/core/devlink.c | 5 +++++ 2 files changed, 9 insertions(+)
include/net/devlink.h +4 -0
@@ -403,6 +403,7 @@ enum devlink_param_generic_id {DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY ,DEVLINK_PARAM_GENERIC_ID_RESET_DEV_ON_DRV_PROBE ,DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE , +DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN ,/* add new param generic ids above here*/ __DEVLINK_PARAM_GENERIC_ID_MAX,
@@ -440,6 +441,9 @@ enum devlink_param_generic_id {#define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME "enable_roce"#define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE DEVLINK_PARAM_TYPE_BOOL +#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME "enable_ecn" +#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE DEVLINK_PARAM_TYPE_BOOL +#define DEVLINK_PARAM_GENERIC (_id, _cmodes, _get, _set, _validate) \ { \ .id = DEVLINK_PARAM_GENERIC_ID_##_id, \
net/core/devlink.c +5 -0
@@ -3011,6 +3011,11 @@ static int devlink_nl_cmd_flash_update(struct sk_buff *skb, .name = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME, .type = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE, }, + { + .id = DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN, + .name = DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME, + .type = DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE, + }, };static int devlink_param_generic_verify (const struct devlink_param *param)
Signature · 1 line
1.8.3.1
Quoted 5 lines · Wed, Jan 22, 2020 at 11:40:46AM CET, [email protected] wrote:
enable_ecn- Enables Explicit Congestion Notification characteristic of the device.Cc Jiri Pirko <[email protected]>Signed-off-by Pavan Chebbi <[email protected]>
NAK.
You are missing at least:
documentation
driver user
Quoted 46 lines
---
include/net/devlink.h| 4 ++++net/core/devlink.c| 5 +++++2 files changed, 9 insertions(+)include/net/devlink.h +4
-0@@ -403,6 +403,7 @@ enum devlink_param_generic_id {DEVLINK_PARAM_GENERIC_ID_FW_LOAD_POLICY ,DEVLINK_PARAM_GENERIC_ID_RESET_DEV_ON_DRV_PROBE ,DEVLINK_PARAM_GENERIC_ID_ENABLE_ROCE , +DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN ,/* add new param generic ids above here*/ __DEVLINK_PARAM_GENERIC_ID_MAX,@@ -440,6 +441,9 @@ enum devlink_param_generic_id {#define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME "enable_roce"#define DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE DEVLINK_PARAM_TYPE_BOOL +#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME "enable_ecn" +#define DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE DEVLINK_PARAM_TYPE_BOOL +#define DEVLINK_PARAM_GENERIC (_id, _cmodes, _get, _set, _validate) \ { \ .id = DEVLINK_PARAM_GENERIC_ID_##_id, \net/core/devlink.c +5
-0@@ -3011,6 +3011,11 @@ static int devlink_nl_cmd_flash_update(struct sk_buff *skb, .name = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_NAME, .type = DEVLINK_PARAM_GENERIC_ENABLE_ROCE_TYPE, }, + { + .id = DEVLINK_PARAM_GENERIC_ID_ENABLE_ECN, + .name = DEVLINK_PARAM_GENERIC_ENABLE_ECN_NAME, + .type = DEVLINK_PARAM_GENERIC_ENABLE_ECN_TYPE, + }, };static int devlink_param_generic_verify (const struct devlink_param *param)Signature · 1 line
1.8.3.1