Skip to contentSkip to conversation

test/crypto: remove repeated test and enable on QAT

PATCH In review Adam Dybkowski 3 participants 4 messages Jan 22, 2020 – Jan 28, 2020

lore
Share & tools
lore
#0 lore raw

v2 cover test/crypto: remove repeated test and enable on QAT

Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21).

---
v2:
* Repair referenced commit id.

Adam Dybkowski (1):
test/crypto: remove repeated test and enable on QAT

 app/test/test_cryptodev.c | 7 -------
 1 file changed, 7 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 test/crypto: remove repeated test and enable on QAT

Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21).

Fixes 157d0b11d204 ("test/crypto: add capability checks")
Fixes b26ef1a11f21 ("test/crypto: fix missing operation status check")
---
 app/test/test_cryptodev.c | 7 -------
 1 file changed, 7 deletions(-)
app/test/test_cryptodev.c +0 -7
index 749c3c1b2..12c113848 100644
@@ -11158,11 +11158,6 @@ test_AES_GCM_auth_encrypt_SGL_out_of_place_1500B_2000B(void)
 static int
 test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_1seg(void)
 {
-	/* This test is not for QAT PMD */
-	if (gbl_driver_id == rte_cryptodev_driver_id_get(
-			RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)))
-		return -ENOTSUP;
-
 	return test_authenticated_encryption_SGL(
 			&gcm_test_case_8, OUT_OF_PLACE, 400,
 			gcm_test_case_8.plaintext.len);
@@ -11617,8 +11612,6 @@ static struct unit_test_suite cryptodev_testsuite  = {
 		/** AES GCM Authenticated Encryption */
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_AES_GCM_auth_encrypt_SGL_in_place_1500B),
-		TEST_CASE_ST(ut_setup, ut_teardown,
-			test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_1seg),
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_AES_GCM_auth_encrypt_SGL_out_of_place_400B_400B),
 		TEST_CASE_ST(ut_setup, ut_teardown,
Signature · 1 line
2.17.1
Acked-by on v2 1/1
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: Dybkowski, AdamX <[email protected]>
Sent: Wednesday, January 22, 2020 2:42 PM
To: [email protected]; Trahe, Fiona <[email protected]>; [email protected]
Cc: Dybkowski, AdamX <[email protected]>
Subject: [PATCH v2 1/1] test/crypto: remove repeated test and enable on QAT

Quoted 8 lines

Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21).

Fixes 157d0b11d204 ("test/crypto: add capability checks")
Fixes b26ef1a11f21 ("test/crypto: fix missing operation status check")
#3 lore raw
Quoted 10 lines
Quoted 9 lines

Remove one AES GCM scatter-gather unit test repetition and enable this test on QAT (after a fix included in the commit b26ef1a11f21).

Fixes 157d0b11d204 ("test/crypto: add capability checks")
Fixes b26ef1a11f21 ("test/crypto: fix missing operation status check")

Squashed to original commit as they were not applied to Master

Thanks.