Skip to contentSkip to conversation

locktest: Makefile.am: remove host compiler costraint

PATCH In review Giulio Benetti 3 participants 16 messages Jan 15, 2020 – Feb 7, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 locktest: Makefile.am: remove host compiler costraint

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

---
 tools/locktest/Makefile.am | 3 ---
 1 file changed, 3 deletions(-)
tools/locktest/Makefile.am +0 -3
index 3156815d..e8914655 100644
@@ -1,8 +1,5 @@
 ## Process this file with automake to produce Makefile.in
 
-CC=$(CC_FOR_BUILD)
-LIBTOOL = @LIBTOOL@ --tag=CC
-
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
 testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
Signature · 1 line
2.20.1
Reviewed-by Tested-by on v1 1/1
#1 lore raw

Hi,

Quoted 7 lines

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

NOTE: as I understand it's a compilation issue of a tool, so I didn't run rpcgen, I just test various compilation variants for buildroot.

Kind regards,
Petr

Quoted 17 lines
---
 tools/locktest/Makefile.am | 3 ---
 1 file changed, 3 deletions(-)
tools/locktest/Makefile.am +0 -3
index 3156815d..e8914655 100644
@@ -1,8 +1,5 @@
 ## Process this file with automake to produce Makefile.in
 
-CC=$(CC_FOR_BUILD)
-LIBTOOL = @LIBTOOL@ --tag=CC
-
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
 testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
#2 lore raw

Petr,

Quoted 8 lines · Petr Vorel

Hi,

Quoted 5 lines

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 5 lines
Quoted 1 line

NOTE: as I understand it's a compilation issue of a tool, so I didn't run rpcgen, I just test various compilation variants for buildroot.

Just to be clear... Giulio's patch, removing CC and LIBTOOL from the locktest/Makefile.am does allows your cross build to succeed, correct?

steved.

Quoted 22 lines

Kind regards,
Petr

Quoted 17 lines
---
 tools/locktest/Makefile.am | 3 ---
 1 file changed, 3 deletions(-)
tools/locktest/Makefile.am +0 -3
index 3156815d..e8914655 100644
@@ -1,8 +1,5 @@
 ## Process this file with automake to produce Makefile.in
 
-CC=$(CC_FOR_BUILD)
-LIBTOOL = @LIBTOOL@ --tag=CC
-
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
 testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
#3 lore raw

Hi Steve,

Quoted 6 lines
Quoted 5 lines
Quoted 5 lines

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

NOTE: as I understand it's a compilation issue of a tool, so I didn't run rpcgen, I just test various compilation variants for buildroot.

Just to be clear... Giulio's patch, removing CC and LIBTOOL from the locktest/Makefile.am does allows your cross build to succeed, correct?

Yes, for buildroot it's ok. I'm just not able to verify Gentoo.

Quoted 1 line

steved.

Kind regards,
Petr

#4 lore raw
Quoted 8 lines · Petr Vorel

Hi Steve,

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

NOTE: as I understand it's a compilation issue of a tool, so I didn't run rpcgen, I just test various compilation variants for buildroot.

Just to be clear... Giulio's patch, removing CC and LIBTOOL from the locktest/Makefile.am does allows your cross build to succeed, correct?

Yes, for buildroot it's ok. I'm just not able to verify Gentoo.

Thanks... Lets cross that path when get there...

steved.

Quoted 6 lines
Quoted 2 lines

steved.

Kind regards,
Petr

#5 lore raw
In reply to Giulio Benetti
Quoted 7 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Committed... (tag: nfs-utils-2-4-3-rc6)

steved.

Quoted 18 lines
---
 tools/locktest/Makefile.am | 3 ---
 1 file changed, 3 deletions(-)
tools/locktest/Makefile.am +0 -3
index 3156815d..e8914655 100644
@@ -1,8 +1,5 @@
 ## Process this file with automake to produce Makefile.in
 
-CC=$(CC_FOR_BUILD)
-LIBTOOL = @LIBTOOL@ --tag=CC
-
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
 testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
#6 lore raw

Hi Steve,

Quoted 11 lines · Steve Dickson
Quoted 7 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 20 lines

steved.

Quoted 18 lines
---
  tools/locktest/Makefile.am | 3 ---
  1 file changed, 3 deletions(-)
tools/locktest/Makefile.am +0 -3
index 3156815d..e8914655 100644
@@ -1,8 +1,5 @@
  ## Process this file with automake to produce Makefile.in
 
-CC=$(CC_FOR_BUILD)
-LIBTOOL = @LIBTOOL@ --tag=CC
-
  noinst_PROGRAMS = testlk
  testlk_SOURCES = testlk.c
  testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
#7 lore raw

Hi Steve, Petr,

Quoted 12 lines · Giulio Benetti

Hi Steve,

Quoted 9 lines · Steve Dickson
Quoted 6 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Kind regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#8 lore raw
Quoted 15 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 12 lines · Giulio Benetti

Hi Steve,

Quoted 9 lines · Steve Dickson
Quoted 6 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Good to hear... Thank you for your effort!!!!

steved.

#9 lore raw
Quoted 18 lines · Steve Dickson
Quoted 15 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 12 lines · Giulio Benetti

Hi Steve,

Quoted 9 lines · Steve Dickson
Quoted 6 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Kinds regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#10 lore raw
Quoted 22 lines · Giulio Benetti
Quoted 21 lines · Steve Dickson
Quoted 18 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 15 lines · Giulio Benetti

Hi Steve,

Quoted 11 lines · Steve Dickson
Quoted 7 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Committed... (tag: nfs-utils-2-4-3-rc6)

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Go ahead and send it... I'll make a release after that...

steved.

Quoted 2 lines

Kinds regards

#11 lore raw

Hi Steve,

Quoted 28 lines · Steve Dickson
Quoted 25 lines · Giulio Benetti
Quoted 24 lines · Steve Dickson
Quoted 21 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 17 lines · Giulio Benetti

Hi Steve,

Quoted 11 lines · Steve Dickson
Quoted 7 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Just tried, it builds correctly on latest Gentoo.

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Go ahead and send it... I'll make a release after that...

You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-)

Thank you
Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
Quoted 5 lines

steved.

Quoted 2 lines

Kinds regards

#12 lore raw
Quoted 31 lines · Giulio Benetti

Hi Steve,

Quoted 28 lines · Steve Dickson
Quoted 25 lines · Giulio Benetti
Quoted 24 lines · Steve Dickson
Quoted 21 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 17 lines · Giulio Benetti

Hi Steve,

Quoted 11 lines · Steve Dickson
Quoted 7 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Just tried, it builds correctly on latest Gentoo.

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Go ahead and send it... I'll make a release after that...

You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-)

Ok... I'll try to get to it sometime this week.

steved.

#13 lore raw
Quoted 35 lines · Steve Dickson
Quoted 32 lines · Giulio Benetti

Hi Steve,

Quoted 29 lines · Steve Dickson
Quoted 26 lines · Giulio Benetti
Quoted 25 lines · Steve Dickson
Quoted 22 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 12 lines · Giulio Benetti

Hi Steve,

Quoted 9 lines · Steve Dickson
Quoted 6 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Go ahead and send it... I'll make a release after that...

You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-)

Ok... I'll try to get to it sometime this week.

Great, thank you!

Quoted 2 lines

steved.

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#14 lore raw

Kindly ping

Giulio Benetti
Inviato da iPhone

Quoted 52 lines

Il giorno 27 gen 2020, alle ore 20:51, Giulio Benetti <[email protected]> ha scritto:

Quoted 33 lines · Steve Dickson
Quoted 33 lines · Giulio Benetti

Hi Steve,

Quoted 29 lines · Steve Dickson
Quoted 26 lines · Giulio Benetti
Quoted 25 lines · Steve Dickson
Quoted 22 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 12 lines · Giulio Benetti

Hi Steve,

Quoted 9 lines · Steve Dickson
Quoted 6 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Go ahead and send it... I'll make a release after that...

You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-)

Ok... I'll try to get to it sometime this week.

Great, thank you!

Quoted 1 line

steved.

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#15 lore raw
Quoted 1 line · Giulio Benetti

Kindly ping

Working on it... ;-)

Looking to get some manpages in as well as a few other minor issues...

steved.

Quoted 57 lines

Giulio Benetti
Inviato da iPhone

Quoted 52 lines

Il giorno 27 gen 2020, alle ore 20:51, Giulio Benetti <[email protected]> ha scritto:

Quoted 33 lines · Steve Dickson
Quoted 33 lines · Giulio Benetti

Hi Steve,

Quoted 29 lines · Steve Dickson
Quoted 26 lines · Giulio Benetti
Quoted 25 lines · Steve Dickson
Quoted 22 lines · Giulio Benetti

Hi Steve, Petr,

Quoted 12 lines · Giulio Benetti

Hi Steve,

Quoted 9 lines · Steve Dickson
Quoted 6 lines · Giulio Benetti

Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments.

Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Committed... (tag: nfs-utils-2-4-3-rc6)

I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure.

Just tried, it builds correctly on latest Gentoo.

Quoted 8 lines
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Quoted 1 line

Good to hear... Thank you for your effort!!!!

It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent.

Go ahead and send it... I'll make a release after that...

You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-)

Ok... I'll try to get to it sometime this week.

Great, thank you!

Quoted 1 line

steved.

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas