platform/x86: intel_scu_ipc: A fix and cleanups
Subsystems (4)
Mika Westerberg
maintainercover platform/x86: intel_scu_ipc: A fix and cleanups
Hi,
As suggested by Greg in the discussion around my SCU/PMC IPC rework series [1], I split the cleanups touching intel_scu_ipc driver in a separate series that can be applied independly.
The first patch fixes interrupt support to work in Intel Merrifield. The rest of the patches are cleanups mostly removing code that is not used anywhere.
[1] https://lkml.org/lkml/2020/1/21/678
Mika Westerberg (10):
platform/x86: intel_scu_ipc: Fix interrupt support
platform/x86: intel_scu_ipc: Add constants for register offsets platform/x86: intel_scu_ipc: Remove Lincroft support
platform/x86: intel_scu_ipc: Drop intel_scu_ipc_i2c_cntrl() platform/x86: intel_scu_ipc: Sleeping is fine when polling platform/x86: intel_scu_ipc: Drop unused prototype intel_scu_ipc_fw_update() platform/x86: intel_scu_ipc: Drop unused macros
platform/x86: intel_scu_ipc: Drop intel_scu_ipc_io[read|write][8|16]() platform/x86: intel_scu_ipc: Drop intel_scu_ipc_raw_command() platform/x86: intel_scu_ipc: Reformat kernel-doc comments of exported functions
arch/x86/include/asm/intel_scu_ipc.h | 20 -- drivers/platform/x86/intel_scu_ipc.c | 414 ++++++--------------------- 2 files changed, 91 insertions(+), 343 deletions(-)
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 1/10 platform/x86: intel_scu_ipc: Fix interrupt support
Currently the driver has disabled interrupt support for Tangier but actually interrupt works just fine if the command is not written twice in a row. Also we need to ack the interrupt in the handler.
--- drivers/platform/x86/intel_scu_ipc.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-)
drivers/platform/x86/intel_scu_ipc.c +8 -13
@@ -67,26 +67,22 @@struct intel_scu_ipc_pdata_t {u32 i2c_base;u32 i2c_len; -u8 irq_mode; };static const struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = { .i2c_base =0xff12b000 , .i2c_len =0x10 , - .irq_mode =0 , };/* Penwell and Cloverview */ static const struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = { .i2c_base =0xff12b000 , .i2c_len =0x10 , - .irq_mode =1 , };static const struct intel_scu_ipc_pdata_t intel_scu_ipc_tangier_pdata = { .i2c_base =0xff00d000 , .i2c_len =0x10 , - .irq_mode =0 , };struct intel_scu_ipc_dev {
@@ -99,6 +95,9 @@ struct intel_scu_ipc_dev {static struct intel_scu_ipc_dev ipcdev;/* Only one for now */ +#define IPC_STATUS 0x04 +#define IPC_STATUS_IRQ BIT(2) +/* * IPC Read Buffer (Read Only): * 16 byte buffer for receiving data from SCU, if IPC command
@@ -120,11 +119,8 @@ static DEFINE_MUTEX(ipclock); /* lock used to prevent multiple call to SCU */*/ static inline void ipc_command (struct intel_scu_ipc_dev *scu,u32 cmd) { -if (scu->irq_mode) { -reinit_completion (&scu->cmd_complete); -writel (cmd |IPC_IOC , scu->ipc_base); - } -writel (cmd, scu->ipc_base); +reinit_completion (&scu->cmd_complete); +writel (cmd |IPC_IOC , scu->ipc_base); }/*
@@ -610,9 +606,10 @@ EXPORT_SYMBOL(intel_scu_ipc_i2c_cntrl);static irqreturn_t ioc (int irq,void *dev_id) {struct intel_scu_ipc_dev *scu = dev_id; +int status =ipc_read_status (scu); -if (scu->irq_mode) -complete (&scu->cmd_complete); +writel (status |IPC_STATUS_IRQ , scu->ipc_base +IPC_STATUS ); +complete (&scu->cmd_complete);return IRQ_HANDLED ; }
@@ -638,8 +635,6 @@ static int ipc_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (!pdata)return -ENODEV ; - scu->irq_mode = pdata->irq_mode; - err =pcim_enable_device (pdev);if (err)return err;
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 2/10 platform/x86: intel_scu_ipc: Add constants for register offsets
In reply to Mika WesterbergThis makes the code more readable. These are taken from intel_pmc_ipc.c which implements the same thing.
--- drivers/platform/x86/intel_scu_ipc.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-)
drivers/platform/x86/intel_scu_ipc.c +11 -9
@@ -97,12 +97,14 @@ static struct intel_scu_ipc_dev ipcdev; /* Only one for now */#define IPC_STATUS 0x04#define IPC_STATUS_IRQ BIT(2) +#define IPC_STATUS_ERR BIT(1) +#define IPC_STATUS_BUSY BIT(0)/* -* IPC Read Buffer (Read Only): -* 16 byte buffer for receiving data from SCU, if IPC command -* processing results in response data +* IPC Write/Read Buffers: +* 16 byte buffer for sending and receiving data to and from SCU. */ +#define IPC_WRITE_BUFFER 0x80#define IPC_READ_BUFFER 0x90#define IPC_I2C_CNTRL_ADDR 0
@@ -131,7 +133,7 @@ static inline void ipc_command(struct intel_scu_ipc_dev *scu, u32 cmd)*/ static inline void ipc_data_writel (struct intel_scu_ipc_dev *scu,u32 data,u32 offset) { -writel (data, scu->ipc_base +0x80 + offset); +writel (data, scu->ipc_base +IPC_WRITE_BUFFER + offset); }/*
@@ -143,7 +145,7 @@ static inline void ipc_data_writel(struct intel_scu_ipc_dev *scu, u32 data, u32*/ static inline u8 ipc_read_status (struct intel_scu_ipc_dev *scu) { -return __raw_readl (scu->ipc_base +0x04 ); +return __raw_readl (scu->ipc_base +IPC_STATUS ); }/* Read ipc byte data */
@@ -165,17 +167,17 @@ static inline int busy_loop(struct intel_scu_ipc_dev *scu)u32 loop_count =100000 ;/* break if scu doesn't reset busy bit after huge retry */ -while ((status &BIT (0 )) && --loop_count) { +while ((status &IPC_STATUS_BUSY ) && --loop_count) {udelay (1 );/* scu processing time is in few u secods */ status =ipc_read_status (scu); } -if (status &BIT (0 )) { +if (status &IPC_STATUS_BUSY ) {dev_err (scu->dev,"IPC timed out" );return -ETIMEDOUT ; } -if (status &BIT (1 )) +if (status &IPC_STATUS_ERR )return -EIO ;return 0 ;
@@ -192,7 +194,7 @@ static inline int ipc_wait_for_interrupt(struct intel_scu_ipc_dev *scu) } status =ipc_read_status (scu); -if (status &BIT (1 )) +if (status &IPC_STATUS_ERR )return -EIO ;return 0 ;
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 3/10 platform/x86: intel_scu_ipc: Remove Lincroft support
In reply to Mika WesterbergMoorestown support was removed years ago with by the commit 1a8359e411eb ("x86/mid: Remove Intel Moorestown"). Lincroft is the CPU side chip of Moorestown and not supported anymore so remove the code from the driver.
--- drivers/platform/x86/intel_scu_ipc.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/platform/x86/intel_scu_ipc.c +0 -7
@@ -58,7 +58,6 @@#define IPC_RWBUF_SIZE 20/* IPC Read buffer Size */ #define IPC_IOC 0x100/* IPC command register IOC bit */ -#define PCI_DEVICE_ID_LINCROFT 0x082a#define PCI_DEVICE_ID_PENWELL 0x080e#define PCI_DEVICE_ID_CLOVERVIEW 0x08ea#define PCI_DEVICE_ID_TANGIER 0x11a0
@@ -69,11 +68,6 @@ struct intel_scu_ipc_pdata_t {u32 i2c_len; }; -static const struct intel_scu_ipc_pdata_t intel_scu_ipc_lincroft_pdata = { - .i2c_base =0xff12b000 , - .i2c_len =0x10 , -}; -/* Penwell and Cloverview */ static const struct intel_scu_ipc_pdata_t intel_scu_ipc_penwell_pdata = { .i2c_base =0xff12b000 ,
@@ -670,7 +664,6 @@ static int ipc_probe(struct pci_dev *pdev, const struct pci_device_id *id)#define SCU_DEVICE (id, pdata) {PCI_VDEVICE(INTEL, id), (kernel_ulong_t)&pdata}static const struct pci_device_id pci_ids[] = { -SCU_DEVICE (PCI_DEVICE_ID_LINCROFT , intel_scu_ipc_lincroft_pdata),SCU_DEVICE (PCI_DEVICE_ID_PENWELL , intel_scu_ipc_penwell_pdata),SCU_DEVICE (PCI_DEVICE_ID_CLOVERVIEW , intel_scu_ipc_penwell_pdata),SCU_DEVICE (PCI_DEVICE_ID_TANGIER , intel_scu_ipc_tangier_pdata),
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 4/10 platform/x86: intel_scu_ipc: Drop intel_scu_ipc_i2c_cntrl()
In reply to Mika WesterbergThere are no existing users for this functionality so drop it from the driver completely. This also means we don't need to keep the struct intel_scu_ipc_pdata_t around anymore so remove that as well.
--- arch/x86/include/asm/intel_scu_ipc.h | 3 - drivers/platform/x86/intel_scu_ipc.c | 90 +--------------------------- 2 files changed, 3 insertions(+), 90 deletions(-)
arch/x86/include/asm/intel_scu_ipc.h +0 -3
@@ -53,9 +53,6 @@ int intel_scu_ipc_command(int cmd, int sub, u32 *in, int inlen,int intel_scu_ipc_raw_command (int cmd,int sub,u8 *in,int inlen,u32 *out,int outlen,u32 dptr,u32 sptr); -/* I2C control api */ -int intel_scu_ipc_i2c_cntrl (u32 addr,u32 *data); -/* Update FW version */ int intel_scu_ipc_fw_update (u8 *buffer,u32 length);
drivers/platform/x86/intel_scu_ipc.c +3 -87
134 lines not on this page · raw message
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 5/10 platform/x86: intel_scu_ipc: Sleeping is fine when polling
In reply to Mika WesterbergThere is no reason why the driver would need to block other threads from running the CPU while it is waiting for the SCU IPC to complete its work. For this reason switch the driver to use usleep_range() instead with a bit more relaxed polling loop.
Also add constant for the timeout and use the same value for both polling and interrupt modes.
--- drivers/platform/x86/intel_scu_ipc.c | 29 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 15 deletions(-)
drivers/platform/x86/intel_scu_ipc.c +14 -15
@@ -79,6 +79,9 @@ static struct intel_scu_ipc_dev ipcdev; /* Only one for now */#define IPC_WRITE_BUFFER 0x80#define IPC_READ_BUFFER 0x90 +/* Timeout in jiffies */ +#define IPC_TIMEOUT (3 * HZ) +static DEFINE_MUTEX (ipclock);/* lock used to prevent multiple call to SCU */ /*
@@ -132,24 +135,20 @@ static inline u32 ipc_data_readl(struct intel_scu_ipc_dev *scu, u32 offset)/* Wait till scu status is busy */ static inline int busy_loop (struct intel_scu_ipc_dev *scu) { -u32 status =ipc_read_status (scu); -u32 loop_count =100000 ; +unsigned long end = jiffies +msecs_to_jiffies (IPC_TIMEOUT ); -/* break if scu doesn't reset busy bit after huge retry */ -while ((status &IPC_STATUS_BUSY ) && --loop_count) { -udelay (1 );/* scu processing time is in few u secods */ - status =ipc_read_status (scu); - } +do { +u32 status; -if (status &IPC_STATUS_BUSY ) { -dev_err (scu->dev,"IPC timed out" ); -return -ETIMEDOUT ; - } + status =ipc_read_status (scu); +if (!(status &IPC_STATUS_BUSY )) +return (status &IPC_STATUS_ERR ) ? -EIO :0 ; -if (status &IPC_STATUS_ERR ) -return -EIO ; +usleep_range (50 ,100 ); + }while (time_before (jiffies, end)); -return 0 ; +dev_err (scu->dev,"IPC timed out" ); +return -ETIMEDOUT ; }/* Wait till ipc ioc interrupt is received or timeout in 3 HZ */
@@ -157,7 +156,7 @@ static inline int ipc_wait_for_interrupt(struct intel_scu_ipc_dev *scu) {int status; -if (!wait_for_completion_timeout (&scu->cmd_complete,3 *HZ )) { +if (!wait_for_completion_timeout (&scu->cmd_complete,IPC_TIMEOUT )) {dev_err (scu->dev,"IPC timed out\n" );return -ETIMEDOUT ; }
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 6/10 platform/x86: intel_scu_ipc: Drop unused prototype intel_scu_ipc_fw_update()
In reply to Mika WesterbergThere is no implementation for that anymore so drop the prototype.
--- arch/x86/include/asm/intel_scu_ipc.h | 3 --- 1 file changed, 3 deletions(-)
arch/x86/include/asm/intel_scu_ipc.h +0 -3
@@ -53,9 +53,6 @@ int intel_scu_ipc_command(int cmd, int sub, u32 *in, int inlen,int intel_scu_ipc_raw_command (int cmd,int sub,u8 *in,int inlen,u32 *out,int outlen,u32 dptr,u32 sptr); -/* Update FW version */ -int intel_scu_ipc_fw_update (u8 *buffer,u32 length); -extern struct blocking_notifier_head intel_scu_notifier;static inline void intel_scu_notifier_add (struct notifier_block *nb)
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 7/10 platform/x86: intel_scu_ipc: Drop unused macros
In reply to Mika WesterbergThese macros are not used anywhere in the driver so drop them.
--- drivers/platform/x86/intel_scu_ipc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/platform/x86/intel_scu_ipc.c +1 -5
@@ -26,11 +26,7 @@#include <asm/intel_scu_ipc.h> /* IPC defines the following message types */ -#define IPCMSG_WATCHDOG_TIMER 0xF8/* Set Kernel Watchdog Threshold */ -#define IPCMSG_BATTERY 0xEF/* Coulomb Counter Accumulator */ -#define IPCMSG_FW_UPDATE 0xFE/* Firmware update */ -#define IPCMSG_PCNTRL 0xFF/* Power controller unit read/write */ -#define IPCMSG_FW_REVISION 0xF4/* Get firmware revision */ +#define IPCMSG_PCNTRL 0xff/* Power controller unit read/write */ /* Command id associated with message IPCMSG_PCNTRL */ #define IPC_CMD_PCNTRL_W 0/* Register write */
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 8/10 platform/x86: intel_scu_ipc: Drop intel_scu_ipc_io[read|write][8|16]()
In reply to Mika WesterbergThere are no users for these so we can remove them.
--- arch/x86/include/asm/intel_scu_ipc.h | 12 ----- drivers/platform/x86/intel_scu_ipc.c | 68 ---------------------------- 2 files changed, 80 deletions(-)
arch/x86/include/asm/intel_scu_ipc.h +0 -12
@@ -22,24 +22,12 @@/* Read single register */ int intel_scu_ipc_ioread8 (u16 addr,u8 *data); -/* Read two sequential registers */ -int intel_scu_ipc_ioread16 (u16 addr,u16 *data); - -/* Read four sequential registers */ -int intel_scu_ipc_ioread32 (u16 addr,u32 *data); -/* Read a vector */ int intel_scu_ipc_readv (u16 *addr,u8 *data,int len);/* Write single register */ int intel_scu_ipc_iowrite8 (u16 addr,u8 data); -/* Write two sequential registers */ -int intel_scu_ipc_iowrite16 (u16 addr,u16 data); - -/* Write four sequential registers */ -int intel_scu_ipc_iowrite32 (u16 addr,u32 data); -/* Write a vector */ int intel_scu_ipc_writev (u16 *addr,u8 *data,int len);
drivers/platform/x86/intel_scu_ipc.c +0 -68
80 lines not on this page · raw message
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 9/10 platform/x86: intel_scu_ipc: Drop intel_scu_ipc_raw_command()
In reply to Mika WesterbergThere is no user for this function so we can drop it from the driver.
--- arch/x86/include/asm/intel_scu_ipc.h | 2 - drivers/platform/x86/intel_scu_ipc.c | 63 ---------------------------- 2 files changed, 65 deletions(-)
arch/x86/include/asm/intel_scu_ipc.h +0 -2
@@ -38,8 +38,6 @@ int intel_scu_ipc_update_register(u16 addr, u8 data, u8 mask);int intel_scu_ipc_simple_command (int cmd,int sub);int intel_scu_ipc_command (int cmd,int sub,u32 *in,int inlen,u32 *out,int outlen); -int intel_scu_ipc_raw_command (int cmd,int sub,u8 *in,int inlen, -u32 *out,int outlen,u32 dptr,u32 sptr);extern struct blocking_notifier_head intel_scu_notifier;
drivers/platform/x86/intel_scu_ipc.c +0 -63
69 lines not on this page · raw message
Signature · 1 line
2.24.1
Mika Westerberg
maintainerPATCH 10/10 platform/x86: intel_scu_ipc: Reformat kernel-doc comments of exported functions
In reply to Mika WesterbergFormat kernel-doc comments of the exported functions to follow the typical format that does not have tab indentation. Also capitalize parameter descriptions and add a missing period.
No functional changes intended.
--- drivers/platform/x86/intel_scu_ipc.c | 112 +++++++++++++-------------- 1 file changed, 55 insertions(+), 57 deletions(-)
drivers/platform/x86/intel_scu_ipc.c +55 -57
@@ -222,14 +222,14 @@ static int pwr_reg_rdwr(u16 *addr, u8 *data, u32 count, u32 op, u32 id) }/** -* intel_scu_ipc_ioread8 - read a word via the SCU -* @addr: register on SCU -* @data: return pointer for read byte +* intel_scu_ipc_ioread8 - read a word via the SCU +* @addr: Register on SCU +* @data: Return pointer for read byte * -* Read a single register. Returns 0 on success or an error code. All -* locking between SCU accesses is handled for the caller. +* Read a single register. Returns %0 on success or an error code. All +* locking between SCU accesses is handled for the caller. * -* This function may sleep. +* This function may sleep. */ int intel_scu_ipc_ioread8 (u16 addr,u8 *data) {
@@ -238,14 +238,14 @@ int intel_scu_ipc_ioread8(u16 addr, u8 *data)EXPORT_SYMBOL (intel_scu_ipc_ioread8);/** -* intel_scu_ipc_iowrite8 - write a byte via the SCU -* @addr: register on SCU -* @data: byte to write +* intel_scu_ipc_iowrite8 - write a byte via the SCU +* @addr: Register on SCU +* @data: Byte to write * -* Write a single register. Returns 0 on success or an error code. All -* locking between SCU accesses is handled for the caller. +* Write a single register. Returns %0 on success or an error code. All +* locking between SCU accesses is handled for the caller. * -* This function may sleep. +* This function may sleep. */ int intel_scu_ipc_iowrite8 (u16 addr,u8 data) {
@@ -254,17 +254,17 @@ int intel_scu_ipc_iowrite8(u16 addr, u8 data)EXPORT_SYMBOL (intel_scu_ipc_iowrite8);/** -* intel_scu_ipc_readvv - read a set of registers -* @addr: register list -* @data: bytes to return -* @len: length of array +* intel_scu_ipc_readvv - read a set of registers +* @addr: Register list +* @data: Bytes to return +* @len: Length of array * -* Read registers. Returns 0 on success or an error code. All -* locking between SCU accesses is handled for the caller. +* Read registers. Returns %0 on success or an error code. All locking +* between SCU accesses is handled for the caller. * -* The largest array length permitted by the hardware is 5 items. +* The largest array length permitted by the hardware is 5 items. * -* This function may sleep. +* This function may sleep. */ int intel_scu_ipc_readv (u16 *addr,u8 *data,int len) {
@@ -273,18 +273,17 @@ int intel_scu_ipc_readv(u16 *addr, u8 *data, int len)EXPORT_SYMBOL (intel_scu_ipc_readv);/** -* intel_scu_ipc_writev - write a set of registers -* @addr: register list -* @data: bytes to write -* @len: length of array +* intel_scu_ipc_writev - write a set of registers +* @addr: Register list +* @data: Bytes to write +* @len: Length of array * -* Write registers. Returns 0 on success or an error code. All -* locking between SCU accesses is handled for the caller. +* Write registers. Returns %0 on success or an error code. All locking +* between SCU accesses is handled for the caller. * -* The largest array length permitted by the hardware is 5 items. -* -* This function may sleep. +* The largest array length permitted by the hardware is 5 items. * +* This function may sleep. */ int intel_scu_ipc_writev (u16 *addr,u8 *data,int len) {
@@ -293,19 +292,18 @@ int intel_scu_ipc_writev(u16 *addr, u8 *data, int len)EXPORT_SYMBOL (intel_scu_ipc_writev);/** -* intel_scu_ipc_update_register - r/m/w a register -* @addr: register address -* @bits: bits to update -* @mask: mask of bits to update +* intel_scu_ipc_update_register - r/m/w a register +* @addr: Register address +* @bits: Bits to update +* @mask: Mask of bits to update * -* Read-modify-write power control unit register. The first data argument -* must be register value and second is mask value -* mask is a bitmap that indicates which bits to update. -* 0 = masked. Don't modify this bit, 1 = modify this bit. -* returns 0 on success or an error code. +* Read-modify-write power control unit register. The first data argument +* must be register value and second is mask value mask is a bitmap that +* indicates which bits to update. %0 = masked. Don't modify this bit, %1 = +* modify this bit. returns %0 on success or an error code. * -* This function may sleep. Locking between SCU accesses is handled -* for the caller. +* This function may sleep. Locking between SCU accesses is handled +* for the caller. */ int intel_scu_ipc_update_register (u16 addr,u8 bits,u8 mask) {
@@ -315,16 +313,16 @@ int intel_scu_ipc_update_register(u16 addr, u8 bits, u8 mask)EXPORT_SYMBOL (intel_scu_ipc_update_register);/** -* intel_scu_ipc_simple_command - send a simple command -* @cmd: command -* @sub: sub type +* intel_scu_ipc_simple_command - send a simple command +* @cmd: Command +* @sub: Sub type * -* Issue a simple command to the SCU. Do not use this interface if -* you must then access data as any data values may be overwritten -* by another SCU access by the time this function returns. +* Issue a simple command to the SCU. Do not use this interface if you must +* then access data as any data values may be overwritten by another SCU +* access by the time this function returns. * -* This function may sleep. Locking for SCU accesses is handled for -* the caller. +* This function may sleep. Locking for SCU accesses is handled for the +* caller. */ int intel_scu_ipc_simple_command (int cmd,int sub) {
@@ -344,16 +342,16 @@ int intel_scu_ipc_simple_command(int cmd, int sub)EXPORT_SYMBOL (intel_scu_ipc_simple_command);/** -* intel_scu_ipc_command - command with data -* @cmd: command -* @sub: sub type -* @in: input data -* @inlen: input length in dwords -* @out: output data -* @outlein: output length in dwords +* intel_scu_ipc_command - command with data +* @cmd: Command +* @sub: Sub type +* @in: Input data +* @inlen: Input length in dwords +* @out: Output data +* @outlen: Output length in dwords * -* Issue a command to the SCU which involves data transfers. Do the -* data copies under the lock but leave it for the caller to interpret +* Issue a command to the SCU which involves data transfers. Do the +* data copies under the lock but leave it for the caller to interpret. */ int intel_scu_ipc_command (int cmd,int sub,u32 *in,int inlen,u32 *out,int outlen)
Signature · 1 line
2.24.1
Quoted 11 lines · Mika Westerberg
Hi,
As suggested by Greg in the discussion around my SCU/PMC IPC rework series [1], I split the cleanups touching
intel_scu_ipcdriver in a separate series that can be applied independly.The first patch fixes interrupt support to work in Intel Merrifield. The rest of the patches are cleanups mostly removing code that is not used anywhere.
Pushed to my review and testing queue, thanks!
Quoted 21 lines
[1] https://lkml.org/lkml/2020/1/21/678
Mika Westerberg (10):
platform/x86:intel_scu_ipc: Fix interrupt support
platform/x86:intel_scu_ipc: Add constants for register offsets platform/x86:intel_scu_ipc: Remove Lincroft support
platform/x86:intel_scu_ipc: Dropintel_scu_ipc_i2c_cntrl()platform/x86:intel_scu_ipc: Sleeping is fine when polling platform/x86:intel_scu_ipc: Drop unused prototypeintel_scu_ipc_fw_update()platform/x86:intel_scu_ipc: Drop unused macros
platform/x86:intel_scu_ipc: Drop intel_scu_ipc_io[read|write][8|16]() platform/x86:intel_scu_ipc: Dropintel_scu_ipc_raw_command()platform/x86:intel_scu_ipc: Reformat kernel-doc comments of exported functionsarch/x86/include/asm/intel_scu_ipc.h | 20 -- drivers/platform/x86/intel_scu_ipc.c | 414 ++++++--------------------- 2 files changed, 91 insertions(+), 343 deletions(-)--
2.24.1
Signature · 2 lines
With Best Regards, Andy Shevchenko